From patchwork Thu Sep 16 15:31:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Cai,Huoqing" X-Patchwork-Id: 12499407 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C43F1C4332F for ; Thu, 16 Sep 2021 15:34:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C83E61246 for ; Thu, 16 Sep 2021 15:34:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C83E61246 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baidu.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5mOV4gkZP4o6Dlyljz8V78ehV86JRicwvZEPhJMqPfE=; b=csIIfgK+J+tDa1 zPUoS7k06JT3yeQ5aLfYnZZ25yJKXqS1wd0NQE3XL8IZuaZ09tdJVg91DTtumTnpEih3fEKTRDRrT C1ZcilbHGraNhgxXH8NGeSnGRiLIWVQlQnVDw4/g0OH/KRe+Tk6+vUnYPQuyUcyLlvy/SyQ7yJkqC wV0EjgKKih0u5nlqXZ7S6r+Psouwfyx4uLu1LVIBeCQbydgfcQl0MZNpXz326pzPkj5Qr44Cmj4aO RYWxyJsVbbauxT512hqnPcdcmiH8Q8dOT90GIvC8REFflPDqZgfaauOSC/X3RbZja1QFPmEKs+rTa g9qig2WjDTgyyEMLcs/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQtMa-00BRs7-Bx; Thu, 16 Sep 2021 15:31:48 +0000 Received: from mx22.baidu.com ([220.181.50.185] helo=baidu.com) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQtMU-00BRlw-JB for linux-arm-kernel@lists.infradead.org; Thu, 16 Sep 2021 15:31:45 +0000 Received: from BC-Mail-Ex07.internal.baidu.com (unknown [172.31.51.47]) by Forcepoint Email with ESMTPS id 22231219537071C93438; Thu, 16 Sep 2021 23:31:32 +0800 (CST) Received: from BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) by BC-Mail-EX07.internal.baidu.com (172.31.51.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2242.12; Thu, 16 Sep 2021 23:31:31 +0800 Received: from LAPTOP-UKSR4ENP.internal.baidu.com (172.31.63.8) by BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 16 Sep 2021 23:31:31 +0800 From: Cai Huoqing To: CC: Dmitry Torokhov , Ray Jui , Scott Branden , , , , Subject: [PATCH] Input: bcm_iproc_tsc - Make use of the helper function dev_err_probe() Date: Thu, 16 Sep 2021 23:31:25 +0800 Message-ID: <20210916153126.13886-1-caihuoqing@baidu.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [172.31.63.8] X-ClientProxiedBy: BC-Mail-Ex09.internal.baidu.com (172.31.51.49) To BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_083143_028035_1BD5F096 X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing Acked-by: Ray Jui --- drivers/input/touchscreen/bcm_iproc_tsc.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/input/touchscreen/bcm_iproc_tsc.c b/drivers/input/touchscreen/bcm_iproc_tsc.c index 7de1fd24ce36..c6aaeaee1d12 100644 --- a/drivers/input/touchscreen/bcm_iproc_tsc.c +++ b/drivers/input/touchscreen/bcm_iproc_tsc.c @@ -441,12 +441,9 @@ static int iproc_ts_probe(struct platform_device *pdev) } priv->tsc_clk = devm_clk_get(&pdev->dev, "tsc_clk"); - if (IS_ERR(priv->tsc_clk)) { - error = PTR_ERR(priv->tsc_clk); - dev_err(&pdev->dev, - "failed getting clock tsc_clk: %d\n", error); - return error; - } + if (IS_ERR(priv->tsc_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(priv->tsc_clk), + "failed getting clock tsc_clk\n"); priv->pdev = pdev; error = iproc_get_tsc_config(&pdev->dev, priv);