From patchwork Thu Sep 16 15:32:40 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Cai,Huoqing" X-Patchwork-Id: 12499409 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5FBC433F5 for ; Thu, 16 Sep 2021 15:34:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5E45D61056 for ; Thu, 16 Sep 2021 15:34:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5E45D61056 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baidu.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QED/NKqKA0Xd1KMMjDEKJ9DzIpoeAri/HtG6btJ8Fys=; b=YB4xkOdpp2IscM GIDTkxx9I9F3zAK68Xc2F+XK4IeE3xZDIdIFcR3YWAJFj2rZNula0FZFAWBXg3IHOQV70u3gc255Z 8bUyUqreHvYmbR0U/2YWDE+dcQ70+Oh5/uXHgQF2dFzIf4mCz3D2rUUlkstm4rK69CkTKBLX/FjXL MXYGtNCTA/Lz43ff1lVq+uVlwCqXWUytTQnEvYZLG1Kwgg12NfBsXQXS/9ftPzXp0HbKjE5nHTV5A EHE1RfMvS+OjIImNpMEh1Ox4pe4SwBETvZlsO7CmiBXQEesFKrMHMC9F4FBB3nJfRnFMLMRIHH/Z3 3KwysYWTKHgiqokAt4Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQtNe-00BSMp-Ap; Thu, 16 Sep 2021 15:32:54 +0000 Received: from mx22.baidu.com ([220.181.50.185] helo=baidu.com) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQtNZ-00BSKv-Bt for linux-arm-kernel@lists.infradead.org; Thu, 16 Sep 2021 15:32:50 +0000 Received: from BC-Mail-Ex26.internal.baidu.com (unknown [172.31.51.20]) by Forcepoint Email with ESMTPS id 0C95D66227D9E159F3C4; Thu, 16 Sep 2021 23:32:47 +0800 (CST) Received: from BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) by BC-Mail-Ex26.internal.baidu.com (172.31.51.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Thu, 16 Sep 2021 23:32:46 +0800 Received: from LAPTOP-UKSR4ENP.internal.baidu.com (172.31.63.8) by BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2308.14; Thu, 16 Sep 2021 23:32:46 +0800 From: Cai Huoqing To: CC: Dmitry Torokhov , Shawn Guo , Sascha Hauer , "Pengutronix Kernel Team" , Fabio Estevam , "NXP Linux Team" , , , Subject: [PATCH] Input: imx6ul_tsc - Make use of the helper function dev_err_probe() Date: Thu, 16 Sep 2021 23:32:40 +0800 Message-ID: <20210916153241.14416-1-caihuoqing@baidu.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [172.31.63.8] X-ClientProxiedBy: BC-Mail-Ex11.internal.baidu.com (172.31.51.51) To BJHW-MAIL-EX27.internal.baidu.com (10.127.64.42) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210916_083249_667604_186C5BBC X-CRM114-Status: GOOD ( 10.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org When possible use dev_err_probe help to properly deal with the PROBE_DEFER error, the benefit is that DEFER issue will be logged in the devices_deferred debugfs file. Using dev_err_probe() can reduce code size, and the error value gets printed. Signed-off-by: Cai Huoqing --- drivers/input/touchscreen/imx6ul_tsc.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/input/touchscreen/imx6ul_tsc.c b/drivers/input/touchscreen/imx6ul_tsc.c index 2d4facf70cdb..47b73b4008ab 100644 --- a/drivers/input/touchscreen/imx6ul_tsc.c +++ b/drivers/input/touchscreen/imx6ul_tsc.c @@ -405,12 +405,9 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) init_completion(&tsc->completion); tsc->xnur_gpio = devm_gpiod_get(&pdev->dev, "xnur", GPIOD_IN); - if (IS_ERR(tsc->xnur_gpio)) { - err = PTR_ERR(tsc->xnur_gpio); - dev_err(&pdev->dev, - "failed to request GPIO tsc_X- (xnur): %d\n", err); - return err; - } + if (IS_ERR(tsc->xnur_gpio)) + return dev_err_probe(&pdev->dev, PTR_ERR(tsc->xnur_gpio), + "failed to request GPIO tsc_X- (xnur)\n"); tsc->tsc_regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(tsc->tsc_regs)) { @@ -427,18 +424,14 @@ static int imx6ul_tsc_probe(struct platform_device *pdev) } tsc->tsc_clk = devm_clk_get(&pdev->dev, "tsc"); - if (IS_ERR(tsc->tsc_clk)) { - err = PTR_ERR(tsc->tsc_clk); - dev_err(&pdev->dev, "failed getting tsc clock: %d\n", err); - return err; - } + if (IS_ERR(tsc->tsc_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(tsc->tsc_clk), + "failed getting tsc clock\n"); tsc->adc_clk = devm_clk_get(&pdev->dev, "adc"); - if (IS_ERR(tsc->adc_clk)) { - err = PTR_ERR(tsc->adc_clk); - dev_err(&pdev->dev, "failed getting adc clock: %d\n", err); - return err; - } + if (IS_ERR(tsc->adc_clk)) + return dev_err_probe(&pdev->dev, PTR_ERR(tsc->adc_clk), + "failed getting adc clock\n"); tsc_irq = platform_get_irq(pdev, 0); if (tsc_irq < 0)