| Message ID | 20210916154635.1525-1-german.gomez@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] perf cs-etm: Print size using consistent format | expand |
On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: > From: Andrew Kilroy <andrew.kilroy@arm.com> > > Since the size is already printed earlier in hex, print the same data > using the same format, in hex. > > Reviewed-by: James Clark <james.clark@arm.com> > Signed-off-by: Andrew Kilroy <andrew.kilroy@arm.com> > Signed-off-by: German Gomez <german.gomez@arm.com> Reviewed-by: Leo Yan <leo.yan@linaro.org> > --- > tools/perf/util/cs-etm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index f323adb1af85..4f672f7d008c 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -537,7 +537,7 @@ static void cs_etm__dump_event(struct cs_etm_queue *etmq, > > fprintf(stdout, "\n"); > color_fprintf(stdout, color, > - ". ... CoreSight %s Trace data: size %zu bytes\n", > + ". ... CoreSight %s Trace data: size %#zx bytes\n", > cs_etm_decoder__get_name(etmq->decoder), buffer->size); > > do { > -- > 2.17.1 >
Hi German, On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: > From: Andrew Kilroy <andrew.kilroy@arm.com> > > Since the size is already printed earlier in hex, print the same data > using the same format, in hex. > > Reviewed-by: James Clark <james.clark@arm.com> > Signed-off-by: Andrew Kilroy <andrew.kilroy@arm.com> > Signed-off-by: German Gomez <german.gomez@arm.com> > --- > tools/perf/util/cs-etm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index f323adb1af85..4f672f7d008c 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -537,7 +537,7 @@ static void cs_etm__dump_event(struct cs_etm_queue *etmq, > > fprintf(stdout, "\n"); > color_fprintf(stdout, color, > - ". ... CoreSight %s Trace data: size %zu bytes\n", > + ". ... CoreSight %s Trace data: size %#zx bytes\n", Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> A couple of things to improve for your next interactions with the Linux community: 1) Using a cover letter, even for small changes, is always a good idea. 2) RB tags should be picked up publicly rather than done internally and added to a patchset. 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do with 01, 02 and 03. Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to this patchset. As such he will not see your work. Ask James about how to proceed when submitting patches to the perf tools. Thanks, Mathieu > cs_etm_decoder__get_name(etmq->decoder), buffer->size); > > do { > -- > 2.17.1 >
Hi Mathieu, Thanks for your feedback. I will keep these points in mind for future submissions. On 23/09/2021 17:24, Mathieu Poirier wrote: > Hi German, > > On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: >> [...] > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > A couple of things to improve for your next interactions with the Linux community: > > 1) Using a cover letter, even for small changes, is always a good idea. > 2) RB tags should be picked up publicly rather than done internally and added to > a patchset. > 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do > with 01, 02 and 03. Did you perhaps mean separating 01 and 02 from the rest? I grouped 03 to 05 because they were related to snapshot mode. Thanks, German > > Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to > this patchset. As such he will not see your work. Ask James about how to > proceed when submitting patches to the perf tools. > > Thanks, > Mathieu > >> cs_etm_decoder__get_name(etmq->decoder), buffer->size); >> >> do { >> -- >> 2.17.1 >>
On Thu, Sep 30, 2021 at 01:09:16PM +0100, German Gomez wrote: > Hi Mathieu, > > Thanks for your feedback. I will keep these points in mind for future > submissions. > > On 23/09/2021 17:24, Mathieu Poirier wrote: > > Hi German, > > > > On Thu, Sep 16, 2021 at 04:46:31PM +0100, German Gomez wrote: > > > [...] > > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org> > > > > A couple of things to improve for your next interactions with the Linux community: > > > > 1) Using a cover letter, even for small changes, is always a good idea. > > 2) RB tags should be picked up publicly rather than done internally and added to > > a patchset. > > 3) Keep patches semantically grouped. Here patches 04 and 05 have nothing to do > > with 01, 02 and 03. > Did you perhaps mean separating 01 and 02 from the rest? I grouped 03 to 05 > because > they were related to snapshot mode. Yes - you are correct. It should have been 01 and 02 in one set and the rest in another set. > > Thanks, > German > > > > > Moreover Arnaldo queues changes to the perf tools but I don't see him CC'ed to > > this patchset. As such he will not see your work. Ask James about how to > > proceed when submitting patches to the perf tools. > > > > Thanks, > > Mathieu > > > > > cs_etm_decoder__get_name(etmq->decoder), buffer->size); > > > do { > > > -- > > > 2.17.1 > > >
diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index f323adb1af85..4f672f7d008c 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -537,7 +537,7 @@ static void cs_etm__dump_event(struct cs_etm_queue *etmq, fprintf(stdout, "\n"); color_fprintf(stdout, color, - ". ... CoreSight %s Trace data: size %zu bytes\n", + ". ... CoreSight %s Trace data: size %#zx bytes\n", cs_etm_decoder__get_name(etmq->decoder), buffer->size); do {