From patchwork Fri Sep 17 12:06:30 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 12501765 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64B52C433F5 for ; Fri, 17 Sep 2021 12:09:50 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E45D60F9C for ; Fri, 17 Sep 2021 12:09:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2E45D60F9C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ls7/yHaMTrDF7xbB+wAO213H9HNNq2ieGeqAZW0ENeQ=; b=H9Vq+ooctgHcew ShIBdEhnoVWm7YAv0iiLLuwCRQIm47zMijJs9U0TbarTma6GrELvKHeD6NQ8v/Ooczpaecp7dDhCb aljSvAdJeCbCY9ticpE4M+Pd7lU+IO3fu6Jkzt20n1MnmQqR2u8V1rlcZB2PZtoYJgMLEJb10yY1c QcZqd6kivHw7P1yN2RlGxugjBGPE1BY36NymwqUIylP35HeIwTFk046IG4B+WRxeu99pfpHaJKJLB IzRggTtwJd3vCZzURBVLb3x9oe8Xgchv0VWBF4T0VS+cl7Kgf3OJmESxcNQeorZ43L0BNg0FJ6UA/ EB/2qXFAlZUU97d5koCQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRCf8-00DwPq-Ei; Fri, 17 Sep 2021 12:08:14 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mRCdv-00Dw0y-8T for linux-arm-kernel@lists.infradead.org; Fri, 17 Sep 2021 12:07:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1631880419; x=1663416419; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=b5FJhovyOTtqbY6WdesSmAErjuu4q8fe8jGDarYU7kM=; b=O2P9/AcoGH9UEjxNfQ1OKUZrt3fydoemWEBCI5VTGkgjupJL8icuwova /rpYmv8jcALcX2bgQt+bVRJxbdvkXO1ggIjnY3B7MS2qbHEwZ6JBJYhFU edp8IJ5WgihsT6tMQEzJmxGAGLYhUPIB2lenpKH/xwOeeHfsfZbKzEKg1 qu5R+L/XB8EjBbLJiEZn+ebeZAo/CeUuP7JT9ihdrqdFqxGdF0BWlfuzI A27ce/bNT7HsWhsF/J3gJ3FqErIBoLNbOf9NUhqmjVTnuIVFbP7jDfrVc 7SsWmtkxbKgrNuQtE6yN0cvLGtSp5uANJ8ub3sNaQ4YjMLqlnQtHNo2oO w==; IronPort-SDR: LML5BFFWqDlY1y+RNjKbLJ2lw6lSTp6wfSE051HE5MMtzKCcNO3GfKtXz3yZ2GQ5MLXFwUuC7d W5CJCRQj9P/g4/Wgnz1dSp+JOgdUmoDp/Gs7Wew2Tibelr7ZCHnPHQsF9XK5inmYb4B6ca75Qt neaJx3cxIL3AfN0heEq46oRGIS2j6ULW7YYekoiV6ObLZeZbesfqxETwqKe0O3bB+CKgAFhB+3 wsV0IFJ5MBSmCWMbDg4z2vYyG+MJDw04vrk6TW1mIQOBc9VhN8rt+teM3XSgPR8/lV91ueSH0N 7wSL7KxXiDwLb9CeK6i1WP4/ X-IronPort-AV: E=Sophos;i="5.85,301,1624345200"; d="scan'208";a="144535307" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Sep 2021 05:06:58 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 17 Sep 2021 05:06:58 -0700 Received: from rob-dk-mpu01.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 17 Sep 2021 05:06:56 -0700 From: Claudiu Beznea To: , , , , CC: , , , Claudiu Beznea Subject: [PATCH v3 05/17] clk: at91: clk-master: improve readability by using local variables Date: Fri, 17 Sep 2021 15:06:30 +0300 Message-ID: <20210917120642.8993-6-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20210917120642.8993-1-claudiu.beznea@microchip.com> References: <20210917120642.8993-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210917_050659_358536_0893ED16 X-CRM114-Status: UNSURE ( 9.48 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Improve readability in clk_sama7g5_master_set() by using local variables. Suggested-by: Nicolas Ferre Signed-off-by: Claudiu Beznea --- drivers/clk/at91/clk-master.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/at91/clk-master.c b/drivers/clk/at91/clk-master.c index 88f7af1bfff6..9a2c8e64cacf 100644 --- a/drivers/clk/at91/clk-master.c +++ b/drivers/clk/at91/clk-master.c @@ -680,6 +680,8 @@ static void clk_sama7g5_master_set(struct clk_master *master, unsigned long flags; unsigned int val, cparent; unsigned int enable = status ? AT91_PMC_MCR_V2_EN : 0; + unsigned int parent = master->parent << PMC_MCR_CSS_SHIFT; + unsigned int div = master->div << MASTER_DIV_SHIFT; spin_lock_irqsave(master->lock, flags); @@ -689,9 +691,7 @@ static void clk_sama7g5_master_set(struct clk_master *master, regmap_update_bits(master->regmap, AT91_PMC_MCR_V2, enable | AT91_PMC_MCR_V2_CSS | AT91_PMC_MCR_V2_DIV | AT91_PMC_MCR_V2_CMD | AT91_PMC_MCR_V2_ID_MSK, - enable | (master->parent << PMC_MCR_CSS_SHIFT) | - (master->div << MASTER_DIV_SHIFT) | - AT91_PMC_MCR_V2_CMD | + enable | parent | div | AT91_PMC_MCR_V2_CMD | AT91_PMC_MCR_V2_ID(master->id)); cparent = (val & AT91_PMC_MCR_V2_CSS) >> PMC_MCR_CSS_SHIFT;