From patchwork Mon Sep 20 10:02:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 12505047 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C851C433F5 for ; Mon, 20 Sep 2021 10:05:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4713160F5D for ; Mon, 20 Sep 2021 10:05:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4713160F5D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HHDGH/rq5IAfVX378AD/zYrFfC6DFEzKpthM1xkwHOg=; b=mmrbIMSLVoW0n6 IWX4EcmeAQOyyEeoPIIPsIl1SeP8Ew8QnFLzwnrTtPYsmGgaNxX9sgqiWR9hMuCdgzo3pkREcyIAE 2m/jBeokVM2NtTXlmYzAddbXVqYqEdlIlim1miB5HJDMzQYVrwtPeSR1YNfteP+H1W/PCs9vROpsw AQ6qQtPSGsi1D/s0dBGZcmqhShFOoY3XvXcmcupkZzNyeje9BBtJkbvCV61F+jj2zRQLqV+69f7Th JIGzZKcnWKO9bdo9qDv2LDu3taRNZwg3Nj/AoZg8j7eFh7MvHVo9EVrIOk5ufEsKz0Wfg8l9kHFwJ FAJM0PVrUrosEtHKVpgw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSG8v-001D7x-SQ; Mon, 20 Sep 2021 10:03:22 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSG8r-001D6y-Mb for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 10:03:18 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id ADE9F60F5D; Mon, 20 Sep 2021 10:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632132197; bh=qQ9AyDsrctcDXELzmj5Hituf3OumUk7WbMIpeW9r0f0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DyBNcChRM2ShZDW/jEzXgMQR6gbIa8IH4nMyP5KLyeo691ydp88+Wj9htoQJ5l5b9 lrP2J5Tj3x+wYimzQqL3Yf23Ij5u9lT0p3pqDWmCv0mQdLWMILRUC0jb7Rx40fpYMD dStyutE2QiORicJImP/7BbaGi1HCTK/zChMiYmmvkyjHZGaQ23OGMeFHJUyzepWxJX /H6zqRxA21nnJdUkjhwT1evocysNfariaPm5zZnUSzvo4KS2HDwjFpN2rDM+/JRMeR AyV5+XdbYGn8YHcS6r5ZCinW5Llfr12lARxZKRVmZPPJRhQgCQ9fe8qDTU7MSe0ZO1 RW9nIU6FdAq+g== From: Arnd Bergmann To: Sudeep Holla , Igor Skalkin , Peter Hilber , Cristian Marussi Cc: Arnd Bergmann , kernel test robot , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] firmware: arm_scmi: remove __exit annotation Date: Mon, 20 Sep 2021 12:02:52 +0200 Message-Id: <20210920100301.1466486-2-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210920100301.1466486-1-arnd@kernel.org> References: <20210920100301.1466486-1-arnd@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_030317_794931_6FDD308D X-CRM114-Status: GOOD ( 15.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Arnd Bergmann virtio_scmi_exit() is only called from __exit function, so the annotation is correct, but when the driver is built-in, the section gets discarded and the reference from a callback pointer causes a link-time error: `virtio_scmi_exit' referenced in section `.rodata' of drivers/firmware/arm_scmi/virtio.o: defined in discarded section `.exit.text' of drivers/firmware/arm_scmi/virtio.o I could not figure out a better workaround, so let's just remove that annotation even if it wastes a couple of bytes in .text. Fixes: 46abe13b5e3d ("firmware: arm_scmi: Add virtio transport") Signed-off-by: Arnd Bergmann --- drivers/firmware/arm_scmi/virtio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firmware/arm_scmi/virtio.c b/drivers/firmware/arm_scmi/virtio.c index 224577f86928..8941bb40f2df 100644 --- a/drivers/firmware/arm_scmi/virtio.c +++ b/drivers/firmware/arm_scmi/virtio.c @@ -476,7 +476,7 @@ static int __init virtio_scmi_init(void) return register_virtio_driver(&virtio_scmi_driver); } -static void __exit virtio_scmi_exit(void) +static void virtio_scmi_exit(void) { unregister_virtio_driver(&virtio_scmi_driver); }