From patchwork Wed Sep 22 11:24:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin King X-Patchwork-Id: 12510309 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B162C433EF for ; Wed, 22 Sep 2021 11:26:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F85E6112F for ; Wed, 22 Sep 2021 11:26:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1F85E6112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=GVwtXXtOUh0yTRhdBT5+V3yO5QojHGqZLKcM4aGeN5w=; b=ycdNmo3KZ4Zhgw f5f5fp5wdre6sGP9E+Ub0CsCzJ+/5osrm2FGXCCWQavKK9oUDi4duiMJ4S5cJ+M1n6ZGANnyR4cfa vcl8ixONHCKvw4L0GA9oiOOWss2tpGr0NTzUQhUNcbS/xxGTy8GOy2JOQapjtEsICReRLhiwp3bEC hh1qNOr3EJAapVRQRK3AQkNzT2O5i47dEPLTE8B20aKVSduf4oO0e4zFv11W2TxItBq7UUL8VVN7r bFZA8SE5g2k/cFukiDIA2TJRq7lLoSSPeyk3gKw0KvIVqjkdvj2VhlrBjVYRxyggxE415wwb02HPw pvlcE5n0Uq5F/GY1bSKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mT0MS-008IjA-VK; Wed, 22 Sep 2021 11:24:25 +0000 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mT0MP-008Ii5-Cn; Wed, 22 Sep 2021 11:24:22 +0000 Received: from localhost (1.general.cking.uk.vpn [10.172.193.212]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 8EC1C4015E; Wed, 22 Sep 2021 11:24:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1632309856; bh=jPiivGMCA0vYpmru2UiRTorDKmvF0y0XmHoBEgYPsvQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Content-Type; b=KJUyde2+TnzqFPXbbGunQw+OLCxj1A1Rkqd798wGAdaZD5z94siUroSYJbHTyEK81 DR+F9sQ9R5GjyjsjVX1sac8kpOt5oAjNkmH9STDWXE2mimYQQaHeGDUduvR2GOdNyP NXXh6hg9xQ9yrTtEiExlBed3M6d92XwUhRTfHOKUqSkZgeW8JDzfqLQYTwFRPToz3S K/Gk+bJJjvO+X7McFfGCVqMELivjQRUFZt3GpsnNVOL/V8Y4E9q3kH3AWdpc/ovHEF /YeepV7gfW7WoCKbzgbWp+F6f1FtoCvepWSAMqVq1UTM6Oz2CES0eXtFsTpdum7rtJ 5+TtwFAd7G8mA== From: Colin King To: Sandy Huang , =?utf-8?q?Heiko_St=C3=BCbner?= , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] drm/rockchip: Remove redundant assignment of pointer connector Date: Wed, 22 Sep 2021 12:24:16 +0100 Message-Id: <20210922112416.182134-1-colin.king@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210922_042421_683578_A66CE5DE X-CRM114-Status: GOOD ( 11.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Colin Ian King The pointer connector is being assigned a value that is never read, it is being updated immediately afterwards. The assignment is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/rockchip/rockchip_rgb.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_rgb.c b/drivers/gpu/drm/rockchip/rockchip_rgb.c index 09be9678f2bd..18fb84068a64 100644 --- a/drivers/gpu/drm/rockchip/rockchip_rgb.c +++ b/drivers/gpu/drm/rockchip/rockchip_rgb.c @@ -150,7 +150,6 @@ struct rockchip_rgb *rockchip_rgb_init(struct device *dev, if (ret) goto err_free_encoder; - connector = &rgb->connector; connector = drm_bridge_connector_init(rgb->drm_dev, encoder); if (IS_ERR(connector)) { DRM_DEV_ERROR(drm_dev->dev,