| Message ID | 20210928084949.27939-11-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | regulator/mfd/clock: dt-bindings: Samsung S2M and S5M to dtschema | expand |
On Tue, 28 Sep 2021, Krzysztof Kozlowski wrote: > Document the properties with regulator supplies for bucks and LDOs. At > least one board uses it (Exynos5250 Arndale). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > .../bindings/mfd/samsung,s5m8767.yaml | 38 +++++++++++++++++++ > 1 file changed, 38 insertions(+) These all need Rob's Ack. But can you start with reworking the subject line please. It should be: "dt-bindings: mfd: <component>: <Subject starting with an uppercase char>" > diff --git a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml > index 35018346f68b..e97a94cab4e8 100644 > --- a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml > +++ b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml > @@ -96,6 +96,44 @@ properties: > description: | > GPIO specifiers for three host gpio's used for dvs. > > + vinb1-supply: > + description: Power supply for buck1 > + vinb2-supply: > + description: Power supply for buck1 > + vinb3-supply: > + description: Power supply for buck1 > + vinb4-supply: > + description: Power supply for buck1 > + vinb5-supply: > + description: Power supply for buck1 > + vinb6-supply: > + description: Power supply for buck1 > + vinb7-supply: > + description: Power supply for buck1 > + vinb8-supply: > + description: Power supply for buck1 > + vinb9-supply: > + description: Power supply for buck1 > + > + vinl1-supply: > + description: Power supply for LDO3, LDO10, LDO26, LDO27 > + vinl2-supply: > + description: Power supply for LDO13, LDO16, LDO25, LDO28 > + vinl3-supply: > + description: Power supply for LDO11, LDO14 > + vinl4-supply: > + description: Power supply for LDO4, LDO9 > + vinl5-supply: > + description: Power supply for LDO12, LDO17, LDO19, LDO23 > + vinl6-supply: > + description: Power supply for LDO18, LDO20, LDO21, LDO24 > + vinl7-supply: > + description: Power supply for LDO5, LDO22 > + vinl8-supply: > + description: Power supply for LDO1, LDO6, LDO7, LDO8, LDO15 > + vinl9-supply: > + description: Power supply for LDO2 > + > wakeup-source: true > > required:
On 30/09/2021 14:47, Lee Jones wrote: > On Tue, 28 Sep 2021, Krzysztof Kozlowski wrote: > >> Document the properties with regulator supplies for bucks and LDOs. At >> least one board uses it (Exynos5250 Arndale). >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >> --- >> .../bindings/mfd/samsung,s5m8767.yaml | 38 +++++++++++++++++++ >> 1 file changed, 38 insertions(+) > > These all need Rob's Ack. Correct. > > But can you start with reworking the subject line please. > > It should be: > > "dt-bindings: mfd: <component>: <Subject starting with an uppercase char>" Sure, just have in mind that Mark wants them the other way around for regulator. :) Best regards, Krzysztof
On Thu, 30 Sep 2021, Krzysztof Kozlowski wrote: > On 30/09/2021 14:47, Lee Jones wrote: > > On Tue, 28 Sep 2021, Krzysztof Kozlowski wrote: > > > >> Document the properties with regulator supplies for bucks and LDOs. At > >> least one board uses it (Exynos5250 Arndale). > >> > >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > >> --- > >> .../bindings/mfd/samsung,s5m8767.yaml | 38 +++++++++++++++++++ > >> 1 file changed, 38 insertions(+) > > > > These all need Rob's Ack. > > Correct. > > > > > But can you start with reworking the subject line please. > > > > It should be: > > > > "dt-bindings: mfd: <component>: <Subject starting with an uppercase char>" > > Sure, just have in mind that Mark wants them the other way around for > regulator. :) a) I'm suggesting you use the standard formatting b) This is not a regulator patch :)
diff --git a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml index 35018346f68b..e97a94cab4e8 100644 --- a/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml +++ b/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml @@ -96,6 +96,44 @@ properties: description: | GPIO specifiers for three host gpio's used for dvs. + vinb1-supply: + description: Power supply for buck1 + vinb2-supply: + description: Power supply for buck1 + vinb3-supply: + description: Power supply for buck1 + vinb4-supply: + description: Power supply for buck1 + vinb5-supply: + description: Power supply for buck1 + vinb6-supply: + description: Power supply for buck1 + vinb7-supply: + description: Power supply for buck1 + vinb8-supply: + description: Power supply for buck1 + vinb9-supply: + description: Power supply for buck1 + + vinl1-supply: + description: Power supply for LDO3, LDO10, LDO26, LDO27 + vinl2-supply: + description: Power supply for LDO13, LDO16, LDO25, LDO28 + vinl3-supply: + description: Power supply for LDO11, LDO14 + vinl4-supply: + description: Power supply for LDO4, LDO9 + vinl5-supply: + description: Power supply for LDO12, LDO17, LDO19, LDO23 + vinl6-supply: + description: Power supply for LDO18, LDO20, LDO21, LDO24 + vinl7-supply: + description: Power supply for LDO5, LDO22 + vinl8-supply: + description: Power supply for LDO1, LDO6, LDO7, LDO8, LDO15 + vinl9-supply: + description: Power supply for LDO2 + wakeup-source: true required:
Document the properties with regulator supplies for bucks and LDOs. At least one board uses it (Exynos5250 Arndale). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- .../bindings/mfd/samsung,s5m8767.yaml | 38 +++++++++++++++++++ 1 file changed, 38 insertions(+)