From patchwork Thu Sep 30 10:09:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 12527881 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CDF4C433EF for ; Thu, 30 Sep 2021 10:12:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C81EF6142A for ; Thu, 30 Sep 2021 10:12:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C81EF6142A Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=QA3UufzUpsbShnh9JdeDY1YJxDgvvF5d6gEdqOMEMnA=; b=IDxlwGfhCUM/9p dmoufRDvTCbKvk1sxW+sV9brTshPVT26+VKFdXrq1rXaFN4vBxaweNJkO79V7R4Xz32Ekbt831Pmw 15ldByvjnyPcAch21vLnPZA37WMESMRn5SEohhcFcV7Fdypw4rVgWDsrLrymKtV9CPjRQ58GzSJZN 5pAKLaw5hk0DvWV4o/jNdeLqIt00h/jxSqcfSou/2OKGgBcJg5vGXNp8u/zhaAsUA4QGclvD6P53f uym+XV0s5eTxnKbiagPniFhBRpZgQo8D6JTgXbLEP4TRlwO62RREOEj1NJ/D1T8UNF6FsD3VIVdcj m3kGJB2oExdUswBgef8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVt0b-00DkNb-RE; Thu, 30 Sep 2021 10:09:47 +0000 Received: from esa.microchip.iphmx.com ([68.232.154.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVt0S-00DkKr-2N for linux-arm-kernel@lists.infradead.org; Thu, 30 Sep 2021 10:09:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1632996575; x=1664532575; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=T+FEBSdR2R1lgPhS9lJEjIF/H3DpmWpTBm+AgCb25Xo=; b=KWYaWrfwOJLb9ym2xW4jtkYW2xPc2w6sHeafuA1e1DsJ8CNLOtOlhLrU EgaoZxudEgNYe23htPqZwgNq5rbWxMPCkBQZ8d1mqEyCbV0fRCqX9pgno YnETmERE+BFwyrdugG9Bo/0XmeXaJJZ/mkvcQlCaCxOYQ7PhBbH3ZBJO1 PS6kSXeFvbPodQojgcBdXLS5JlKv+6brRIwZV5IiHT9UhUsx+YcJeQdFY msuDyl8waWmRzxy3R4w+jHp5tCeDnnkxSFiIbnBDjVm0QRYvinauKXszp aKDoQpPywuVeypR8dpT4kTfqowO+dCldmsIliNI72hzWVLQaGg6tDrVU/ w==; IronPort-SDR: q2GFmjCdmqmkf2Nrg+tjSy6vBCLo9jJaZDPJUfdq0eBAizg9SsYUMMthdf9IV7OojkCpuJpO1b Wn53rbK2PXM1lYbUTr1z6XnyM8JkpWLydAhTvZw/Aku51udfJ4otc2w/mfSLZZ3jEtoga2QdeT tLDqdUEPbS9wovN9a+BFfVYJdGO6wU4GxP/GWwJV5rly+ncfhcOgDH/Z1J782iDbr9LJOhlPdj DA8LGoTzu7Ho84iPpJIKPliqPkXDbAqgWGhMAFzxqsDiNxKhJMG2iNsPw5ttWAt4tedNZNgqwP FS2pr4C3xMJSJgDr7Ye2411e X-IronPort-AV: E=Sophos;i="5.85,335,1624345200"; d="scan'208";a="71214285" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 30 Sep 2021 03:09:32 -0700 Received: from chn-vm-ex01.mchp-main.com (10.10.85.143) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Thu, 30 Sep 2021 03:09:32 -0700 Received: from rob-dk-mpu01.microchip.com (10.10.115.15) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Thu, 30 Sep 2021 03:09:30 -0700 From: Claudiu Beznea To: , , , CC: , , , Claudiu Beznea , Cristian Birsan Subject: [PATCH] power: reset: at91-reset: check properly the return value of devm_of_iomap Date: Thu, 30 Sep 2021 13:09:28 +0300 Message-ID: <20210930100928.2211599-1-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_030936_269914_1720A99D X-CRM114-Status: GOOD ( 10.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org devm_of_iomap() returns error code or valid pointer. Check its return value with IS_ERR(). Fixes: bd3127733f2c ("power: reset: at91-reset: use devm_of_iomap") Reported-by: Cristian Birsan Signed-off-by: Claudiu Beznea --- drivers/power/reset/at91-reset.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/power/reset/at91-reset.c b/drivers/power/reset/at91-reset.c index 026649409135..64def79d557a 100644 --- a/drivers/power/reset/at91-reset.c +++ b/drivers/power/reset/at91-reset.c @@ -193,7 +193,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) return -ENOMEM; reset->rstc_base = devm_of_iomap(&pdev->dev, pdev->dev.of_node, 0, NULL); - if (!reset->rstc_base) { + if (IS_ERR(reset->rstc_base)) { dev_err(&pdev->dev, "Could not map reset controller address\n"); return -ENODEV; } @@ -203,7 +203,7 @@ static int __init at91_reset_probe(struct platform_device *pdev) for_each_matching_node_and_match(np, at91_ramc_of_match, &match) { reset->ramc_lpr = (u32)match->data; reset->ramc_base[idx] = devm_of_iomap(&pdev->dev, np, 0, NULL); - if (!reset->ramc_base[idx]) { + if (IS_ERR(reset->ramc_base[idx])) { dev_err(&pdev->dev, "Could not map ram controller address\n"); of_node_put(np); return -ENODEV;