| Message ID | 20211001000417.15334-5-leoyang.li@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Cleanup of LS1021a device trees | expand |
Hi Leo, > -----Original Message----- > From: Li Yang <leoyang.li@nxp.com> > Sent: Friday, October 1, 2021 5:34 AM > To: Shawn Guo <shawnguo@kernel.org>; Rob Herring > <robh+dt@kernel.org>; devicetree@vger.kernel.org; Oleksij Rempel > <linux@rempel-privat.de>; linux-arm-kernel@lists.infradead.org; linux- > kernel@vger.kernel.org > Cc: Leo Li <leoyang.li@nxp.com> > Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI > flash > > Caution: EXT Email > > Add the missing node for qspi flash. > > Signed-off-by: Li Yang <leoyang.li@nxp.com> > --- > arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts > b/arch/arm/boot/dts/ls1021a-qds.dts > index e2aa569ff404..522e1dc51059 100644 > --- a/arch/arm/boot/dts/ls1021a-qds.dts > +++ b/arch/arm/boot/dts/ls1021a-qds.dts > @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 { > }; > }; > > +&qspi { > + num-cs = <2>; Please drop "num-cs" property as it is not used by qspi driver. > + status = "okay"; > + > + qflash0: flash@0 { Can we have flash chip name instead of qflash? There is no hard requirement, it will help in aligning node properties with other board properties such as LX2160A-RDB, LS1046A-RDB etc. With above fixed, Reviewed-by: Kuldeep Singh <kuldeep.singh@nxp.com> > + compatible = "jedec,spi-nor"; > + #address-cells = <1>; > + #size-cells = <1>; > + spi-max-frequency = <20000000>; > + reg = <0>; > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + }; > +}; > + > &sai2 { > status = "okay"; > }; > -- > 2.25.1
On Fri, Oct 1, 2021 at 12:30 AM Kuldeep Singh <kuldeep.singh@nxp.com> wrote: > > Hi Leo, > > > -----Original Message----- > > From: Li Yang <leoyang.li@nxp.com> > > Sent: Friday, October 1, 2021 5:34 AM > > To: Shawn Guo <shawnguo@kernel.org>; Rob Herring > > <robh+dt@kernel.org>; devicetree@vger.kernel.org; Oleksij Rempel > > <linux@rempel-privat.de>; linux-arm-kernel@lists.infradead.org; linux- > > kernel@vger.kernel.org > > Cc: Leo Li <leoyang.li@nxp.com> > > Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for QSPI > > flash > > > > Caution: EXT Email > > > > Add the missing node for qspi flash. > > > > Signed-off-by: Li Yang <leoyang.li@nxp.com> > > --- > > arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts > > b/arch/arm/boot/dts/ls1021a-qds.dts > > index e2aa569ff404..522e1dc51059 100644 > > --- a/arch/arm/boot/dts/ls1021a-qds.dts > > +++ b/arch/arm/boot/dts/ls1021a-qds.dts > > @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 { > > }; > > }; > > > > +&qspi { > > + num-cs = <2>; > > Please drop "num-cs" property as it is not used by qspi driver. > > > + status = "okay"; > > + > > + qflash0: flash@0 { > > Can we have flash chip name instead of qflash? > There is no hard requirement, it will help in aligning node properties with other board properties such as LX2160A-RDB, LS1046A-RDB etc. Thanks for the review. I find that there is no reference to the label at all. I don't know why we added it in the first place. Probably we can just remove it? > > With above fixed, > Reviewed-by: Kuldeep Singh <kuldeep.singh@nxp.com> > > > + compatible = "jedec,spi-nor"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + spi-max-frequency = <20000000>; > > + reg = <0>; > > + spi-rx-bus-width = <4>; > > + spi-tx-bus-width = <4>; > > + }; > > +}; > > + > > &sai2 { > > status = "okay"; > > }; > > -- > > 2.25.1 >
> -----Original Message----- > From: Li Yang <leoyang.li@nxp.com> > Sent: Saturday, October 2, 2021 1:38 AM > To: Kuldeep Singh <kuldeep.singh@nxp.com> > Cc: Shawn Guo <shawnguo@kernel.org>; Rob Herring <robh+dt@kernel.org>; > devicetree@vger.kernel.org; Oleksij Rempel <linux@rempel-privat.de>; linux- > arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for > QSPI flash > > Caution: EXT Email > > On Fri, Oct 1, 2021 at 12:30 AM Kuldeep Singh <kuldeep.singh@nxp.com> > wrote: > > > > Hi Leo, > > > > > -----Original Message----- > > > From: Li Yang <leoyang.li@nxp.com> > > > Sent: Friday, October 1, 2021 5:34 AM > > > To: Shawn Guo <shawnguo@kernel.org>; Rob Herring > > > <robh+dt@kernel.org>; devicetree@vger.kernel.org; Oleksij Rempel > > > <linux@rempel-privat.de>; linux-arm-kernel@lists.infradead.org; > > > linux- kernel@vger.kernel.org > > > Cc: Leo Li <leoyang.li@nxp.com> > > > Subject: [EXT] [PATCH v2 04/16] ARM: dts: ls1021a-qds: Add node for > > > QSPI flash > > > > > > Caution: EXT Email > > > > > > Add the missing node for qspi flash. > > > > > > Signed-off-by: Li Yang <leoyang.li@nxp.com> > > > --- > > > arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/ls1021a-qds.dts > > > b/arch/arm/boot/dts/ls1021a-qds.dts > > > index e2aa569ff404..522e1dc51059 100644 > > > --- a/arch/arm/boot/dts/ls1021a-qds.dts > > > +++ b/arch/arm/boot/dts/ls1021a-qds.dts > > > @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 { > > > }; > > > }; > > > > > > +&qspi { > > > + num-cs = <2>; > > > > Please drop "num-cs" property as it is not used by qspi driver. > > > > > + status = "okay"; > > > + > > > + qflash0: flash@0 { > > > > Can we have flash chip name instead of qflash? > > There is no hard requirement, it will help in aligning node properties with > other board properties such as LX2160A-RDB, LS1046A-RDB etc. > > Thanks for the review. I find that there is no reference to the label at all. I > don't know why we added it in the first place. Probably we can just remove it? I believe yes, though I haven't checked it but I think it's safe to remove label and keep only flash@0. Regards Kuldeep
diff --git a/arch/arm/boot/dts/ls1021a-qds.dts b/arch/arm/boot/dts/ls1021a-qds.dts index e2aa569ff404..522e1dc51059 100644 --- a/arch/arm/boot/dts/ls1021a-qds.dts +++ b/arch/arm/boot/dts/ls1021a-qds.dts @@ -286,6 +286,21 @@ tbi0: tbi-phy@8 { }; }; +&qspi { + num-cs = <2>; + status = "okay"; + + qflash0: flash@0 { + compatible = "jedec,spi-nor"; + #address-cells = <1>; + #size-cells = <1>; + spi-max-frequency = <20000000>; + reg = <0>; + spi-rx-bus-width = <4>; + spi-tx-bus-width = <4>; + }; +}; + &sai2 { status = "okay"; };
Add the missing node for qspi flash. Signed-off-by: Li Yang <leoyang.li@nxp.com> --- arch/arm/boot/dts/ls1021a-qds.dts | 15 +++++++++++++++ 1 file changed, 15 insertions(+)