| Message ID | 20211003195758.36572-2-gascoar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: vchiq_core: various style cleanups | expand |
On Sun, Oct 03, 2021 at 04:57:51PM -0300, Gaston Gonzalez wrote: > Remove unnecessary blank lines. > > Reported by checkpatch.pl > > Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> > --- [ snip ] > @@ -3207,7 +3206,6 @@ enum vchiq_status vchiq_bulk_transfer(unsigned int handle, > } > > state = service->state; > - > queue = (dir == VCHIQ_BULK_TRANSMIT) ? > &service->bulk_tx : &service->bulk_rx; > I don't care one way or the other about the blank line, but it's not a checkpatch warning. regards, dan carpenter
On Mon, Oct 04, 2021 at 09:55:11AM +0300, Dan Carpenter wrote: > On Sun, Oct 03, 2021 at 04:57:51PM -0300, Gaston Gonzalez wrote: > > Remove unnecessary blank lines. > > > > Reported by checkpatch.pl > > > > Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> > > --- > > [ snip ] > > > @@ -3207,7 +3206,6 @@ enum vchiq_status vchiq_bulk_transfer(unsigned int handle, > > } > > > > state = service->state; > > - > > queue = (dir == VCHIQ_BULK_TRANSMIT) ? > > &service->bulk_tx : &service->bulk_rx; > > > > > I don't care one way or the other about the blank line, but it's > not a checkpatch warning. > Thanks for the review Dan. Of course you are right... This was not supposed to be here, I'm sorry. Please drop the series, I'll a send a v2. Thanks, Gaston > regards, > dan carpenter >
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index 083abfd8e212..45858607282c 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -257,7 +257,6 @@ find_service_by_handle(unsigned int handle) struct vchiq_service * find_service_by_port(struct vchiq_state *state, int localport) { - if ((unsigned int)localport <= VCHIQ_PORT_MAX) { struct vchiq_service *service; @@ -3207,7 +3206,6 @@ enum vchiq_status vchiq_bulk_transfer(unsigned int handle, } state = service->state; - queue = (dir == VCHIQ_BULK_TRANSMIT) ? &service->bulk_tx : &service->bulk_rx; diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h index 3ef4cbe1053c..de1e861c4ed3 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h @@ -14,7 +14,6 @@ #include "vchiq_cfg.h" - /* Do this so that we can test-build the code on non-rpi systems */ #if IS_ENABLED(CONFIG_RASPBERRYPI_FIRMWARE) @@ -260,7 +259,6 @@ struct vchiq_service_quota { }; struct vchiq_shared_state { - /* A non-zero value here indicates that the content is valid. */ int initialised; @@ -449,7 +447,6 @@ struct vchiq_config { short version_min; /* The minimum compatible version of VCHIQ */ }; - extern spinlock_t bulk_waiter_spinlock; extern int vchiq_core_log_level;
Remove unnecessary blank lines. Reported by checkpatch.pl Signed-off-by: Gaston Gonzalez <gascoar@gmail.com> --- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c | 2 -- drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 3 --- 2 files changed, 5 deletions(-)