From patchwork Mon Oct 11 11:27:11 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Claudiu Beznea X-Patchwork-Id: 12549781 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 445A8C433EF for ; Mon, 11 Oct 2021 11:36:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1199D60E94 for ; Mon, 11 Oct 2021 11:36:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1199D60E94 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=microchip.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IO8KZ4OnSCIMVo6SfuPtL/nBD2jOZ/VvlDp8i4iq+D8=; b=fnJtPEG5hxGxkG nW47VdKeYrXodUrKPYCaVPELrPlcYS9FrduZrD3VuDuT/qEOr63uH658y0+RKKa7doyTn1u3DAmYd SdtSCiok+A6mKNIPjnTUBIokvjiQ6fBB+XyORVtuZN9KYj/B8Py9tNuY4gll2ivoAcWZaEHhopDYK eNkkztqTp8a4T/Rjp8kEYFeRXnuHG7O6WFcn5GIDkTueiviILJbh9G1Cinn2HI8z+FXTGutWxaSSU wtqoORlYWnvepck15fpFhzua3KWnDAvmGT2DzlfPVXvMS/Z9j8oFqHTfI6rJp1j1olKAaKVcGW7fi vRvSfBspfJnYBjGWLdQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZtYc-00963g-8e; Mon, 11 Oct 2021 11:33:27 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mZtTA-0093rl-UW for linux-arm-kernel@lists.infradead.org; Mon, 11 Oct 2021 11:27:50 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1633951668; x=1665487668; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=bbgvOX8odhhcgQRbsWErZdBKALu82PPpkMqqT+eQSGM=; b=XokKAVtKgC71mVscS+qvoXrZQbSAvDej7A6XmPudxb5tKyvL2XoODdM+ z6THcPP5NIwR76p3niC05roUEX5exjD2G51HBCmptNKUKSytCi6QMpTrE FRsvSYTyuDOTSr6v8pL8+8aRVSJTvhuzMs4eR9gVqbtKlYFbJMv2OB5Yv 8fNwsg/ZE5cWjjp0hiDNzdOFSOVxbOcsnac0v+9yBwrLNAumm+GmzOy58 ckXCp23+zDWl+RY8RnxT+EkB6LT5vYJhKQ1hWz3dh6z716V1xEMtsd3dD NdrZYPaosf5L64uiZqosGkJAwD/Da846/7mgvNxVcNgagcw4K4PK2wD41 Q==; IronPort-SDR: Hssd7a5Dam4Ue21pMKZ3ijrw6rxWZeohXafN2V80kB6mQrpompQjg/6bXuOFXbcSKcYfyC7955 NqAVYd62YhUuvLW+lUGddTQwD5AjCdIBLZqKFGAePMZUddyRgDMd1gP+JdBgdijhxKS1Nj5GJe cIwgddNxcgsCL4hOCjEUiI9JHew/VGRfgqh0VPEs7CXPQJyNDbemyRjG6VZ5xHJ8f9/UrqNBGw FDYIxfz/QFQ4ZdMOUcqqk3VujQTSVI8lbiyjqiMdSwNXGkOH6intwjakWK18L0F884ZCAVGvlm mEDlEmUiWYcoif08Bmyc0xPm X-IronPort-AV: E=Sophos;i="5.85,364,1624345200"; d="scan'208";a="147591038" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 11 Oct 2021 04:27:47 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 11 Oct 2021 04:27:47 -0700 Received: from rob-dk-mpu01.microchip.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Mon, 11 Oct 2021 04:27:45 -0700 From: Claudiu Beznea To: , , , , CC: , , , Claudiu Beznea Subject: [PATCH v5 07/15] clk: at91: sam9x60-pll: use DIV_ROUND_CLOSEST_ULL Date: Mon, 11 Oct 2021 14:27:11 +0300 Message-ID: <20211011112719.3951784-8-claudiu.beznea@microchip.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20211011112719.3951784-1-claudiu.beznea@microchip.com> References: <20211011112719.3951784-1-claudiu.beznea@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211011_042749_062788_D8FC19BC X-CRM114-Status: UNSURE ( 8.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Use DIV_ROUND_CLOSEST_ULL() to avoid any inconsistency b/w the rate computed in sam9x60_frac_pll_recalc_rate() and the one computed in sam9x60_frac_pll_compute_mul_frac(). Fixes: 43b1bb4a9b3e1 ("clk: at91: clk-sam9x60-pll: re-factor to support plls with multiple outputs") Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre --- drivers/clk/at91/clk-sam9x60-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/at91/clk-sam9x60-pll.c b/drivers/clk/at91/clk-sam9x60-pll.c index 7020d3bf6e13..a73d7c96ce1d 100644 --- a/drivers/clk/at91/clk-sam9x60-pll.c +++ b/drivers/clk/at91/clk-sam9x60-pll.c @@ -73,8 +73,8 @@ static unsigned long sam9x60_frac_pll_recalc_rate(struct clk_hw *hw, struct sam9x60_pll_core *core = to_sam9x60_pll_core(hw); struct sam9x60_frac *frac = to_sam9x60_frac(core); - return (parent_rate * (frac->mul + 1) + - ((u64)parent_rate * frac->frac >> 22)); + return parent_rate * (frac->mul + 1) + + DIV_ROUND_CLOSEST_ULL((u64)parent_rate * frac->frac, (1 << 22)); } static int sam9x60_frac_pll_set(struct sam9x60_pll_core *core)