diff mbox series

mailbox: cmdq: Add of_node_put() before return

Message ID 20211018013314.4535-1-wanjiabing@vivo.com (mailing list archive)
State New, archived
Headers show
Series mailbox: cmdq: Add of_node_put() before return | expand

Commit Message

Jiabing Wan Oct. 18, 2021, 1:33 a.m. UTC 
Fix following coccicheck warning:
./drivers/mailbox/mtk-cmdq-mailbox.c:572:2-24: WARNING: Function
for_each_child_of_node should have of_node_put() before return

Early exits from for_each_child_of_node should decrement the
node reference counter.

Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/mailbox/mtk-cmdq-mailbox.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index 64175a893312..ab4f42cc987d 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -579,6 +579,7 @@  static int cmdq_probe(struct platform_device *pdev)
 				cmdq->clocks[alias_id].clk = of_clk_get(node, 0);
 				if (IS_ERR(cmdq->clocks[alias_id].clk)) {
 					dev_err(dev, "failed to get gce clk: %d\n", alias_id);
+					of_node_put(node);
 					return PTR_ERR(cmdq->clocks[alias_id].clk);
 				}
 			}