| Message ID | 20211022075247.518880-8-eugen.hristev@microchip.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: atmel: atmel-isc: implement media controller | expand |
Hi Eugen, On Fri, Oct 22, 2021 at 10:52:33AM +0300, Eugen Hristev wrote: > The ispck is not used for sama7g5 variant of the ISC. > Calls to ispck have to be removed also from module insert/removal. > > Fixes: d7f26849ed7c ("media: atmel: fix the ispck initialization") > Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org> Thanks j > --- > drivers/media/platform/atmel/atmel-sama7g5-isc.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/media/platform/atmel/atmel-sama7g5-isc.c b/drivers/media/platform/atmel/atmel-sama7g5-isc.c > index 9c05acafd072..6a5d3f7ce75e 100644 > --- a/drivers/media/platform/atmel/atmel-sama7g5-isc.c > +++ b/drivers/media/platform/atmel/atmel-sama7g5-isc.c > @@ -555,7 +555,6 @@ static int microchip_xisc_remove(struct platform_device *pdev) > > v4l2_device_unregister(&isc->v4l2_dev); > > - clk_disable_unprepare(isc->ispck); > clk_disable_unprepare(isc->hclock); > > isc_clk_cleanup(isc); > @@ -567,7 +566,6 @@ static int __maybe_unused xisc_runtime_suspend(struct device *dev) > { > struct isc_device *isc = dev_get_drvdata(dev); > > - clk_disable_unprepare(isc->ispck); > clk_disable_unprepare(isc->hclock); > > return 0; > @@ -582,10 +580,6 @@ static int __maybe_unused xisc_runtime_resume(struct device *dev) > if (ret) > return ret; > > - ret = clk_prepare_enable(isc->ispck); > - if (ret) > - clk_disable_unprepare(isc->hclock); > - > return ret; > } > > -- > 2.25.1 >
diff --git a/drivers/media/platform/atmel/atmel-sama7g5-isc.c b/drivers/media/platform/atmel/atmel-sama7g5-isc.c index 9c05acafd072..6a5d3f7ce75e 100644 --- a/drivers/media/platform/atmel/atmel-sama7g5-isc.c +++ b/drivers/media/platform/atmel/atmel-sama7g5-isc.c @@ -555,7 +555,6 @@ static int microchip_xisc_remove(struct platform_device *pdev) v4l2_device_unregister(&isc->v4l2_dev); - clk_disable_unprepare(isc->ispck); clk_disable_unprepare(isc->hclock); isc_clk_cleanup(isc); @@ -567,7 +566,6 @@ static int __maybe_unused xisc_runtime_suspend(struct device *dev) { struct isc_device *isc = dev_get_drvdata(dev); - clk_disable_unprepare(isc->ispck); clk_disable_unprepare(isc->hclock); return 0; @@ -582,10 +580,6 @@ static int __maybe_unused xisc_runtime_resume(struct device *dev) if (ret) return ret; - ret = clk_prepare_enable(isc->ispck); - if (ret) - clk_disable_unprepare(isc->hclock); - return ret; }
The ispck is not used for sama7g5 variant of the ISC. Calls to ispck have to be removed also from module insert/removal. Fixes: d7f26849ed7c ("media: atmel: fix the ispck initialization") Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com> --- drivers/media/platform/atmel/atmel-sama7g5-isc.c | 6 ------ 1 file changed, 6 deletions(-)