diff mbox series

[12/13] arm: socfpga: always select PL310_ERRATA_753970

Message ID 20211028141938.3530-13-lukas.bulwahn@gmail.com (mailing list archive)
State New, archived
Headers show
Series Kconfig symbol clean-up on ./arch/arm{64} | expand

Commit Message

Lukas Bulwahn Oct. 28, 2021, 2:19 p.m. UTC
Commit fbc125afdc50 ("ARM: socfpga: Turn on ARM errata for L2 cache") adds
some selects in ./arch/arm/mach-socfpga/Kconfig, with one select being
conditionally selected on the non-existing Kconfig symbol PL310.

Hence, ./scripts/checkkconfigsymbols.py warns:

PL310
Referencing files: arch/arm/mach-socfpga/Kconfig

Assuming that this errata should actually be selected for
ARCH_INTEL_SOCFPGA, simply select this config unconditionally.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
 arch/arm/mach-socfpga/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Arnd Bergmann Oct. 28, 2021, 2:58 p.m. UTC | #1
On Thu, Oct 28, 2021 at 4:19 PM Lukas Bulwahn <lukas.bulwahn@gmail.com> wrote:
>
> Commit fbc125afdc50 ("ARM: socfpga: Turn on ARM errata for L2 cache") adds
> some selects in ./arch/arm/mach-socfpga/Kconfig, with one select being
> conditionally selected on the non-existing Kconfig symbol PL310.
>
> Hence, ./scripts/checkkconfigsymbols.py warns:
>
> PL310
> Referencing files: arch/arm/mach-socfpga/Kconfig
>
> Assuming that this errata should actually be selected for
> ARCH_INTEL_SOCFPGA, simply select this config unconditionally.
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>

I think it has to be

       select PL310_ERRATA_753970 if CACHE_L2X0

otherwise you get a Kconfig warning when building a kernel without the
L2X0 driver.

         Arnd
diff mbox series

Patch

diff --git a/arch/arm/mach-socfpga/Kconfig b/arch/arm/mach-socfpga/Kconfig
index 43ddec677c0b..c21df17202a6 100644
--- a/arch/arm/mach-socfpga/Kconfig
+++ b/arch/arm/mach-socfpga/Kconfig
@@ -16,7 +16,7 @@  menuconfig ARCH_INTEL_SOCFPGA
 	select ARM_ERRATA_775420
 	select PL310_ERRATA_588369
 	select PL310_ERRATA_727915
-	select PL310_ERRATA_753970 if PL310
+	select PL310_ERRATA_753970
 	select PL310_ERRATA_769419
 
 if ARCH_INTEL_SOCFPGA