From patchwork Fri Nov 12 11:47:32 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Alex_Benn=C3=A9e?= X-Patchwork-Id: 12692381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE578C433EF for ; Fri, 12 Nov 2021 11:49:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 90E1460E53 for ; Fri, 12 Nov 2021 11:49:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 90E1460E53 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=R9mCyolGT7L/tCSSDjxgH+RPEypzNHQRCe5YJD4YxzQ=; b=ZJlxvgXymhnKib 9QjmJ2IUD5ohr3141N2qhpdLtQ0GbAQAUZy+474W9gquv/PBTbV5iqaIs5YuMVNekZqzLoUUNKMrJ fGei3Y7vVB7kwksl5gjtiOscWgbr/bb9CL9pllRV+kCbnYD0cmaOkqtb1SqrQDOt2t53wNLbW5UQt hNhuXgn1fs/6r7jlxip1qyNTrLp4zTMLyepH6Dz6a0TyaiHvLppOrXP9ye2XHuaBov/7Tf5gWKsWe M0wpfJzgGBp3uueGfpVwUTSp5yGeapMghaycLwhYHGddAW5Ywe7iFp7fdb3crq0eShGkcTjrXyHCQ dlyXwWHlyvDySJcd4O1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlV28-00AA0H-Us; Fri, 12 Nov 2021 11:47:53 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mlV1v-00A9ws-2V for linux-arm-kernel@lists.infradead.org; Fri, 12 Nov 2021 11:47:40 +0000 Received: by mail-wm1-x333.google.com with SMTP id f7-20020a1c1f07000000b0032ee11917ceso6579279wmf.0 for ; Fri, 12 Nov 2021 03:47:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wIGpUqKKsdBHIVu7qLREHVQ4Ti/omu4NC8RNTDPGi9k=; b=vj2y4YrzQqksYHFE33XVZ3whLo3Chi4yrXCxl7Zy/f2tOEeUlTog/fLlj88qlAPiY8 uMM539hoRcocmCg108gpHECMDvof/LYSZNr/jPZ2vukiExcLgxs2z1RvXdozoRfbxORA 44VpQ2vS+n3E9P9a1JwLQHXdTjQm1/wNh+83ccPR1sVoT+GlM5snCCbJknbIgnXpzSit hmlm3R70Q+mA/3w6YI37GLKjB5LAGu2+wHggWgMJI+FWtNZO5xb3tv/u8+sDTEtF2XP4 Ak6acw2EJOQZeRiYPU06WMNZGHISBo6kbECUA045yPrf7jkVw3fXpxFWmIdwp9X9a1p3 6taA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wIGpUqKKsdBHIVu7qLREHVQ4Ti/omu4NC8RNTDPGi9k=; b=DuibsPKtEzbZLA55ZWkvOYCzIVpTPl0CB4v6KI9AZHME+NJRp1fLqNB7vzjkSCTTrH o4I/kSXyvJ8pTLNRPRP7iro31pINtazUDqgHuT/Imk5yMcPztUKAnsg+XIAGKpkLURk9 6VqVB3kywC2H4sZmeecbKCw/K8sUJ59e+y/d2Ko/Xb5c0PffrvCRCXq0plfsXycfCg0j AcOA434JjC2F96vto08YLFUpPE1BsnEwld8MwfLDsUVU5iygci4b5Wl1g20/LfIeqPLF WvM2a1f/0x/yjfds0GuABjsHHYkIr3FRdOfxr5LPqWWfjNxf+1JuOVADI7o6Vg+btTM0 H51Q== X-Gm-Message-State: AOAM533asriEh0RaGmw1i4Uzh17u0MWRy9M4w9aZkLbe70x5eZShC4eS XMjUy198NE1gX8ltpcm+c23+2g== X-Google-Smtp-Source: ABdhPJyENsuVXPYwrdzvRDQJQgMZaKOk+plTsoN67GYhMD9w1WdUkbkFRgRwdFvp07nDvh+ZSFMfsw== X-Received: by 2002:a1c:2b04:: with SMTP id r4mr35189034wmr.48.1636717655778; Fri, 12 Nov 2021 03:47:35 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id j40sm6114775wms.16.2021.11.12.03.47.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Nov 2021 03:47:34 -0800 (PST) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 5F2261FF98; Fri, 12 Nov 2021 11:47:34 +0000 (GMT) From: =?utf-8?q?Alex_Benn=C3=A9e?= To: kvm@vger.kernel.org Cc: shashi.mallela@linaro.org, alexandru.elisei@arm.com, eric.auger@redhat.com, qemu-arm@nongnu.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, christoffer.dall@arm.com, maz@kernel.org, =?utf-8?q?Alex_Benn=C3=A9e?= Subject: [kvm-unit-tests PATCH v3 1/3] arm64: remove invalid check from its-trigger test Date: Fri, 12 Nov 2021 11:47:32 +0000 Message-Id: <20211112114734.3058678-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211112114734.3058678-1-alex.bennee@linaro.org> References: <20211112114734.3058678-1-alex.bennee@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211112_034739_203535_CDAACBCB X-CRM114-Status: GOOD ( 15.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org While an IRQ is not "guaranteed to be visible until an appropriate invalidation" it doesn't stop the actual implementation delivering it earlier if it wants to. This is the case for QEMU's TCG and as tests should only be checking architectural compliance this check is invalid. Signed-off-by: Alex Bennée Reviewed-by: Eric Auger Cc: Shashi Mallela Message-Id: <20210525172628.2088-2-alex.bennee@linaro.org> --- v3 - reflow the comment, drop "willingly do not call" as per Eric's suggestion --- arm/gic.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/arm/gic.c b/arm/gic.c index 98135ef..1e3ea80 100644 --- a/arm/gic.c +++ b/arm/gic.c @@ -732,21 +732,17 @@ static void test_its_trigger(void) "dev2/eventid=20 does not trigger any LPI"); /* - * re-enable the LPI but willingly do not call invall - * so the change in config is not taken into account. - * The LPI should not hit + * re-enable the LPI. While "A change to the LPI configuration + * is not guaranteed to be visible until an appropriate + * invalidation operation has completed" hardware that doesn't + * implement caches may have delivered the event at any point + * after the enabling. Check the LPI has hit by the time the + * invall is done. */ gicv3_lpi_set_config(8195, LPI_PROP_DEFAULT); stats_reset(); cpumask_clear(&mask); its_send_int(dev2, 20); - wait_for_interrupts(&mask); - report(check_acked(&mask, -1, -1), - "dev2/eventid=20 still does not trigger any LPI"); - - /* Now call the invall and check the LPI hits */ - stats_reset(); - cpumask_clear(&mask); cpumask_set_cpu(3, &mask); its_send_invall(col3); wait_for_interrupts(&mask);