From patchwork Wed Nov 17 01:38:53 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: CGEL X-Patchwork-Id: 12692805 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64CFCC433F5 for ; Wed, 17 Nov 2021 01:40:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25038610CA for ; Wed, 17 Nov 2021 01:40:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 25038610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=OGXshFvHg9yhudTvO01RN7j5CdOmjBOqD2Kap2iLEB0=; b=QK9nPUdVadSU5a s8iI2akWK3RZwpr7L+TgQUQ0elKWhWKgsCKc5FyTLRAjlOWqKNUGTX6f+e6GP7ZOfCgr3l49BbgcO YyByfv9NdTVuJmb2fdhKmXdmevLSkOXyrw+4rh9L91jpVqfKTqoLubCPvSEhRcbnSjmhrAUdWQo4A 7KPpmSYf8oQrC1J4gu0HwauPRmfKx3IJS5V6o3WQkGo1Lx7VSawFwZTvKu4qpIYnQL37+XBtzM8gx /s1tcEjpDizVQz9YWetM7CGlstglTQG0COPrWy+zn0WymLLjGi2fzuITMhwSmA3NEPieLFaaWpCvE AmfCUzq+76HfEDf6+NcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn9um-0034Jh-5a; Wed, 17 Nov 2021 01:39:08 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mn9ui-0034IH-MM for linux-arm-kernel@lists.infradead.org; Wed, 17 Nov 2021 01:39:05 +0000 Received: by mail-pg1-x52d.google.com with SMTP id s138so761292pgs.4 for ; Tue, 16 Nov 2021 17:39:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hH6qmXqvZSnOoRAcPtZVa0OkhWnUxqJaW0v8rMecUno=; b=VRb+wdNjdNbBwnY/Y9pQl1NMpTKE53gMeoES6xIMGhGx+1uyUzSnnisRSvAvzS0j8O BKqlkO+SMp9XpfgjBLY4IO8Y3HQ37c26qe5lLSewdEqkA/IFCxeAJfSXoaIOrXVr6J0f pDL/wr537Au+t/OqZdEfMIoqjvyz8JKsxJhn5SLs/u/y7+h9vS0OQ2m1i3/362rXYwEG nXZXj9FZ1i+4oMPD8yj/q5W+be/TudJtulBxiKYLicZG2W+cJncl/4px0SMzvQUtT5dO 80sY1nrekZUwH84rYJy2TdnR6nvzXAFqRNGie3RjGTH8EFCCjyNMfR0PgP4KEK9pogqu 3njw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hH6qmXqvZSnOoRAcPtZVa0OkhWnUxqJaW0v8rMecUno=; b=qz0PwJU0d4av7P1mlNDoUshdT7Tvh5PSYWOYoECq/pBHhc+1PELPOeDEgJZKGa7JTv 37Vb8wuRYALVzVoBCZ4eJlA0aWVxi0QFG3QetHmPWpxV6NmkA/1s+b0JFPS9xGp63nng 3QshpQrT3Iz12Cemmzm9ewllCPuMBHyLFG0ZM5Wv22vO66pewJCXGBuf3b/aMosrprYi x/PZa4RC2PWZbVOQ+dvCju9zqDmYM8Kt7yECIA2bAcL7dtDs0A4XcGlBze1ACp5zL4As pjwsUglflR9XZrbQjVQAkI21PcF+MB8t29Kpsdc5ZKKBq0dP69hhAghH5CFRl9mQCiVa Mqgg== X-Gm-Message-State: AOAM533DiXhp0/zPy5QyKXNmcOQ4ugZodTK7sSAbrdWBoc9jVBMg2IL7 H501r0vefuwv1LPpP0tvNycejaRd++c= X-Google-Smtp-Source: ABdhPJwjVHmxqjoD6z4EZGQfTMhn1JDO9TlmrTmVG8EayB5rEd9VN17xefIzJT8miEhx1duZtlP1/Q== X-Received: by 2002:aa7:9a4e:0:b0:4a2:71f9:21e0 with SMTP id x14-20020aa79a4e000000b004a271f921e0mr3617499pfj.77.1637113140023; Tue, 16 Nov 2021 17:39:00 -0800 (PST) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id s7sm3053123pfm.188.2021.11.16.17.38.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Nov 2021 17:38:59 -0800 (PST) From: cgel.zte@gmail.com X-Google-Original-From: deng.changcheng@zte.com.cn To: abel.vesa@nxp.com Cc: mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Changcheng Deng , Zeal Robot Subject: [PATCH] clk: imx: Use div64_ul instead of do_div Date: Wed, 17 Nov 2021 01:38:53 +0000 Message-Id: <20211117013853.158777-1-deng.changcheng@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211116_173904_754607_F0D16B4E X-CRM114-Status: GOOD ( 11.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Changcheng Deng do_div() does a 64-by-32 division. If the divisor is unsigned long, using div64_ul can avoid truncation to 32-bit. Reported-by: Zeal Robot Signed-off-by: Changcheng Deng --- drivers/clk/imx/clk-pllv3.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/imx/clk-pllv3.c b/drivers/clk/imx/clk-pllv3.c index 20ee9611ba6e..55497e0585a6 100644 --- a/drivers/clk/imx/clk-pllv3.c +++ b/drivers/clk/imx/clk-pllv3.c @@ -247,7 +247,7 @@ static long clk_pllv3_av_round_rate(struct clk_hw *hw, unsigned long rate, div = rate / parent_rate; temp64 = (u64) (rate - div * parent_rate); temp64 *= mfd; - do_div(temp64, parent_rate); + div64_ul(temp64, parent_rate); mfn = temp64; temp64 = (u64)parent_rate; @@ -277,7 +277,7 @@ static int clk_pllv3_av_set_rate(struct clk_hw *hw, unsigned long rate, div = rate / parent_rate; temp64 = (u64) (rate - div * parent_rate); temp64 *= mfd; - do_div(temp64, parent_rate); + div64_ul(temp64, parent_rate); mfn = temp64; val = readl_relaxed(pll->base); @@ -334,7 +334,7 @@ static struct clk_pllv3_vf610_mf clk_pllv3_vf610_rate_to_mf( /* rate = parent_rate * (mfi + mfn/mfd) */ temp64 = rate - parent_rate * mf.mfi; temp64 *= mf.mfd; - do_div(temp64, parent_rate); + div64_ul(temp64, parent_rate); mf.mfn = temp64; }