| Message ID | 20211117032740.2518926-3-peng.fan@oss.nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | add i.MX8ULP scmi power domain | expand |
On Wed, Nov 17, 2021 at 11:27:39AM +0800, Peng Fan (OSS) wrote: > From: Peng Fan <peng.fan@nxp.com> > > i.MX8ULP use scmi firmware based power domain and sensor support. > So add the firmware node and the sram it uses. > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 35 ++++++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > index fb8714379026..d567ef93f8d8 100644 > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > @@ -6,6 +6,7 @@ > #include <dt-bindings/clock/imx8ulp-clock.h> > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > +#include <dt-bindings/power/imx8ulp-power.h> > > #include "imx8ulp-pinfunc.h" > > @@ -102,6 +103,40 @@ sosc: clock-sosc { > #clock-cells = <0>; > }; > > + sram@2201f000 { > + compatible = "mmio-sram"; > + reg = <0x0 0x2201f000 0x0 0x1000>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0x2201f000 0x1000>; > + > + scmi_buf: scmi_buf@0 { Hyphen is more recommended than underscore for node name. Or just follow the naming in arm,scmi.yaml example? Shawn > + compatible = "arm,scmi-shmem"; > + reg = <0x0 0x400>; > + }; > + }; > + > + firmware { > + scmi { > + compatible = "arm,scmi-smc"; > + arm,smc-id = <0xc20000fe>; > + #address-cells = <1>; > + #size-cells = <0>; > + shmem = <&scmi_buf>; > + > + scmi_devpd: protocol@11 { > + reg = <0x11>; > + #power-domain-cells = <1>; > + }; > + > + scmi_sensor: protocol@15 { > + reg = <0x15>; > + #thermal-sensor-cells = <0>; > + }; > + }; > + }; > + > soc@0 { > compatible = "simple-bus"; > #address-cells = <1>; > -- > 2.25.1 >
Hi Shawn, > Subject: Re: [PATCH 2/3] arm64: dts: imx8ulp: add scmi firmware node > > On Wed, Nov 17, 2021 at 11:27:39AM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan <peng.fan@nxp.com> > > > > i.MX8ULP use scmi firmware based power domain and sensor support. > > So add the firmware node and the sram it uses. > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 35 > > ++++++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > index fb8714379026..d567ef93f8d8 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi > > @@ -6,6 +6,7 @@ > > #include <dt-bindings/clock/imx8ulp-clock.h> > > #include <dt-bindings/gpio/gpio.h> > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > +#include <dt-bindings/power/imx8ulp-power.h> > > > > #include "imx8ulp-pinfunc.h" > > > > @@ -102,6 +103,40 @@ sosc: clock-sosc { > > #clock-cells = <0>; > > }; > > > > + sram@2201f000 { > > + compatible = "mmio-sram"; > > + reg = <0x0 0x2201f000 0x0 0x1000>; > > + > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges = <0 0x0 0x2201f000 0x1000>; > > + > > + scmi_buf: scmi_buf@0 { > > Hyphen is more recommended than underscore for node name. Just send out v2 to address this issue. Or just > follow the naming in arm,scmi.yaml example? No need to follow its name there, it support many protocols and need different shmem for performance and others. Thanks, Peng. > > Shawn > > > + compatible = "arm,scmi-shmem"; > > + reg = <0x0 0x400>; > > + }; > > + }; > > + > > + firmware { > > + scmi { > > + compatible = "arm,scmi-smc"; > > + arm,smc-id = <0xc20000fe>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + shmem = <&scmi_buf>; > > + > > + scmi_devpd: protocol@11 { > > + reg = <0x11>; > > + #power-domain-cells = <1>; > > + }; > > + > > + scmi_sensor: protocol@15 { > > + reg = <0x15>; > > + #thermal-sensor-cells = <0>; > > + }; > > + }; > > + }; > > + > > soc@0 { > > compatible = "simple-bus"; > > #address-cells = <1>; > > -- > > 2.25.1 > >
diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi index fb8714379026..d567ef93f8d8 100644 --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi @@ -6,6 +6,7 @@ #include <dt-bindings/clock/imx8ulp-clock.h> #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/power/imx8ulp-power.h> #include "imx8ulp-pinfunc.h" @@ -102,6 +103,40 @@ sosc: clock-sosc { #clock-cells = <0>; }; + sram@2201f000 { + compatible = "mmio-sram"; + reg = <0x0 0x2201f000 0x0 0x1000>; + + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x0 0x2201f000 0x1000>; + + scmi_buf: scmi_buf@0 { + compatible = "arm,scmi-shmem"; + reg = <0x0 0x400>; + }; + }; + + firmware { + scmi { + compatible = "arm,scmi-smc"; + arm,smc-id = <0xc20000fe>; + #address-cells = <1>; + #size-cells = <0>; + shmem = <&scmi_buf>; + + scmi_devpd: protocol@11 { + reg = <0x11>; + #power-domain-cells = <1>; + }; + + scmi_sensor: protocol@15 { + reg = <0x15>; + #thermal-sensor-cells = <0>; + }; + }; + }; + soc@0 { compatible = "simple-bus"; #address-cells = <1>;