diff mbox series

[1/1] Revert "tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP"

Message ID 20211124073109.805088-1-alexander.stein@ew.tq-group.com (mailing list archive)
State New, archived
Headers show
Series [1/1] Revert "tty: serial: fsl_lpuart: drop earlycon entry for i.MX8QXP" | expand

Commit Message

Alexander Stein Nov. 24, 2021, 7:31 a.m. UTC 
Revert commit b4b844930f27 ("tty: serial: fsl_lpuart: drop earlycon entry
for i.MX8QXP"), because this breaks earlycon support on imx8qm/imx8qxp.
While it is true that for earlycon there is no difference between
i.MX8QXP and i.MX7ULP (for now at least), there are differences
regarding clocks and fixups for wakeup support. For that reason it was
deemed unacceptable to add the imx7ulp compatible to device tree in
order to get earlycon working again.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
Following the discussion from [1] and [2] lpuart should not be
considered compatible on i.MX/ULP and i.MX8XQP/i.MX8QM.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2021-November/698082.html
[2] http://lists.infradead.org/pipermail/linux-arm-kernel/2021-November/698318.html

 drivers/tty/serial/fsl_lpuart.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Peng Fan Nov. 25, 2021, 1:20 p.m. UTC | #1 
> Subject: [PATCH 1/1] Revert "tty: serial: fsl_lpuart: drop earlycon entry for
> i.MX8QXP"
> 
> Revert commit b4b844930f27 ("tty: serial: fsl_lpuart: drop earlycon entry for
> i.MX8QXP"), because this breaks earlycon support on imx8qm/imx8qxp.
> While it is true that for earlycon there is no difference between i.MX8QXP and
> i.MX7ULP (for now at least), there are differences regarding clocks and fixups
> for wakeup support. For that reason it was deemed unacceptable to add the
> imx7ulp compatible to device tree in order to get earlycon working again.
> 
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> ---
> Following the discussion from [1] and [2] lpuart should not be considered
> compatible on i.MX/ULP and i.MX8XQP/i.MX8QM.
> 
> [1]
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infr
> adead.org%2Fpipermail%2Flinux-arm-kernel%2F2021-November%2F698082.
> html&amp;data=04%7C01%7Cpeng.fan%40nxp.com%7Ce5fc0a232dd34b172
> 4fd08d9af1c68c1%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6
> 37733358817043520%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdat
> a=UVjwiXnV3as43VtiHY5Wppy4PiHqX%2FS3BIVqXedxYYE%3D&amp;reserved
> =0
> [2]
> https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infr
> adead.org%2Fpipermail%2Flinux-arm-kernel%2F2021-November%2F698318.
> html&amp;data=04%7C01%7Cpeng.fan%40nxp.com%7Ce5fc0a232dd34b172
> 4fd08d9af1c68c1%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6
> 37733358817043520%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwM
> DAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdat
> a=TERDm6qvf%2F47VwHaJvrnw2z6M%2F7dZ3%2BdesoU0PH8wNs%3D&am
> p;reserved=0
> 
>  drivers/tty/serial/fsl_lpuart.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> b1e7190ae483..ac5112def40d 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -2625,6 +2625,7 @@ OF_EARLYCON_DECLARE(lpuart, "fsl,vf610-lpuart",
> lpuart_early_console_setup);  OF_EARLYCON_DECLARE(lpuart32,
> "fsl,ls1021a-lpuart", lpuart32_early_console_setup);
> OF_EARLYCON_DECLARE(lpuart32, "fsl,ls1028a-lpuart",
> ls1028a_early_console_setup);  OF_EARLYCON_DECLARE(lpuart32,
> "fsl,imx7ulp-lpuart", lpuart32_imx_early_console_setup);
> +OF_EARLYCON_DECLARE(lpuart32, "fsl,imx8qxp-lpuart",
> +lpuart32_imx_early_console_setup);
>  EARLYCON_DECLARE(lpuart, lpuart_early_console_setup);
> EARLYCON_DECLARE(lpuart32, lpuart32_early_console_setup);
> 
> --
> 2.25.1
diff mbox series

Patch

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index b1e7190ae483..ac5112def40d 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -2625,6 +2625,7 @@  OF_EARLYCON_DECLARE(lpuart, "fsl,vf610-lpuart", lpuart_early_console_setup);
 OF_EARLYCON_DECLARE(lpuart32, "fsl,ls1021a-lpuart", lpuart32_early_console_setup);
 OF_EARLYCON_DECLARE(lpuart32, "fsl,ls1028a-lpuart", ls1028a_early_console_setup);
 OF_EARLYCON_DECLARE(lpuart32, "fsl,imx7ulp-lpuart", lpuart32_imx_early_console_setup);
+OF_EARLYCON_DECLARE(lpuart32, "fsl,imx8qxp-lpuart", lpuart32_imx_early_console_setup);
 EARLYCON_DECLARE(lpuart, lpuart_early_console_setup);
 EARLYCON_DECLARE(lpuart32, lpuart32_early_console_setup);