From patchwork Thu Nov 25 13:49:51 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Guangming.Cao" X-Patchwork-Id: 12693669 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AAAF9C433F5 for ; Thu, 25 Nov 2021 13:51:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aSy+4z7NkAxDveBs6Fg1f8lpyLru4wZz3F8Tmpu4Abo=; b=PhUp5PwtrCLQGv UlJfXfVdSs0lT9ScQx7vlEEPpkaIEKXbt9lqTH5hzCgml5USWDyVSokT5OIVYMGRB+8b6SNekZ+qT wOwNPbFUcuGIqCNC7QWHV3SkX6F4Tb3bNCxT2tBIb1155YKctyJv2odk4Fqhievd7WnD6xzqmLpTs N3Yv+81Gu8KcIjlj0rXHX0x5XN5c+rsQp0EP7ok6+rXyeWyzlMBN7XGIo7ZhG08OdN+tC936Dr6qR KdIJpl7vRF4hHpOUp0rpW5Rp4M7i5gyWO8acxi7Z8De+aOR691WdHRSPVa4Cs4lAASPbAgtWEr97P iTdf6WP4j0WHP4VImfJA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqF85-007iaH-PF; Thu, 25 Nov 2021 13:49:37 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqF82-007iZ1-G0; Thu, 25 Nov 2021 13:49:35 +0000 X-UUID: 383148f9af4e49c183548f9d5a6ba252-20211125 X-UUID: 383148f9af4e49c183548f9d5a6ba252-20211125 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1927555217; Thu, 25 Nov 2021 06:49:30 -0700 Received: from mtkmbs10n1.mediatek.inc (172.21.101.34) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 25 Nov 2021 05:49:28 -0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Thu, 25 Nov 2021 21:49:27 +0800 Received: from mszswglt01.gcn.mediatek.inc (10.16.20.20) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 25 Nov 2021 21:49:26 +0800 From: To: CC: , , , , , , , , , , , , , , , , Guangming Subject: [PATCH v2] dma_heap: use for_each_sgtable_sg in sg_table release flow Date: Thu, 25 Nov 2021 21:49:51 +0800 Message-ID: <20211125134951.62002-1-guangming.cao@mediatek.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <85eb9053-0ce4-2514-06dc-58b8910dc5f7@arm.com> References: <85eb9053-0ce4-2514-06dc-58b8910dc5f7@arm.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_054934_561959_C69CB564 X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Guangming Use (for_each_sgtable_sg) rather than (for_each_sg) to traverse sg_table to free sg_table. Use (for_each_sg) maybe will casuse some pages can't be freed when send wrong nents number. Signed-off-by: Guangming Reviewed-by: Robin Murphy --- drivers/dma-buf/heaps/system_heap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma-buf/heaps/system_heap.c b/drivers/dma-buf/heaps/system_heap.c index 23a7e74ef966..8660508f3684 100644 --- a/drivers/dma-buf/heaps/system_heap.c +++ b/drivers/dma-buf/heaps/system_heap.c @@ -289,7 +289,7 @@ static void system_heap_dma_buf_release(struct dma_buf *dmabuf) int i; table = &buffer->sg_table; - for_each_sg(table->sgl, sg, table->nents, i) { + for_each_sgtable_sg(table, sg, i) { struct page *page = sg_page(sg); __free_pages(page, compound_order(page));