From patchwork Wed Dec 1 12:57:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Lamparter X-Patchwork-Id: 12694321 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D9F7C433EF for ; Wed, 1 Dec 2021 12:58:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=esuMsH5LKMd0osC8MBepFmddAJZexrzxMA/IEKBA5IE=; b=IG+vLS7odvH6NK 9756YgDsh5wW1Dm0yVnPiJ+8d4NQzfwi3Q7csTzVRAxLqmJEN++WlXqN1LoQeDMsUa+EcdTxwrNOf ns3tEvCfrY3m8d7Rx2o9n9ANv1Hjxxw1zp8XL1uIqGtUQIbvetc1WBtUvKp2/trs2VkdeuQNDuen6 8x4wyP06rnW0A9qG7z916rEPA8rcnNQtLK9STcbNLgZUyrUjSY8zRivAP63uQ8BkgeTmHIqv4j24f FJGylXgIL4oKz2PkFHc2SXskHKpJNSI1+3+AN8Dlm3+tsPZEPoFlpg6fk95nxWOgLaRnh52rSU4/l eHmwuLqH7dHnvytFujgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msPAd-008aKV-Dc; Wed, 01 Dec 2021 12:57:11 +0000 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msPAZ-008aJ3-3g for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 12:57:08 +0000 Received: by mail-wr1-x431.google.com with SMTP id a9so52063479wrr.8 for ; Wed, 01 Dec 2021 04:57:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=72iRR/4HeBeHQCE5DFGR/jYYshMAqvGdf4VZ9pZlAio=; b=Nuh/0QfVdSMTgZX9RlkLMaPfmpqQB/tItEsChBU+1Xn39Gp2i+GCr9QANy1WUzUNcE f0Ckxl6RIwGYaJ3eUz42xgq6gwNr6JLGskdRrcNA6L66tCSneHLmWoNz/D3u+5q65xSn EBrvJZ9cAtQdaIRxiyaRkax+wKpM/5kkoqnrg7yKA8VsotNCEMFUE5z4HPKfRlFcbn3h dQrvPSrZ5p/fPMFCMzB67/20WeHoSIO/mjroLbCS+Hqwx+3M2MbqFtXbslbq/V7YfdeK boWVmCPbeeODRaZ/CMWnv4filT7wWTT6seR+y33v1cbAhTvU9HzEE3QJ1EPa8zG2uV2B mSRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=72iRR/4HeBeHQCE5DFGR/jYYshMAqvGdf4VZ9pZlAio=; b=1Y7UNiX4lZ9MvG4+5c9PTmhioHHI4rCl0kQJ4FElhs1uc5tno/Tp3tnPAqH7NTQoCQ TmKI3eXAXcvqS+DGGtYL5urL7Yplc01Ot3giDTFh5DLK93vFdr0mGiimdr76YnN9fDbO 9s8DXlAtQt8+l+fdYBYvzpv5S2w+mKCliNZj4MQSLZJwspyl/nZizEO+jIri7mwWbx0v oNGxEJ+ILAp31721CYkbqjwqjrKchVsf0FbPrmQ55xVmgHv/gm/0FksJdMFqBphjmvTb kIu88cjGoQyblencomgN2RpgLdkrd9XAMj3MESGVKpCpFh2KWbY+HHVuj5Bs5tlDPMwl iQ7Q== X-Gm-Message-State: AOAM530o/7w8b2QWYOBdua+kMvDf0DW7DsvbRMXHPDTLC4eyj2IpTGoz xlXbzQ5LRq79uyk7cKx/vtVjZOcTypA= X-Google-Smtp-Source: ABdhPJwvGEuHE3Yw0/PZ68FzcsLDLYJ3ys57awxjg+TYbyDN6X+zEsHFRsUZmALw7D4VybEu7xiu+Q== X-Received: by 2002:a5d:4084:: with SMTP id o4mr6793235wrp.47.1638363425135; Wed, 01 Dec 2021 04:57:05 -0800 (PST) Received: from debian64.daheim (p5b0d7321.dip0.t-ipconnect.de. [91.13.115.33]) by smtp.gmail.com with ESMTPSA id r17sm1187671wmq.5.2021.12.01.04.57.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Dec 2021 04:57:04 -0800 (PST) Received: from chuck by debian64.daheim with local (Exim 4.95) (envelope-from ) id 1msPAW-000Dlu-0I; Wed, 01 Dec 2021 13:57:04 +0100 From: Christian Lamparter To: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: Hans Ulli Kroll , Linus Walleij , Rob Herring , Steven Maddox Subject: [PATCH v1] ARM: dts: gemini: NAS4220-B: fis-index-block with 128 KiB sectors Date: Wed, 1 Dec 2021 13:57:03 +0100 Message-Id: <20211201125703.52935-1-chunkeey@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_045707_202972_8691F4A6 X-CRM114-Status: GOOD ( 16.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Steven Maddox reported in the OpenWrt bugzilla, that his RaidSonic IB-NAS4220-B was no longer booting with the new OpenWrt 21.02 (uses linux 5.10's device-tree). However, it was working with the previous OpenWrt 19.07 series (uses 4.14). |[ 5.548038] No RedBoot partition table detected in 30000000.flash |[ 5.618553] Searching for RedBoot partition table in 30000000.flash at offset 0x0 |[ 5.739093] No RedBoot partition table detected in 30000000.flash |... |[ 7.039504] Waiting for root device /dev/mtdblock3... The provided bootlog shows that the RedBoot partition parser was looking for the partition table "at offset 0x0". Which is strange since the comment in the device-tree says it should be at 0xfe0000. Further digging on the internet led to a review site that took some useful PCB pictures of their review unit back in February 2009. Their picture shows a Spansion S29GL128N11TFI01 flash chip. From Spansion's Datasheet: "S29GL128N: One hundred twenty-eight 64 Kword (128 Kbyte) sectors" Steven also provided a "cat /sys/class/mtd/mtd0/erasesize" from his unit: "131072". With the 128 KiB Sector/Erasesize in mind. This patch changes the fis-index-block property to (0xfe0000 / 0x20000) = 0x7f. Fixes: b5a923f8c739 ("ARM: dts: gemini: Switch to redboot partition parsing") Bugzilla: https://bugs.openwrt.org/index.php?do=details&task_id=4137 Reported-by: Steven Maddox Tested-by: Steven Maddox Signed-off-by: Christian Lamparter --- arch/arm/boot/dts/gemini-nas4220b.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/gemini-nas4220b.dts b/arch/arm/boot/dts/gemini-nas4220b.dts index 13112a8a5dd8..6544c730340f 100644 --- a/arch/arm/boot/dts/gemini-nas4220b.dts +++ b/arch/arm/boot/dts/gemini-nas4220b.dts @@ -84,7 +84,7 @@ flash@30000000 { partitions { compatible = "redboot-fis"; /* Eraseblock at 0xfe0000 */ - fis-index-block = <0x1fc>; + fis-index-block = <0x7f>; }; };