| Message ID | 20211206174133.2296265-1-robh@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: nvmem: Add missing 'reg' property | expand |
On Mon, Dec 06, 2021 at 11:41:33AM -0600, Rob Herring wrote: > With 'unevaluatedProperties' support implemented, the following warnings > are generated in the nvmem examples: > > Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected) > Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected) > Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected) > > Add the missing 'reg' property definition. > > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Rafał Miłecki <rafal@milecki.pl> > Cc: Saenz Julienne <nsaenzjulienne@suse.de> > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml | 3 +++ > Documentation/devicetree/bindings/nvmem/rmem.yaml | 3 +++ > Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++ > 3 files changed, 9 insertions(+) Reviewed-by: Thierry Reding <treding@nvidia.com>
On 12/6/21 6:41 PM, Rob Herring wrote: > With 'unevaluatedProperties' support implemented, the following warnings > are generated in the nvmem examples: > > Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected) > Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected) > Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected) > > Add the missing 'reg' property definition. > > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Rafał Miłecki <rafal@milecki.pl> > Cc: Saenz Julienne <nsaenzjulienne@suse.de> > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml | 3 +++ > Documentation/devicetree/bindings/nvmem/rmem.yaml | 3 +++ > Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++ > 3 files changed, 9 insertions(+) Hi Rob, For the stm32-romem, you can add my: Reviewed-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Thanks, Fabrice > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > index 58ff6b0bdb1a..8c3f0cd22821 100644 > --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > @@ -24,6 +24,9 @@ properties: > compatible: > const: brcm,nvram > > + reg: > + maxItems: 1 > + > unevaluatedProperties: false > > examples: > diff --git a/Documentation/devicetree/bindings/nvmem/rmem.yaml b/Documentation/devicetree/bindings/nvmem/rmem.yaml > index 1d85a0a30846..a4a755dcfc43 100644 > --- a/Documentation/devicetree/bindings/nvmem/rmem.yaml > +++ b/Documentation/devicetree/bindings/nvmem/rmem.yaml > @@ -19,6 +19,9 @@ properties: > - raspberrypi,bootloader-config > - const: nvmem-rmem > > + reg: > + maxItems: 1 > + > no-map: > $ref: /schemas/types.yaml#/definitions/flag > description: > diff --git a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml > index a48c8fa56bce..448a2678dc62 100644 > --- a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml > +++ b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml > @@ -24,6 +24,9 @@ properties: > - st,stm32f4-otp > - st,stm32mp15-bsec > > + reg: > + maxItems: 1 > + > patternProperties: > "^.*@[0-9a-f]+$": > type: object >
On 06/12/2021 17:41, Rob Herring wrote: > With 'unevaluatedProperties' support implemented, the following warnings > are generated in the nvmem examples: > > Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected) > Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected) > Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected) > > Add the missing 'reg' property definition. > > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> > Cc: Rafał Miłecki <rafal@milecki.pl> > Cc: Saenz Julienne <nsaenzjulienne@suse.de> > Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Rob Herring <robh@kernel.org> Applied thanks, --srini > --- > Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml | 3 +++ > Documentation/devicetree/bindings/nvmem/rmem.yaml | 3 +++ > Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > index 58ff6b0bdb1a..8c3f0cd22821 100644 > --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml > @@ -24,6 +24,9 @@ properties: > compatible: > const: brcm,nvram > > + reg: > + maxItems: 1 > + > unevaluatedProperties: false > > examples: > diff --git a/Documentation/devicetree/bindings/nvmem/rmem.yaml b/Documentation/devicetree/bindings/nvmem/rmem.yaml > index 1d85a0a30846..a4a755dcfc43 100644 > --- a/Documentation/devicetree/bindings/nvmem/rmem.yaml > +++ b/Documentation/devicetree/bindings/nvmem/rmem.yaml > @@ -19,6 +19,9 @@ properties: > - raspberrypi,bootloader-config > - const: nvmem-rmem > > + reg: > + maxItems: 1 > + > no-map: > $ref: /schemas/types.yaml#/definitions/flag > description: > diff --git a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml > index a48c8fa56bce..448a2678dc62 100644 > --- a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml > +++ b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml > @@ -24,6 +24,9 @@ properties: > - st,stm32f4-otp > - st,stm32mp15-bsec > > + reg: > + maxItems: 1 > + > patternProperties: > "^.*@[0-9a-f]+$": > type: object >
diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml index 58ff6b0bdb1a..8c3f0cd22821 100644 --- a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml @@ -24,6 +24,9 @@ properties: compatible: const: brcm,nvram + reg: + maxItems: 1 + unevaluatedProperties: false examples: diff --git a/Documentation/devicetree/bindings/nvmem/rmem.yaml b/Documentation/devicetree/bindings/nvmem/rmem.yaml index 1d85a0a30846..a4a755dcfc43 100644 --- a/Documentation/devicetree/bindings/nvmem/rmem.yaml +++ b/Documentation/devicetree/bindings/nvmem/rmem.yaml @@ -19,6 +19,9 @@ properties: - raspberrypi,bootloader-config - const: nvmem-rmem + reg: + maxItems: 1 + no-map: $ref: /schemas/types.yaml#/definitions/flag description: diff --git a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml index a48c8fa56bce..448a2678dc62 100644 --- a/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml +++ b/Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml @@ -24,6 +24,9 @@ properties: - st,stm32f4-otp - st,stm32mp15-bsec + reg: + maxItems: 1 + patternProperties: "^.*@[0-9a-f]+$": type: object
With 'unevaluatedProperties' support implemented, the following warnings are generated in the nvmem examples: Documentation/devicetree/bindings/nvmem/st,stm32-romem.example.dt.yaml: efuse@1fff7800: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/rmem.example.dt.yaml: nvram@10000000: Unevaluated properties are not allowed ('reg' was unexpected) Documentation/devicetree/bindings/nvmem/brcm,nvram.example.dt.yaml: nvram@1eff0000: Unevaluated properties are not allowed ('reg' was unexpected) Add the missing 'reg' property definition. Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Alexandre Torgue <alexandre.torgue@foss.st.com> Cc: Rafał Miłecki <rafal@milecki.pl> Cc: Saenz Julienne <nsaenzjulienne@suse.de> Cc: Fabrice Gasnier <fabrice.gasnier@foss.st.com> Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml | 3 +++ Documentation/devicetree/bindings/nvmem/rmem.yaml | 3 +++ Documentation/devicetree/bindings/nvmem/st,stm32-romem.yaml | 3 +++ 3 files changed, 9 insertions(+)