From patchwork Mon Dec 13 09:40:34 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Palmer X-Patchwork-Id: 12695858 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48419C43217 for ; Mon, 13 Dec 2021 09:49:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SRvU8Owh+UsCb8q55GvrJKmKC6tzWALQKLz/mHcqRMo=; b=K232aXwgSua9eg wbnQKzSG5DmO6CMopEMBjYMwBri+sMli1SbC1+lqq66zhZcF5rEMDNg+Jc5zs6uf5lzc8/36AIFry o2GJij+vityM1AcwS3sLX+CGCHUMrqv3XQ103QgnapGSMksm9fzHnEREZHGeGPUc7qoOOnKcAVfF4 p8dIJzjBQ7RHgKWUDR6zlPfTV2HUub/XgaGkOr4wEd8f043E7SGdK2A3lC8ZwWvT7HGpykcYrvVGg syobXUzLR26/akstptSs7X0FD+FkwKvLht9+Iv8e5q9nQS64nWTPx18TG5mn3LbYEi10SuaiJkvIO 4twEMNGo0W14Nd6FSmpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwhvP-008jn7-DC; Mon, 13 Dec 2021 09:47:17 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwhpJ-008hUV-Il for linux-arm-kernel@lists.infradead.org; Mon, 13 Dec 2021 09:40:59 +0000 Received: by mail-pg1-x532.google.com with SMTP id 200so5244957pgg.3 for ; Mon, 13 Dec 2021 01:40:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=0x0f.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+PLgOGUr24N3pCfDF0pm4vBw2jPEHVpOf1ojIAGQtAc=; b=TCXK6mvqNJC7RUZVwMT8njl9FfId+1tDmDUOhMpo9QmLfg9Idm63tAxC/8kUYCtSpa 6w0N7qb/e01yjEnKfRFzcAS4fvSEIn8npxTL++nHc2ThpwxVe4DDU2IdLkRZMi5yYWdX 7As7ZhM0Bd4P1WpM/rYtYMumJSeCAvzJnIsIY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+PLgOGUr24N3pCfDF0pm4vBw2jPEHVpOf1ojIAGQtAc=; b=rfs4rFr89qQxPQ6LdHt0bxB30LaO8KkEnT0HSVYWJhigp1caslk6gtJGoC44tY7iEO dafsRyEYFns2Vrt4eiss9rkgM/Gk8v9AzUpjZ0hbdbT3hb2JQbTZK5Z5QHjUPnoJGR+x 7xBWar84SwV01C9HQ45agP6YwCeOmauEFRSn9jbXps+lwCRc0FdGjss07qb2/NoK1XqI N6I5NVyU43jDETHJOmEI5lifnAWunPfK6lSEkNxKCubaItMRYOxLnjSulAZpLJGrKOK8 nhhwNQWqqs46PRONz2wF6jPWlWZOJ3yKfyW6HJ9OaIr3p/+G37glfjop0XWtCIHcvMY/ Px/w== X-Gm-Message-State: AOAM531AWrqLGJeHJN+ju0Y4AzsTlj7B/UjCr4pao+j+t736UhdRWcq8 iAekkvAMj63lnykCrulPD4DetA== X-Google-Smtp-Source: ABdhPJwnIC/1GG8HGXvC3beYsltFQ8bMno1f7ktTReaDdiWgvDzepwh8gUYFEaTxeqRdekJDmu2ciQ== X-Received: by 2002:a62:7803:0:b0:494:64ef:7bd7 with SMTP id t3-20020a627803000000b0049464ef7bd7mr32508766pfc.85.1639388456397; Mon, 13 Dec 2021 01:40:56 -0800 (PST) Received: from shiro.work (p864106-ipngn200510sizuokaden.shizuoka.ocn.ne.jp. [180.9.58.106]) by smtp.googlemail.com with ESMTPSA id d195sm10237609pga.41.2021.12.13.01.40.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Dec 2021 01:40:55 -0800 (PST) From: Daniel Palmer To: linus.walleij@linaro.org, brgl@bgdev.pl, linux-gpio@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Daniel Palmer Subject: [PATCH v3 3/5] gpio: msc313: Code clean ups Date: Mon, 13 Dec 2021 18:40:34 +0900 Message-Id: <20211213094036.1787950-4-daniel@0x0f.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20211213094036.1787950-1-daniel@0x0f.com> References: <20211213094036.1787950-1-daniel@0x0f.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211213_014057_661950_22DE58F7 X-CRM114-Status: GOOD ( 13.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org - Remove the unneeded assignment of ret before returning it. - Remove an unneeded blank line Signed-off-by: Daniel Palmer Reviewed-by: Linus Walleij --- drivers/gpio/gpio-msc313.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpio/gpio-msc313.c b/drivers/gpio/gpio-msc313.c index da31a5ff7a2b..a894bafbd4c3 100644 --- a/drivers/gpio/gpio-msc313.c +++ b/drivers/gpio/gpio-msc313.c @@ -344,7 +344,6 @@ static int msc313_gpio_probe(struct platform_device *pdev) struct irq_domain *parent_domain; struct device_node *parent_node; struct device *dev = &pdev->dev; - int ret; match_data = of_device_get_match_data(dev); if (!match_data) @@ -399,8 +398,7 @@ static int msc313_gpio_probe(struct platform_device *pdev) gpioirqchip->handler = handle_bad_irq; gpioirqchip->default_type = IRQ_TYPE_NONE; - ret = devm_gpiochip_add_data(dev, gpiochip, gpio); - return ret; + return devm_gpiochip_add_data(dev, gpiochip, gpio); } static int msc313_gpio_remove(struct platform_device *pdev) @@ -456,5 +454,4 @@ static struct platform_driver msc313_gpio_driver = { .probe = msc313_gpio_probe, .remove = msc313_gpio_remove, }; - builtin_platform_driver(msc313_gpio_driver);