From patchwork Tue Dec 14 20:42:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sergey Shtylyov X-Patchwork-Id: 12696118 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D260C433EF for ; Tue, 14 Dec 2021 20:44:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OS5o5HpOH7b4Rh4VWwAs0/110/WqwlLjSq4ULDABWA8=; b=c5HWd3UNVCHhdf hhxH2QXZ0sBVbyvVCQhsoA/Y5UnH/LpDkd7H/5+d8C5bUeHoiHbExsK0t4ND6JLbmoPIf1L28VB+J +3y2yjdAM8ej2AqZSaWN8+vHowqo+fxEQOgYww01/rg91cXboYtl4H5wtHfrQBd601/bSLAz9SgQ8 GILt6THM3++G9UmJJ2DcbhQiyPxxR8wk9bM5d5ATwHJKVdxkAMmCYlAaKCY7pSUvuxfFb7Hj0tOpP qaloE9sowzW+IURhgYTkJR3UbVN9P1g3NczegvUWdfktF8NWHF1b20t8YQaHG4NiN4KhDgVbZ9z34 uJCbvRh9Cf3WyDCzywKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxEdg-00FlDR-6p; Tue, 14 Dec 2021 20:43:08 +0000 Received: from mxout01.lancloud.ru ([45.84.86.81]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxEdb-00FlAq-B8 for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 20:43:06 +0000 Received: from LanCloud DKIM-Filter: OpenDKIM Filter v2.11.0 mxout01.lancloud.ru 668CA209A40D Received: from LanCloud Received: from LanCloud Received: from LanCloud From: Sergey Shtylyov To: , Greg Kroah-Hartman , Felipe Balbi CC: Daniel Mack , Haojian Zhuang , Robert Jarzmik , Subject: [PATCH 2/4] usb: gadget: udc: pxa25x: propagate errors from platform_get_irq() Date: Tue, 14 Dec 2021 23:42:45 +0300 Message-ID: <20211214204247.7172-3-s.shtylyov@omp.ru> X-Mailer: git-send-email 2.26.3 In-Reply-To: <20211214204247.7172-1-s.shtylyov@omp.ru> References: <20211214204247.7172-1-s.shtylyov@omp.ru> MIME-Version: 1.0 X-Originating-IP: [192.168.11.198] X-ClientProxiedBy: LFEXT02.lancloud.ru (fd00:f066::142) To LFEX1907.lancloud.ru (fd00:f066::207) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_124303_605401_D701505E X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The driver overrides the error codes returned by platform_get_irq() to -ENODEV for some strange reason. Switch to propagating the error codes upstream. Signed-off-by: Sergey Shtylyov Acked-by: Daniel Mack --- drivers/usb/gadget/udc/pxa25x_udc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/pxa25x_udc.c b/drivers/usb/gadget/udc/pxa25x_udc.c index 52cdfd8212d6..b38747fd3bb0 100644 --- a/drivers/usb/gadget/udc/pxa25x_udc.c +++ b/drivers/usb/gadget/udc/pxa25x_udc.c @@ -2364,7 +2364,7 @@ static int pxa25x_udc_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq < 0) - return -ENODEV; + return irq; dev->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(dev->regs))