diff mbox series

soc: apple: apple-pmgr-pwrstate: Do not build as a module

Message ID 20211215112935.238561-1-marcan@marcan.st (mailing list archive)
State New, archived
Headers show
Series soc: apple: apple-pmgr-pwrstate: Do not build as a module | expand

Commit Message

Hector Martin Dec. 15, 2021, 11:29 a.m. UTC
This doesn't make any sense as a module since it is a critical device,
and it turns out of_phandle_iterator_args was not exported so the module
version doesn't build anyway.

Signed-off-by: Hector Martin <marcan@marcan.st>
---
 drivers/soc/apple/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Sven Peter Dec. 15, 2021, 11:34 a.m. UTC | #1
On Wed, Dec 15, 2021, at 12:29, Hector Martin wrote:
> This doesn't make any sense as a module since it is a critical device,
> and it turns out of_phandle_iterator_args was not exported so the module
> version doesn't build anyway.
>
> Signed-off-by: Hector Martin <marcan@marcan.st>

I think it'd be nice to add Reported-by: kernel test robot <lkp@intel.com>
here since their service found it and maybe also a Fixes: tag.


Reviewed-by: Sven Peter <sven@svenpeter.dev>



Sven
diff mbox series

Patch

diff --git a/drivers/soc/apple/Kconfig b/drivers/soc/apple/Kconfig
index 3eb14abf8d33..9b8de31d6a8f 100644
--- a/drivers/soc/apple/Kconfig
+++ b/drivers/soc/apple/Kconfig
@@ -5,7 +5,7 @@  if ARCH_APPLE || COMPILE_TEST
 menu "Apple SoC drivers"
 
 config APPLE_PMGR_PWRSTATE
-	tristate "Apple SoC PMGR power state control"
+	bool "Apple SoC PMGR power state control"
 	depends on PM
 	select REGMAP
 	select MFD_SYSCON