| Message ID | 20211215181358.2950649-1-john@metanate.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/rockchip: vop: duplicate subclassed state variables | expand |
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index f3975905599b..0efd79be8f3b 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -1552,7 +1552,7 @@ static struct drm_crtc_state *vop_crtc_duplicate_state(struct drm_crtc *crtc) { struct rockchip_crtc_state *rockchip_state; - rockchip_state = kzalloc(sizeof(*rockchip_state), GFP_KERNEL); + rockchip_state = kmemdup(crtc->state, sizeof(*rockchip_state), GFP_KERNEL); if (!rockchip_state) return NULL;
Duplicating the CRTC state should copy all of the fields in the subclassed state as well as the base state. Switch to kmemdup to cover all of these (which are all simple variables). Most of the state variables are only used for .atomic_enable where they will have been set in the initial check, and enable_afbc is always set in the preceding .atomic_check, so the only issue here is inspecting the state later when these field end up no longer reflecting what has been programmed in the hardware. Signed-off-by: John Keeping <john@metanate.com> --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)