From patchwork Fri Dec 17 09:54:03 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jammy Huang X-Patchwork-Id: 12696597 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33692C433F5 for ; Fri, 17 Dec 2021 09:55:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fb12XZnlOt7S9UGnHbmYlCsGBk75hGz1ZGy/fnFXPio=; b=kNM5CFkWmUHjy9 6+Anq7nEjlJeWS2zYE648A132Ua4xQ30Aa+G9KCvbd4XRdr445aMCmE4z2KAyNWdBt+fdChpziUs6 IF1GB+2D/2ecA5I/lW7BvA+6nRGu3uLQylXmH6ZzeqTFcNqqNars6dUJ6Gkpq8wq2H3vGSZK3tB0o TS+F+DdcaETbt2FZ5H+1uToJWDOrJO6t5n7bGCTAmKZLj60V1f3IUpFx/2D2ifwTKUwuZ/8H70+j9 keeoevzuKTQleiEB0qyYF/ZwpLqSY91F2jmDrabBIfPAOaPuiOT/haWKhscnGUbRi71+YCz77Fzpn hNXUNtkQ4MBWjSbX8t1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1my9we-009Kaj-3q; Fri, 17 Dec 2021 09:54:32 +0000 Received: from twspam01.aspeedtech.com ([211.20.114.71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1my9wR-009KVp-KE for linux-arm-kernel@lists.infradead.org; Fri, 17 Dec 2021 09:54:21 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 1BH9SGrS026176; Fri, 17 Dec 2021 17:28:16 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from JammyHuang-PC.aspeed.com (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 17 Dec 2021 17:53:46 +0800 From: Jammy Huang To: , , , , , , , , Subject: [PATCH 4/4] media: aspeed: Fix timing polarity incorrect Date: Fri, 17 Dec 2021 17:54:03 +0800 Message-ID: <20211217095403.2618-5-jammy_huang@aspeedtech.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20211217095403.2618-1-jammy_huang@aspeedtech.com> References: <20211217095403.2618-1-jammy_huang@aspeedtech.com> MIME-Version: 1.0 X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 1BH9SGrS026176 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211217_015419_962610_533C5427 X-CRM114-Status: GOOD ( 10.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a workaround for polarity unstable. Sync value get by VR09C counts from sync's rising edge, which means sync's polarity is negative if sync value is bigger than total/2. Signed-off-by: Jammy Huang --- drivers/media/platform/aspeed-video.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c index 5ad3a20c5bac..f628f69bb7dd 100644 --- a/drivers/media/platform/aspeed-video.c +++ b/drivers/media/platform/aspeed-video.c @@ -989,6 +989,15 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) video->frame_top = FIELD_GET(VE_SRC_TB_EDGE_DET_TOP, src_tb_edge); det->vsync = FIELD_GET(VE_SYNC_STATUS_VSYNC, sync); + /* + * Workaround for polarity detection + * Use sync(VR098) counts from sync's rising edge till falling + * edge to tell sync polarity. + */ + if (det->vsync > (FIELD_GET(VE_MODE_DETECT_V_LINES, mds) >> 1)) + det->polarities &= ~V4L2_DV_VSYNC_POS_POL; + else + det->polarities |= V4L2_DV_VSYNC_POS_POL; if (det->polarities & V4L2_DV_VSYNC_POS_POL) { det->vbackporch = video->frame_top - det->vsync; det->vfrontporch = @@ -1010,6 +1019,15 @@ static void aspeed_video_get_resolution(struct aspeed_video *video) video->frame_left = FIELD_GET(VE_SRC_LR_EDGE_DET_LEFT, src_lr_edge); det->hsync = FIELD_GET(VE_SYNC_STATUS_HSYNC, sync); + /* + * Workaround for polarity detection + * Use sync(VR098) counts from sync's rising edge till falling + * edge to tell sync polarity. + */ + if (det->hsync > (htotal >> 1)) + det->polarities &= ~V4L2_DV_HSYNC_POS_POL; + else + det->polarities |= V4L2_DV_HSYNC_POS_POL; if (det->polarities & V4L2_DV_HSYNC_POS_POL) { det->hbackporch = video->frame_left - det->hsync; det->hfrontporch = htotal - video->frame_right;