diff mbox series

drivers: perf: marvell_cn10k: fix an IS_ERR() vs NULL check

Message ID 20211217145907.GA16611@kili (mailing list archive)
State New, archived
Headers show
Series drivers: perf: marvell_cn10k: fix an IS_ERR() vs NULL check | expand

Commit Message

Dan Carpenter Dec. 17, 2021, 2:59 p.m. UTC 
The devm_ioremap() function does not return error pointers.  It returns
NULL.

Fixes: 036a7584bede ("drivers: perf: Add LLC-TAD perf counter support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
When you're adding a new driver please use the correct prefix for the
first commit:

 Bad: subsystem: Add new driver for Fancy New Hardware
Good: subsystem/new_hdwr: Add new driver for Fancy New Hardware

Otherwise it's impossible to guess which prefix you prefer.

 drivers/perf/marvell_cn10k_tad_pmu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Will Deacon Jan. 5, 2022, 5:31 p.m. UTC | #1 
On Fri, 17 Dec 2021 17:59:08 +0300, Dan Carpenter wrote:
> The devm_ioremap() function does not return error pointers.  It returns
> NULL.
> 
> 

Applied to will (for-next/perf), thanks!

[1/1] drivers: perf: marvell_cn10k: fix an IS_ERR() vs NULL check
      https://git.kernel.org/will/c/2da56881a7f8

Cheers,
diff mbox series

Patch

diff --git a/drivers/perf/marvell_cn10k_tad_pmu.c b/drivers/perf/marvell_cn10k_tad_pmu.c
index 250dd4c52d70..7f4d292658e3 100644
--- a/drivers/perf/marvell_cn10k_tad_pmu.c
+++ b/drivers/perf/marvell_cn10k_tad_pmu.c
@@ -312,7 +312,7 @@  static int tad_pmu_probe(struct platform_device *pdev)
 		regions[i].base = devm_ioremap(&pdev->dev,
 					       res->start,
 					       tad_pmu_page_size);
-		if (IS_ERR(regions[i].base)) {
+		if (!regions[i].base) {
 			dev_err(&pdev->dev, "TAD%d ioremap fail\n", i);
 			return -ENOMEM;
 		}