diff mbox series

[boot-wrapper,v2,4/9] configure: Make PSCI the default boot method

Message ID 20211222181607.1203191-5-andre.przywara@arm.com (mailing list archive)
State New, archived
Headers show
Series Various (build system) fixes | expand

Commit Message

Andre Przywara Dec. 22, 2021, 6:16 p.m. UTC
When the boot-wrapper was originally conceived, PSCI was a rather new
feature, so support in contemporary kernels wasn't guaranteed. The
boot-wrapper consequently defaulted to not using PSCI.

Fortunately the times have changed, and most people expect PSCI these
days, so let's enable PSCI by default.

We keep the --enable-psci/--disable-psci configure switch, so it can be
still turned off if needed.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 configure.ac | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Mark Rutland Jan. 7, 2022, 2:12 p.m. UTC | #1
On Wed, Dec 22, 2021 at 06:16:02PM +0000, Andre Przywara wrote:
> When the boot-wrapper was originally conceived, PSCI was a rather new
> feature, so support in contemporary kernels wasn't guaranteed. The
> boot-wrapper consequently defaulted to not using PSCI.
> 
> Fortunately the times have changed, and most people expect PSCI these
> days, so let's enable PSCI by default.
> 
> We keep the --enable-psci/--disable-psci configure switch, so it can be
> still turned off if needed.
> 
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>

I had previosusly held off making this change because I wanted to do something
a bit more elaborate, but as this is generally a nice-to-have, and it's still
possible to change things later, I'll apply this now.

Mark.

> ---
>  configure.ac | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 6914eb4..852fd9a 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -82,8 +82,8 @@ AS_IF([test "x$X_IMAGE" != "x"],
>  
>  # Allow a user to pass --enable-psci
>  AC_ARG_ENABLE([psci],
> -	AS_HELP_STRING([--enable-psci], [enable the psci boot method]),
> -	[USE_PSCI=$enableval])
> +	AS_HELP_STRING([--disable-psci], [disable the psci boot method]),
> +	[USE_PSCI=$enableval], [USE_PSCI="yes"])
>  AM_CONDITIONAL([PSCI], [test "x$USE_PSCI" = "xyes"])
>  AS_IF([test "x$USE_PSCI" = "xyes"], [], [USE_PSCI=no])
>  
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index 6914eb4..852fd9a 100644
--- a/configure.ac
+++ b/configure.ac
@@ -82,8 +82,8 @@  AS_IF([test "x$X_IMAGE" != "x"],
 
 # Allow a user to pass --enable-psci
 AC_ARG_ENABLE([psci],
-	AS_HELP_STRING([--enable-psci], [enable the psci boot method]),
-	[USE_PSCI=$enableval])
+	AS_HELP_STRING([--disable-psci], [disable the psci boot method]),
+	[USE_PSCI=$enableval], [USE_PSCI="yes"])
 AM_CONDITIONAL([PSCI], [test "x$USE_PSCI" = "xyes"])
 AS_IF([test "x$USE_PSCI" = "xyes"], [], [USE_PSCI=no])