From patchwork Thu Dec 30 07:19:57 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Rogers X-Patchwork-Id: 12701275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98CA0C433F5 for ; Thu, 30 Dec 2021 07:30:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:References: Mime-Version:Message-Id:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=HI05I4h3qgqVjkEPwjzqbzBZuGjdPD7mDXOqYPgYjF8=; b=lGzJHbEBSBbEndKaf0ShyyCs9e KVXgX8Hmm6GJ/LDhzi/nVutsfqt6I9V7jQmyhCXitPbO4AbGqRYrwIiJJibzykx8jdOpyiIUJPAoi BgO3BbMOFkGYxmxIVikX7jmtIkWtr7w6RARnjzKvK+u/8ApHtWv3HN10FROAIrcAsG1zZ7Zncy8st ckfRsGkhYwgpg3nR7WSrtBF4smsOA5pQm0oPgHFBTk0F1+5n/y9fO0xNLgVY27GcT/4zwYQkhrD/B 2gvEXaHCkX+bil2ijLgEUSN4lFIf4POgP9L/8oZ0D3/YvPREYweraA7LAzDAuCmHKYUZ1VXX85hJ7 fxM0keBA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2ps9-003mtO-9t; Thu, 30 Dec 2021 07:29:13 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n2pkT-003jfI-Fl for linux-arm-kernel@lists.infradead.org; Thu, 30 Dec 2021 07:21:19 +0000 Received: by mail-yb1-xb49.google.com with SMTP id s83-20020a255e56000000b0060c46cc1890so21973385ybb.16 for ; Wed, 29 Dec 2021 23:21:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=s2CIczuM8teFDrPnQG9a+NBNIXG/EojqlmU2x3Abtwk=; b=No5depfbeojoeyTjZ7X0jeZ5N60dgn1waIhAAPmxijSgjjvbmxpqrbNrUkAB3+Mr69 D9/tyQ+u8+FsA37VLb8//fuHIgaidDofnkwF9plMWNjvW5eDyWJU4IYRgzqK5MzfHXbl DFD39l2AlagIiMWUgF6qC5WZ/PtkCs6uCh2iGeDvSlXlTIGUi+R18PzB1EGfafYHYoWl XD4d4tEj3reWUVc0ZK5+uwsh8k2vT9JMkHEFM23mPzxadL98HC1zIDPmSsNkUVq+Wxd3 cnG+lqKAwTYrG2r8++ivvKdhpB5zQ1WaR8lFH1YePvjKfQFl8FQPs9YKMa0Jv0rxKFPS OE8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=s2CIczuM8teFDrPnQG9a+NBNIXG/EojqlmU2x3Abtwk=; b=RnxCXdKirvRdmzQu1HMxTS7Rpbgiav0d1A6+85SEbOYpmN6RZlS2o5lYnXhLa2cIgB ZB4pK6yd6B5TOZL2IQfkBLaQ1y2LxM6QcqZwtkjeckANM/5+7WL8r0b3ZcGD7A2vP3CB KngTHdUaszjKIteyHquRtxH+dG/QOjXg03eh0beUSSVI2/e5g9jhu5cH1E3yo7v6gkMb anpg2Jf882WfIWruAnhLmYd4WrIHDoy3z/w5UJFmU6qoYNbHgZdWTEUWD77Uql+5HTrh Sl1zl+KXrFODGi9dTZtBel/PDybYZzuv7VxeCABcDFo9SNuJHu8fjc54tHhPKzNhbXN+ OCTQ== X-Gm-Message-State: AOAM532q+p+v6LuxV8PDyqQfFXecJAkF1zsN7G4QXsy6MX9SNGrA1ay3 d4oDtyrqAQDi67e5tZPowFGNSvY6iGZC X-Google-Smtp-Source: ABdhPJy7jq3i4MC7xvQckm3znGI61lzyO5NMel4adhTbckf7FGFpxr8wOmkVWD/Q6KjYeJJ1bXu47PO66c60 X-Received: from irogers.svl.corp.google.com ([2620:15c:2cd:202:31c4:9539:dba1:a82b]) (user=irogers job=sendgmr) by 2002:a25:770f:: with SMTP id s15mr20081478ybc.751.1640848875983; Wed, 29 Dec 2021 23:21:15 -0800 (PST) Date: Wed, 29 Dec 2021 23:19:57 -0800 In-Reply-To: <20211230072030.302559-1-irogers@google.com> Message-Id: <20211230072030.302559-17-irogers@google.com> Mime-Version: 1.0 References: <20211230072030.302559-1-irogers@google.com> X-Mailer: git-send-email 2.34.1.448.ga2b2bfdf31-goog Subject: [PATCH v3 15/48] perf cpumap: Document cpu__get_node and remove redundant function From: Ian Rogers To: Andi Kleen , Jiri Olsa , Namhyung Kim , John Garry , Kajol Jain , "Paul A . Clarke" , Arnaldo Carvalho de Melo , Riccardo Mancini , Kan Liang , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Vineet Singh , James Clark , Mathieu Poirier , Suzuki K Poulose , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, zhengjun.xing@intel.com Cc: eranian@google.com, Ian Rogers X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211229_232117_598153_ACAA213A X-CRM114-Status: GOOD ( 12.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org cpu_map__get_node_id isn't used externally and merely delegates to cpu__get_node. Reviewed-by: James Clark Signed-off-by: Ian Rogers --- tools/perf/util/cpumap.c | 11 +++++------ tools/perf/util/cpumap.h | 5 ++++- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c index b3e1304aca0c..1626b0991408 100644 --- a/tools/perf/util/cpumap.c +++ b/tools/perf/util/cpumap.c @@ -16,6 +16,10 @@ static int max_cpu_num; static int max_present_cpu_num; static int max_node_num; +/** + * The numa node X as read from /sys/devices/system/node/nodeX indexed by the + * CPU number. + */ static int *cpunode_map; static struct perf_cpu_map *cpu_map__from_entries(struct cpu_map_entries *cpus) @@ -222,11 +226,6 @@ int cpu_map__get_core_id(int cpu) return ret ?: value; } -int cpu_map__get_node_id(int cpu) -{ - return cpu__get_node(cpu); -} - struct aggr_cpu_id cpu_map__get_core_aggr_by_cpu(int cpu, void *data) { struct aggr_cpu_id id; @@ -250,7 +249,7 @@ struct aggr_cpu_id cpu_map__get_node_aggr_by_cpu(int cpu, void *data __maybe_unu { struct aggr_cpu_id id = aggr_cpu_id__empty(); - id.node = cpu_map__get_node_id(cpu); + id.node = cpu__get_node(cpu); return id; } diff --git a/tools/perf/util/cpumap.h b/tools/perf/util/cpumap.h index 9589b0001a28..f849f01c5860 100644 --- a/tools/perf/util/cpumap.h +++ b/tools/perf/util/cpumap.h @@ -45,7 +45,6 @@ int cpu_map__get_die_id(int cpu); struct aggr_cpu_id cpu_map__get_die_aggr_by_cpu(int cpu, void *data); int cpu_map__get_core_id(int cpu); struct aggr_cpu_id cpu_map__get_core_aggr_by_cpu(int cpu, void *data); -int cpu_map__get_node_id(int cpu); struct aggr_cpu_id cpu_map__get_node_aggr_by_cpu(int cpu, void *data); int cpu_map__build_socket_map(struct perf_cpu_map *cpus, struct cpu_aggr_map **sockp); int cpu_map__build_die_map(struct perf_cpu_map *cpus, struct cpu_aggr_map **diep); @@ -58,6 +57,10 @@ int cpu__setup_cpunode_map(void); int cpu__max_node(void); int cpu__max_cpu(void); int cpu__max_present_cpu(void); +/** + * cpu__get_node - Returns the numa node X as read from + * /sys/devices/system/node/nodeX for the given CPU. + */ int cpu__get_node(int cpu); int cpu_map__build_map(struct perf_cpu_map *cpus, struct cpu_aggr_map **res,