From patchwork Wed Jan 5 11:10:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12704220 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC2B8C433F5 for ; Wed, 5 Jan 2022 11:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=nugXbvAflPS5Pw0nVnY9vRZVOdEkknA3ZTHrXnfNR9o=; b=hsa KbxWoAP1fOx9DTBKZsCJ+Im0P42tbFBinU6NzCfBHcWz7MKXokr66ouxOaCDU+U6Tq7Q8xnORS9lb ewgflsFURnaqH0eQXLE+cB1eLN2jhSM2QfD6hURt/AQrwB4ZFskV5nlLLWDJVlHfc/0TUiDLn3xIp iJMowDqb7Eglju7KvfKk8s0VtuKcNOH3Ly1w/LEFZLcMgHJscu9IY51s5Ho3ziTv3Q2WkgSNdtktA sX2Nj9hhGCwziTwV6FB5OlAjxLGBPgw7SAssc4sMw95vhZiKUxt+LmTWcK96NFUApmPvfmRjnq9RQ /LUteVomgKtlGGvfYBfnX0xWVKJ5Zow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n54CD-00Ecob-FO; Wed, 05 Jan 2022 11:11:09 +0000 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n54C9-00Ecnl-Hj for linux-arm-kernel@lists.infradead.org; Wed, 05 Jan 2022 11:11:06 +0000 Received: by mail-pl1-x635.google.com with SMTP id w7so28548594plp.13 for ; Wed, 05 Jan 2022 03:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=cj+3WFPJnAOOnxE9gT1YnUYxUZOyVzd9YncNCKeilCU=; b=Z5UWgzuNH1dCoyvrV4977X1iPqZaStrCEQTeUl3WbtuV9qk4jS49h72PYgskI2nX8E Jj3rz2uyAiKgyc+DJiDPSUnDfGPmcEHMoOoZbcaB9KRwsNZ2p1ATAOMkkmW8UJflp+56 RlLB2kfhC5bn7WkofAC3eJGQI9xEN/llI1ajtuKy6tuaM9t8ExXjfl20JNK+PKY+jgKZ k1cucehwH+6m9CbeAVzsBrbPvA5S/OGgKHnUAC4FNkeDswgIhQqg4R5nZSQo2365VfYz 9nM+4fuKgD5vVqHbB0aZdnl/DPTeqRhsP7yaFqcp80M2V2E8uQ/NxRJQG6Clif1o+WK8 XbCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cj+3WFPJnAOOnxE9gT1YnUYxUZOyVzd9YncNCKeilCU=; b=YgEZsarkQKRpZ9IFFJPXJdAH1Slf0cuVzQA9T6u0KoyoQVFpIyWm2HjjbpAkcR/cp2 WF9cGKOrXE5vZ060fXjEheZHALvQb807Xq5dysgvMFCFMbnjeLp5czxiY5w9nKIVXR0v AI/33DI99b8zYfMcaxnGuq5uUOaIyWH/VFmwRB9WIZOOY2HsGRzqiQp+uKKGr+QNGzUW BD2VLZbNH/KrpobQJbVGP5dh98AwTl++FRIR8fE9+MDzGk9nWgfTzlNzHbk8pWzZOxl6 gi6SITRU1BdiCdoE4T3NH2TH932wkVh2o1J+PU5Tr45xAWwTU/5lLaCmWMWVcNPSGMjb kbLA== X-Gm-Message-State: AOAM531SfwHnzt9cLw5Kbw/x+rsWIMM69nJcCCg1mXUjut+8/I0vrTYz 44lCZ0t5z3UU4lP7wTCfVq4= X-Google-Smtp-Source: ABdhPJxofkPppi25LMe8AAwDgRDJyINVLZDgzMqLZ+7DQfA8juXDY9/3OxdzF6Npl94UtTXgyuu6nA== X-Received: by 2002:a17:902:b787:b0:148:fa6a:c748 with SMTP id e7-20020a170902b78700b00148fa6ac748mr53350313pls.167.1641381064566; Wed, 05 Jan 2022 03:11:04 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id k23sm1856651pji.3.2022.01.05.03.11.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jan 2022 03:11:04 -0800 (PST) From: Miaoqian Lin To: Subject: [PATCH] media: atmel: atmel-isc: Fix PM disable depth imbalance in atmel_isc_probe Date: Wed, 5 Jan 2022 11:10:54 +0000 Message-Id: <20220105111056.4662-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220105_031105_625169_2694755A X-CRM114-Status: GOOD ( 11.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linmq006@gmail.com, Alexandre Belloni , linux-kernel@vger.kernel.org, Ludovic Desroches , Hans Verkuil , Eugen Hristev , Mauro Carvalho Chehab , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The pm_runtime_enable will increase power disable depth. If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable(). Fixes: 0a0e265 ("media: atmel: atmel-isc: split driver into driver base and isc") Signed-off-by: Miaoqian Lin Reported-by: kernel test robot --- drivers/media/platform/atmel/atmel-sama5d2-isc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/atmel/atmel-sama5d2-isc.c b/drivers/media/platform/atmel/atmel-sama5d2-isc.c index 1b2063cce0f7..88a81c3ada90 100644 --- a/drivers/media/platform/atmel/atmel-sama5d2-isc.c +++ b/drivers/media/platform/atmel/atmel-sama5d2-isc.c @@ -559,6 +559,9 @@ static int atmel_isc_probe(struct platform_device *pdev) cleanup_subdev: isc_subdev_cleanup(isc); +disable_pm_runtime: + pm_runtime_disable(dev); + unregister_v4l2_device: v4l2_device_unregister(&isc->v4l2_dev);