From patchwork Fri Jan 7 08:36:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12706364 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07EF7C433F5 for ; Fri, 7 Jan 2022 08:37:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=MXlMlN0dbvlEl/+ICVCCoR07uB1wJUuGIPWOm6qGJsk=; b=3GOOiD4ENHPpPS G9oRLTh7fKzW0aSdl1p0LavsPdlKpIm73OFv3VlT253Da2CQumegf8+UGoqFttbcv6y9bNRWzbKDt b9KRXBP020nqJuOcG9fl7OdH61YI/0e0pWoMOLUFGDctirhwVaAVovczKLUyGGnYUvFOBKB+/4do/ OBZjCFtDMhUbsZoA7wFPwmxk/+yjFoFT4pXBjTgx09zK3kUtzvx4HvtItJf9NPeTMWUn9kXlVXY3P IB3RYLObuMZaZMw71U2ntYR8MhLciZ6V5sq3LClhxvEBTOEX5BAT408KtbDPYNShYNvg5mfciOYgG t8+Hu1iqCIkYz6wQ2LHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5kjr-002uTO-3A; Fri, 07 Jan 2022 08:36:43 +0000 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n5kjn-002uSM-65 for linux-arm-kernel@lists.infradead.org; Fri, 07 Jan 2022 08:36:40 +0000 Received: by mail-pj1-x1035.google.com with SMTP id iy13so4634222pjb.5 for ; Fri, 07 Jan 2022 00:36:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=0usgNPuxO2Xbite7dIWl/eUqLBFFjy4eURRS5eQlexE=; b=db7Z0ELzm+ApbLFsM9kaoTKg5fw9dbZ6VA0Cr13+Zl2LzqmSGdSDtLVH3KTB09Ekyt vrM918SYbXswzfnRiP5IYevCGXXj8avAtt+q3iS7l5RkQENFvOasfI7JrKDDq+52i2lA 4/PRS5KtpQhEPAzQXVlK52YmyDsiLxO/efb28hj+KW2B2QSeeLPQRq5hqwtspAwXBa6n ffEvYvumpV4JDPyMZYpcmSjlXIvQ2WE4GBdQ8N/f1266lHwBiuFcbj1Jzg5Ls7Nb0ziz lBQER0SA3Y8NYj/gpmtbHgZwwWnsPtsTBEddeX0KqPgbMxdq4qQ2NjmriVUNhx66YbTr zDig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=0usgNPuxO2Xbite7dIWl/eUqLBFFjy4eURRS5eQlexE=; b=mZIv/DNA9Aut1FmLq8naSTUUETbiWSMETdeUzqLm2u9ZE7sWGJJtErd4Lx8ACV57f+ yKcUD2M9O7dwKAQ6N+6lODlllYU9lK9r3gMMMfdSm4iWQprFCoWjov+ryZHHyIAxTh1f hxPPq11NuUsepdyy8nbCJvTJaCP3/MRd/3v5VBQeuyKyH5fOvRFhg2yfs8N+bXpa1b2e UtG7ITv05xJX+mvIOJcgMgkwvoWMTAzQBmq2eSf9XKxDDtxoeKvUQuJbA7gr/GJEOeNc UEgnrxNHa8w4XWmqqz7MGZaK4b/723YmtA9X7kKwXBlV9WrJL6NmutSH+KzRKmCsJt9g KZ/w== X-Gm-Message-State: AOAM5323ywtrCBNKtOtmpRrEDxZfRoEgGBFsbAZbrUFr0dGt7sFmjHeo nP5QACSyIX6/rg9xta67cYs= X-Google-Smtp-Source: ABdhPJwFX+BUrAd7opzOCSQBmNe+AAAzzMRjvfY3Q5YfyjPq15ioRx70dDlJsKdD6o6knFYNsznE3g== X-Received: by 2002:a17:90b:1986:: with SMTP id mv6mr14795706pjb.37.1641544598539; Fri, 07 Jan 2022 00:36:38 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id l1sm3909919pgn.35.2022.01.07.00.36.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jan 2022 00:36:38 -0800 (PST) From: Miaoqian Lin To: Cc: linmq006@gmail.com, Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , David Airlie , Daniel Vetter , Saravana Kannan , Ondrej Jirman , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: [PATCH] drm/sun4i: dw-hdmi: Fix missing put_device() call in sun8i_hdmi_phy_get Date: Fri, 7 Jan 2022 08:36:32 +0000 Message-Id: <20220107083633.20843-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220107_003639_249715_762137C5 X-CRM114-Status: GOOD ( 12.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The reference taken by 'of_find_device_by_node()' must be released when not needed anymore. Add the corresponding 'put_device()' in the error handling path. Fixes: 9bf3797796f5 ("drm/sun4i: dw-hdmi: Make HDMI PHY into a platform device") Signed-off-by: Miaoqian Lin --- drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c index b64d93da651d..5e2b0175df36 100644 --- a/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c +++ b/drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c @@ -658,8 +658,10 @@ int sun8i_hdmi_phy_get(struct sun8i_dw_hdmi *hdmi, struct device_node *node) return -EPROBE_DEFER; phy = platform_get_drvdata(pdev); - if (!phy) + if (!phy) { + put_device(&pdev->dev); return -EPROBE_DEFER; + } hdmi->phy = phy;