[v1,06/14] arm64: defconfig: build r8169 as a module

Message ID	20220107180314.1816515-7-marcel@ziswiler.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> From: Marcel Ziswiler <marcel@ziswiler.com> To: linux-arm-kernel@lists.infradead.org Cc: Marek Vasut <marek.vasut@gmail.com>, Marcel Ziswiler <marcel.ziswiler@toradex.com>, Arnd Bergmann <arnd@arndb.de>, Biju Das <biju.das.jz@bp.renesas.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Catalin Marinas <catalin.marinas@arm.com>, Enric Balletbo i Serra <enric.balletbo@collabora.com>, Geert Uytterhoeven <geert+renesas@glider.be>, =?utf-8?q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>, Krzysztof Kozlowski <krzk@kernel.org>, Olof Johansson <olof@lixom.net>, Shawn Guo <shawnguo@kernel.org>, Will Deacon <will@kernel.org>, linux-kernel@vger.kernel.org Subject: [PATCH v1 06/14] arm64: defconfig: build r8169 as a module Date: Fri, 7 Jan 2022 19:03:06 +0100 Message-Id: <20220107180314.1816515-7-marcel@ziswiler.com> In-Reply-To: <20220107180314.1816515-1-marcel@ziswiler.com> References: <20220107180314.1816515-1-marcel@ziswiler.com> MIME-Version: 1.0 Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org
Series	arm64: prepare and add verdin imx8m mini support \| expand [v1,00/14] arm64: prepare and add verdin imx8m mini support [v1,01/14] arm64: dts: imx8mm: fix strange hex notation [v1,02/14] dt-bindings: gpio: fix gpio-hog example [v1,03/14] arm64: defconfig: rebuild default configuration [v1,04/14] arm64: defconfig: enable bpf/cgroup firewalling [v1,05/14] arm64: defconfig: build imx-sdma as a module [v1,06/14] arm64: defconfig: build r8169 as a module [v1,07/14] arm64: defconfig: build ads1015 adc driver as a module [v1,08/14] arm64: defconfig: build lm75 temperature sensor driver as a module [v1,09/14] arm64: defconfig: build mcp251xfd can as a module [v1,10/14] arm64: defconfig: build sdio mwifiex as a module [v1,11/14] arm64: defconfig: build nxp bluetooth as modules [v1,12/14] arm64: defconfig: build nuvoton nau8822 as module [v1,13/14] dt-bindings: arm: fsl: add toradex, verdin-imx8mm et al. [v1,14/14] arm64: dts: freescale: add initial support for verdin imx8m mini

Message ID

20220107180314.1816515-7-marcel@ziswiler.com (mailing list archive)

State

New, archived

Headers

From: Marcel Ziswiler <marcel@ziswiler.com>
To: linux-arm-kernel@lists.infradead.org
Cc: Marek Vasut <marek.vasut@gmail.com>,
 Marcel Ziswiler <marcel.ziswiler@toradex.com>, Arnd Bergmann <arnd@arndb.de>,
 Biju Das <biju.das.jz@bp.renesas.com>,
 Bjorn Andersson <bjorn.andersson@linaro.org>,
 Catalin Marinas <catalin.marinas@arm.com>,
 Enric Balletbo i Serra <enric.balletbo@collabora.com>,
 Geert Uytterhoeven <geert+renesas@glider.be>,
 =?utf-8?q?Guido_G=C3=BCnther?= <agx@sigxcpu.org>,
 Krzysztof Kozlowski <krzk@kernel.org>, Olof Johansson <olof@lixom.net>,
 Shawn Guo <shawnguo@kernel.org>, Will Deacon <will@kernel.org>,
 linux-kernel@vger.kernel.org
Subject: [PATCH v1 06/14] arm64: defconfig: build r8169 as a module
Date: Fri,  7 Jan 2022 19:03:06 +0100
Message-Id: <20220107180314.1816515-7-marcel@ziswiler.com>
In-Reply-To: <20220107180314.1816515-1-marcel@ziswiler.com>
References: <20220107180314.1816515-1-marcel@ziswiler.com>
MIME-Version: 1.0
Precedence: list
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org>
Errors-To: 
 linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org

Series

arm64: prepare and add verdin imx8m mini support | expand

From: Marcel Ziswiler <marcel.ziswiler@toradex.com> Build Realtek Gigabit Ethernet driver as a module. Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Jan. 10, 2022, 8:40 a.m. UTC | #1

On 07/01/2022 19:03, Marcel Ziswiler wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Build Realtek Gigabit Ethernet driver as a module.

Why?

We see what the patch does easily, so no really need of explaining it.
What is needed here is to explain why do you do it? What board needs it?

> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> ---
> 
>  arch/arm64/configs/defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index a18785a827dc..86d39d8456c1 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -338,6 +338,7 @@ CONFIG_MLX5_CORE=m
>  CONFIG_MLX5_CORE_EN=y
>  CONFIG_QCOM_EMAC=m
>  CONFIG_RMNET=m
> +CONFIG_R8169=m
>  CONFIG_SH_ETH=y
>  CONFIG_RAVB=y
>  CONFIG_SMC91X=y
> 


Best regards,
Krzysztof

Marcel Ziswiler Jan. 14, 2022, 1:25 p.m. UTC | #2

On Mon, 2022-01-10 at 09:40 +0100, Krzysztof Kozlowski wrote:
> On 07/01/2022 19:03, Marcel Ziswiler wrote:
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > 
> > Build Realtek Gigabit Ethernet driver as a module.
> 
> Why?
> 
> We see what the patch does easily, so no really need of explaining it.
> What is needed here is to explain why do you do it? What board needs it?

Yes, I will do so in v2. Thanks!

[snip]
> Best regards,
> Krzysztof

Cheers

Marcel

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index a18785a827dc..86d39d8456c1 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -338,6 +338,7 @@  CONFIG_MLX5_CORE=m
 CONFIG_MLX5_CORE_EN=y
 CONFIG_QCOM_EMAC=m
 CONFIG_RMNET=m
+CONFIG_R8169=m
 CONFIG_SH_ETH=y
 CONFIG_RAVB=y
 CONFIG_SMC91X=y

[v1,06/14] arm64: defconfig: build r8169 as a module

Commit Message

Comments

Patch