From patchwork Sat Jan 8 08:53:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12707409 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17F3AC433F5 for ; Sat, 8 Jan 2022 08:54:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=3rk2U4kRCgzPHFobCremvJPEOC9BSjjpJpXIh003qK0=; b=jNV5+Zt5kugJ3f sSf9Lz0AdR0V/807UC9KHfcIO+GzP/nSkmPGyVcu0FO2b+KsBgITwHROWbXU1klxzvfEAyCHsQAn0 rhElEKEwctcaZijHI2PluB43g25aFs5cynJR40tBxDZx70M8p5tuHbPAOG2tfDW+I70WAzDRUKu0U tiICyju94PzCtOWNTzLh113fBQNCaUV4gXVMFm1CybPyrs0FES6UU1TJkxvgKF6RiOKYRtrXmgn4I OE/yQrQ0Yao8wJ8/9hKbWh05m43Lk9RS8nh4JtSGrRcVmZEFXdstKLXNL2cQWRSAfgLLsf4OXccbm 8utzkJY/SkSxlfa57aFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n67Tu-006B32-Ka; Sat, 08 Jan 2022 08:53:46 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n67Ts-006B2Z-4C for linux-arm-kernel@lists.infradead.org; Sat, 08 Jan 2022 08:53:45 +0000 Received: by mail-pj1-x1031.google.com with SMTP id m13so7251298pji.3 for ; Sat, 08 Jan 2022 00:53:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=7kXCs28W66sTjdWSN/kGCXx/YzaMyVz/KostDbMYDNo=; b=XYUtRnSqZLyCfMJsjZiPZ6h/tM6wDNm3I9gT0fv2sqsgH+HHPZS83umFpLfZcbkZA6 YtBJInOUEnA9DtoRjmHquuxagajzQT97tqjhwPiJvWaOuRVOIDF6t+0c9aRxLr9ofA6e +RvNPW6lDhE+/Cj0eC1X2R857mHky757FYqJGlizehwvgNdRG0jTzbNeBOZpLwnVBaEs clDEN4YXe3ULyy5kQEq1q4lUeeeaHKysiMbLuH8XK567CFvyq6oIal2zRKmeKH3xlUHb hUkmru9s0pH0grqTZ8nDUV7+JvDsRrMJreX4CM4zEPFY0tEcEheoInx0xPu8p5s+LRjq go0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7kXCs28W66sTjdWSN/kGCXx/YzaMyVz/KostDbMYDNo=; b=0250y1ErekLwnU6ZIQcIkt+Hcka5mypaGB8kXVPUdxw5WSlKqUgbcJ8DrP3hSiihGw nYLN8dPE7FjuaXEVSuXF8V0G9cHf1Z8JVfodWQpodBjWb2H+BBmODJN3t2Z7pmCfdAsm X9IUEgfJSQ4nhAbNlOpg03/PixnXHWpgHr21dYc/kMeON5spJ1OU5GH8+hW6Hc9qPvLy dt5sEj1fgiGAQkYdOM/o7BloKquoTnOG5R7SWsk70Rx1MYML+XKSzEAEcUHoIoiO4g9z K76ruagqjtCYrTpi/vaiW6LtByrYd3Dwrc5TFA25XxK7V5JIATBz/R8J7FtWW5/k7Yod Nurg== X-Gm-Message-State: AOAM530JXrZ4RrHrCuNBIpVT2DKAqgg4t3wVCDcBYV/pOFj5Th+frjAE 186eLbVyDVCZ/CWZYsCZ+z0FhoB0XsAgINj8juI= X-Google-Smtp-Source: ABdhPJxRGudJlEubQRa6AT+BqCt57yVyLI5cKLsapEtYJ/lqs2rRTAfk7sN5HbiEu0UTf+5GGsAlTA== X-Received: by 2002:a17:902:a505:b0:149:b646:a173 with SMTP id s5-20020a170902a50500b00149b646a173mr29701788plq.64.1641632022784; Sat, 08 Jan 2022 00:53:42 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id ot7sm1427048pjb.12.2022.01.08.00.53.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Jan 2022 00:53:42 -0800 (PST) From: Miaoqian Lin To: Cc: linmq006@gmail.com, Vinod Koul , Maxime Coquelin , Alexandre Torgue , Pierre-Yves MORDRET , dmaengine@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] dmaengine: stm32-dmamux: Fix PM disable depth imbalance in stm32_dmamux_probe Date: Sat, 8 Jan 2022 08:53:36 +0000 Message-Id: <20220108085336.11992-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220108_005344_210915_0207B70E X-CRM114-Status: GOOD ( 11.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The pm_runtime_enable will increase power disable depth. If the probe fails, we should use pm_runtime_disable() to balance pm_runtime_enable(). Fixes: 4f3ceca254e0 ("dmaengine: stm32-dmamux: Add PM Runtime support") Signed-off-by: Miaoqian Lin Reviewed-by: Amelie Delaunay --- drivers/dma/stm32-dmamux.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/stm32-dmamux.c b/drivers/dma/stm32-dmamux.c index a42164389ebc..d5d55732adba 100644 --- a/drivers/dma/stm32-dmamux.c +++ b/drivers/dma/stm32-dmamux.c @@ -292,10 +292,12 @@ static int stm32_dmamux_probe(struct platform_device *pdev) ret = of_dma_router_register(node, stm32_dmamux_route_allocate, &stm32_dmamux->dmarouter); if (ret) - goto err_clk; + goto pm_disable; return 0; +pm_disable: + pm_runtime_disable(&pdev->dev); err_clk: clk_disable_unprepare(stm32_dmamux->clk);