From patchwork Fri Jan 14 06:28:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12713417 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BAA23C433EF for ; Fri, 14 Jan 2022 06:30:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Na2Z8jFoOhQlZpsHUHg7W4PJrqbEUc7QgR/iVXbnDZI=; b=DHOcaKy6uN0VjV 2E3FB7HyrCqxOA9zJxSmM+iQjuLm6FNZoh+525HaDo8AWwJJThHGfBgFLooAW+M9W+66Tu5h9eHHy QpQkLs0/82hj64wtDToc9XIldl/cLm9r9ivFh9wiCQ1tBaNKzcsHzOjNLuKocYc4lkzMYkWzrlSWm +ODaySvroUBiTZ8wxQk7h0+jZCuy6CUCJCAg/msFvf0eV4SCfudOqOKBfMSel9vagAZHrRwddl3sN BwQR/Ro2o/1GYHJy/nimnPLyUBthEVbHATnS21t0naMO30XyJcBcUbTIQ41Xnd5AAYQUsZKlpIUw9 q53GcDFuAC3qqIau1tdg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8G4v-007uwS-1M; Fri, 14 Jan 2022 06:28:49 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n8G4r-007uvf-Ou for linux-arm-kernel@lists.infradead.org; Fri, 14 Jan 2022 06:28:47 +0000 Received: by mail-pj1-x102b.google.com with SMTP id l16so3117149pjl.4 for ; Thu, 13 Jan 2022 22:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=NHdX/Idy0KSD2nLQQy9QrFMUow7MTGBG5BMRWRzqKuQ=; b=pezoYFhDt474cgpvwzLmfLq36Go0YbSUqzB51UNhKvFun3Y9jKS9NcpnB6Q/RtSDeE K6COUJUvl2OfMbc2SWx6Mmys/6sP5A+m5mqXlvCTOg/epVYuoYEPYW/w66KP22U+m5rL 8rkOq4R7zE16I9nFwGl38p09fDxZRHNzQTKJsBN2Us7FTkrK6MgUuVUHfsXEMrUD/zR7 CKWIVwbRR33NGPSjln4HtgkNivJ8bbiT9KMsVCPCUjCULXCnJLdBt/DwcxklMzdxgXXZ dy7gImPjDMuS362wQF7Vo3zgxdJQmyinjOWAawjh5l0BPTpfenJlvDlTtl9Ug07Dn7pO 2XMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=NHdX/Idy0KSD2nLQQy9QrFMUow7MTGBG5BMRWRzqKuQ=; b=TuGOd1i8neMSH2D0UcNGUqy+x1VFYuZGLPJkK70WI9LNRhYVv09+FnaVW+q1jUoxt7 YLBp0n/Ac7GY115g+r6vmYemPHZrZZ5ll69bs9viYSetJoYbrZtwVrPLhM+gQJOJibbD L2AOhYiwG6g8rPUhSSq+ebR6lKmyYSHtFBQr54sccy8az9C7ppVF6GKhJRYyKjkBGv0e upBV0cz/0SLU3pKqos1JmKcIvAjBe+3qYRog7sOACgfdgeXLNNhJjIjTYEaV+ukfk4bt 0H40pMA+F/sEjvVg8MJz+KruiRgo74DBdAn6ObV9r4pGSojb9bqAJjGyFmmMO/HKvRJh 6LUQ== X-Gm-Message-State: AOAM530+MQ/Pobb7LyEb141NXAp36OTrmh2ZXiTdvj+cTrD5KOp/cpHF Uap4+p/9oKW8DpKIk/s+gHg= X-Google-Smtp-Source: ABdhPJzTCERieBADXgI0ocsue7F2NLdXSjQ9ctZymjodYFfhCh9umta1NfjscP6PU8LRgGVxF8SXwA== X-Received: by 2002:a17:90b:1c91:: with SMTP id oo17mr18602407pjb.58.1642141725333; Thu, 13 Jan 2022 22:28:45 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id ng7sm4612262pjb.41.2022.01.13.22.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jan 2022 22:28:45 -0800 (PST) From: Miaoqian Lin To: Nishanth Menon , Santosh Shilimkar , Dave Gerlach , Tony Lindgren , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linmq006@gmail.com Subject: [PATCH] soc: ti: wkup_m3_ipc: Fix IRQ check in wkup_m3_ipc_probe Date: Fri, 14 Jan 2022 06:28:40 +0000 Message-Id: <20220114062840.16620-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220113_222845_845262_021E2599 X-CRM114-Status: GOOD ( 13.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_irq() returns negative error number instead 0 on failure. And the doc of platform_get_irq() provides a usage example: int irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Fix the check of return value to catch errors correctly. Fixes: cdd5de500b2c ("soc: ti: Add wkup_m3_ipc driver") Signed-off-by: Miaoqian Lin Acked-by: Dave Gerlach --- drivers/soc/ti/wkup_m3_ipc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index 72386bd393fe..2f03ced0f411 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -450,9 +450,9 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev) return PTR_ERR(m3_ipc->ipc_mem_base); irq = platform_get_irq(pdev, 0); - if (!irq) { + if (irq < 0) { dev_err(&pdev->dev, "no irq resource\n"); - return -ENXIO; + return irq; } ret = devm_request_irq(dev, irq, wkup_m3_txev_handler,