| Message ID | 20220120224204.773117-1-nfraprado@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint | expand |
Il 20/01/22 23:42, Nícolas F. R. A. Prado ha scritto: > mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of > its DSI host. However, after fd0310b6fe7d ("drm/bridge: anx7625: add > MIPI DPI input feature"), a bus-type property started being required in > the endpoint node by the driver to indicate whether it is DSI or DPI. > > Add the missing bus-type property and set it to 5 > (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input > configured to DSI and the display pipeline can probe correctly. > > While at it, also set the data-lanes property that was also introduced > in that same commit, so that we don't rely on the default value. > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > index 8f7bf33f607d..e8f133dc96b9 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > @@ -171,6 +171,8 @@ port@0 { > > anx7625_in: endpoint { > remote-endpoint = <&dsi_out>; > + bus-type = <5>; > + data-lanes = <0 1 2 3>; > }; > }; > >
Hey, On Fri, 21 Jan 2022 at 12:46, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> wrote: > > Il 20/01/22 23:42, Nícolas F. R. A. Prado ha scritto: > > mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of > > its DSI host. However, after fd0310b6fe7d ("drm/bridge: anx7625: add > > MIPI DPI input feature"), a bus-type property started being required in > > the endpoint node by the driver to indicate whether it is DSI or DPI. > > > > Add the missing bus-type property and set it to 5 > > (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input > > configured to DSI and the display pipeline can probe correctly. > > > > While at it, also set the data-lanes property that was also introduced > > in that same commit, so that we don't rely on the default value. > > > > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> > > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > > --- > > arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > > index 8f7bf33f607d..e8f133dc96b9 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi > > @@ -171,6 +171,8 @@ port@0 { > > > > anx7625_in: endpoint { > > remote-endpoint = <&dsi_out>; > > + bus-type = <5>; > > + data-lanes = <0 1 2 3>; > > }; > > }; > > > > This patch does not pass checkpatch --strict, please add the word commit before the hash in the commit message to fix this. Rob.
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi index 8f7bf33f607d..e8f133dc96b9 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi @@ -171,6 +171,8 @@ port@0 { anx7625_in: endpoint { remote-endpoint = <&dsi_out>; + bus-type = <5>; + data-lanes = <0 1 2 3>; }; };
mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of its DSI host. However, after fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature"), a bus-type property started being required in the endpoint node by the driver to indicate whether it is DSI or DPI. Add the missing bus-type property and set it to 5 (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input configured to DSI and the display pipeline can probe correctly. While at it, also set the data-lanes property that was also introduced in that same commit, so that we don't rely on the default value. Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature") Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com> --- arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++ 1 file changed, 2 insertions(+)