| Message ID | 20220122091731.283592-8-wenst@chromium.org (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | clk: mediatek: Cleanups and Improvements - Part 1 | expand |
> struct mtk_clk_cpumux is an implementation detail of the cpumux clk > type, and is not used outside of the implementation. > > Internalize the definition to minimize leakage of details and shrink > the header file. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: Miles Chen <miles.chen@mediatek.com> > --- > drivers/clk/mediatek/clk-cpumux.c | 8 ++++++++ > drivers/clk/mediatek/clk-cpumux.h | 8 -------- > 2 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/clk/mediatek/clk-cpumux.c b/drivers/clk/mediatek/clk-cpumux.c > index 99a819e3673f..344c6399b22f 100644 > --- a/drivers/clk/mediatek/clk-cpumux.c > +++ b/drivers/clk/mediatek/clk-cpumux.c > @@ -12,6 +12,14 @@ > #include "clk-mtk.h" > #include "clk-cpumux.h" > > +struct mtk_clk_cpumux { > + struct clk_hw hw; > + struct regmap *regmap; > + u32 reg; > + u32 mask; > + u8 shift; > +}; > + > static inline struct mtk_clk_cpumux *to_mtk_clk_cpumux(struct clk_hw *_hw) > { > return container_of(_hw, struct mtk_clk_cpumux, hw); > diff --git a/drivers/clk/mediatek/clk-cpumux.h b/drivers/clk/mediatek/clk-cpumux.h > index fda7770fd803..a538f2bbef0d 100644 > --- a/drivers/clk/mediatek/clk-cpumux.h > +++ b/drivers/clk/mediatek/clk-cpumux.h > @@ -7,14 +7,6 @@ > #ifndef __DRV_CLK_CPUMUX_H > #define __DRV_CLK_CPUMUX_H > > -struct mtk_clk_cpumux { > - struct clk_hw hw; > - struct regmap *regmap; > - u32 reg; > - u32 mask; > - u8 shift; > -}; > - > int mtk_clk_register_cpumuxes(struct device_node *node, > const struct mtk_composite *clks, int num, > struct clk_onecell_data *clk_data); > -- > 2.35.0.rc0.227.g00780c9af4-goog
diff --git a/drivers/clk/mediatek/clk-cpumux.c b/drivers/clk/mediatek/clk-cpumux.c index 99a819e3673f..344c6399b22f 100644 --- a/drivers/clk/mediatek/clk-cpumux.c +++ b/drivers/clk/mediatek/clk-cpumux.c @@ -12,6 +12,14 @@ #include "clk-mtk.h" #include "clk-cpumux.h" +struct mtk_clk_cpumux { + struct clk_hw hw; + struct regmap *regmap; + u32 reg; + u32 mask; + u8 shift; +}; + static inline struct mtk_clk_cpumux *to_mtk_clk_cpumux(struct clk_hw *_hw) { return container_of(_hw, struct mtk_clk_cpumux, hw); diff --git a/drivers/clk/mediatek/clk-cpumux.h b/drivers/clk/mediatek/clk-cpumux.h index fda7770fd803..a538f2bbef0d 100644 --- a/drivers/clk/mediatek/clk-cpumux.h +++ b/drivers/clk/mediatek/clk-cpumux.h @@ -7,14 +7,6 @@ #ifndef __DRV_CLK_CPUMUX_H #define __DRV_CLK_CPUMUX_H -struct mtk_clk_cpumux { - struct clk_hw hw; - struct regmap *regmap; - u32 reg; - u32 mask; - u8 shift; -}; - int mtk_clk_register_cpumuxes(struct device_node *node, const struct mtk_composite *clks, int num, struct clk_onecell_data *clk_data);
struct mtk_clk_cpumux is an implementation detail of the cpumux clk type, and is not used outside of the implementation. Internalize the definition to minimize leakage of details and shrink the header file. Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- drivers/clk/mediatek/clk-cpumux.c | 8 ++++++++ drivers/clk/mediatek/clk-cpumux.h | 8 -------- 2 files changed, 8 insertions(+), 8 deletions(-)