From patchwork Sun Jan 23 16:22:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 12720997 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CFAF8C433EF for ; Sun, 23 Jan 2022 16:24:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NelAzJjXwsIqNmFrgTivLy0biK1XwMV+d2fjPxnQDkE=; b=eEeTuiuA8fJcE9 xFu0MQbaqQRqP+uvsZlBHNpdP2ZWlVcllJ6G1C/SSQA1k9zWB4rLlkyrr/W54io9kg2MkHNUCHTns 3nr6QhcwcLjBIfv1ubIBOdJiVTrIV7QAPNYwyHxO6zPiDS4Xa9uWdBpN8wnrrzWimylQi6mpZWpg0 rMp9CBSPxio85FUmDFWKveDroMsOZLuqpqvD0bT4nhKIJhMIjKS3/6ur69D9YCnL+l/l1a2UmSElz WPzICDhmCMSdL8/fkE4aikH7jbioQn2yXnfo75iBI9eDOdGDoSfiXgtjYneo5MkDQNmEtOKmqgtsP aK13R8zfny5J+NO46R/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBfdz-001Lc7-6D; Sun, 23 Jan 2022 16:23:07 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBfdv-001Lag-KY for linux-arm-kernel@lists.infradead.org; Sun, 23 Jan 2022 16:23:05 +0000 Received: from tr.lan (ip-89-176-112-137.net.upcbroadband.cz [89.176.112.137]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 9DF7A801FB; Sun, 23 Jan 2022 17:22:59 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1642954980; bh=mbsdXXgIXdMdv7JB7X9Uf0bxUsnnUq6EoJ9wXuDyG4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XfQzBwRgqo3Brq0Fa73ype5OaoYQIVj3d70oN1jvIu5DI6TQKEaYDUgavLsJFxbKY Us4SpS7g6AtF+Pno0VU57aZB4By22TNIX/fSuZXLltRzdLQmU+a9cSu8dQ+TKUoZGF TW1xuZBpoo8HTIIA3aDCAolvfA4R1YtrYhpZTaPWVveUEF6Gl7kPSOaCq84lsvFyKa 3bYKnhgqjLcyUJnG2B0z6StFIDiEKfx3SAnkSU+ylnUSPRSLnHMBOBmq47HhxlCEKv fezYNpuAdFA/DHNImaU4AnILS/C6Jy4+bXdznIZ/KKzMyfdI8Yr69npUm4YfZTrAvD tC3cPZaA43cMw== From: Marek Vasut To: stable@vger.kernel.org Cc: Marek Vasut , Alexandre Torgue , Fabien Dessenne , Herbert Xu , Lionel Debieve , Nicolas Toromanoff , linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Nicolas Toromanoff Subject: [PATCH] crypto: stm32/crc32 - Fix kernel BUG triggered in probe() Date: Sun, 23 Jan 2022 17:22:40 +0100 Message-Id: <20220123162240.5532-1-marex@denx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <16429542415161@kroah.com> References: <16429542415161@kroah.com> MIME-Version: 1.0 X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220123_082304_058553_093560C2 X-CRM114-Status: GOOD ( 15.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The include/linux/crypto.h struct crypto_alg field cra_driver_name description states "Unique name of the transformation provider. " ... " this contains the name of the chip or provider and the name of the transformation algorithm." In case of the stm32-crc driver, field cra_driver_name is identical for all registered transformation providers and set to the name of the driver itself, which is incorrect. This patch fixes it by assigning a unique cra_driver_name to each registered transformation provider. The kernel crash is triggered when the driver calls crypto_register_shashes() which calls crypto_register_shash(), which calls crypto_register_alg(), which calls __crypto_register_alg(), which returns -EEXIST, which is propagated back through this call chain. Upon -EEXIST from crypto_register_shash(), the crypto_register_shashes() starts unregistering the providers back, and calls crypto_unregister_shash(), which calls crypto_unregister_alg(), and this is where the BUG() triggers due to incorrect cra_refcnt. Fixes: b51dbe90912a ("crypto: stm32 - Support for STM32 CRC32 crypto module") Signed-off-by: Marek Vasut Cc: # 4.12+ Cc: Alexandre Torgue Cc: Fabien Dessenne Cc: Herbert Xu Cc: Lionel Debieve Cc: Nicolas Toromanoff Cc: linux-arm-kernel@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com To: linux-crypto@vger.kernel.org Acked-by: Nicolas Toromanoff Signed-off-by: Herbert Xu --- Backport on 4.19.225, likely works on 4.14 too. The patch likely failed to apply because the hit 5.3: fdbd643a74efb ("crypto: stm32/crc32 - rename driver file") and renamed drivers/crypto/stm32/stm32{-,_}crc32.c --- drivers/crypto/stm32/stm32_crc32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/stm32/stm32_crc32.c b/drivers/crypto/stm32/stm32_crc32.c index 47d31335c2d42..6848f34a9e66a 100644 --- a/drivers/crypto/stm32/stm32_crc32.c +++ b/drivers/crypto/stm32/stm32_crc32.c @@ -230,7 +230,7 @@ static struct shash_alg algs[] = { .digestsize = CHKSUM_DIGEST_SIZE, .base = { .cra_name = "crc32", - .cra_driver_name = DRIVER_NAME, + .cra_driver_name = "stm32-crc32-crc32", .cra_priority = 200, .cra_flags = CRYPTO_ALG_OPTIONAL_KEY, .cra_blocksize = CHKSUM_BLOCK_SIZE, @@ -252,7 +252,7 @@ static struct shash_alg algs[] = { .digestsize = CHKSUM_DIGEST_SIZE, .base = { .cra_name = "crc32c", - .cra_driver_name = DRIVER_NAME, + .cra_driver_name = "stm32-crc32-crc32c", .cra_priority = 200, .cra_flags = CRYPTO_ALG_OPTIONAL_KEY, .cra_blocksize = CHKSUM_BLOCK_SIZE,