From patchwork Wed Jan 26 00:37:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 12724403 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55348C5DF62 for ; Wed, 26 Jan 2022 00:40:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WSfmsz2Qgot07vvTwBK5A51Ed5gkxborEgwoTO0qTP8=; b=MKGRE6h0jPcE8m YijG61QLP0Q+Bzl8HmaaPK5nx1Hhe1xyiH3JU77STuUY1uPfBqnOWaFthC7Ka+cl6MsTyZWvW89ww 6v34clHrV5EKU1OSyrM/XLnaDMmEs4ZVeq0gG/VEMfzy3A69ET6AutYyBqJEVVXqkUSneYdNt+tAT dwJWKbt17ScLhuv0cRMulQB+1mGuRJOTYWh6Ax7AcPsa/guHOlhVd1CSNggYCfQZS5W3ocIEj2ZS7 mTHcXNKFidwGUzW4kwlKA4hbD8gmPBRtN8vL+P9wC91AHKSykBpHCmHb9rSA9/1HT1R+qWHnKSMl1 EUF+STlQWTOqR8UW9BTg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCWKI-009jyC-Nr; Wed, 26 Jan 2022 00:38:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nCWK7-009jtz-G3 for linux-arm-kernel@lists.infradead.org; Wed, 26 Jan 2022 00:38:08 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F8D2614F1; Wed, 26 Jan 2022 00:38:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 35E40C340EE; Wed, 26 Jan 2022 00:38:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1643157486; bh=VTJqecm5X/zvzaE/jGRrIqxDW1iScy7AUV6tqYM48Zg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bNndjlWv82LFPFnnsSndsTmWMhAwNTi4FrfawdlBXjBlaTOngUa0rzoomz0aPxrP0 PkWWY1I3/9rzoLXkmg8V2tetmof706MO4AA+yyyEEjN3olqEr+vLMZOUXx1L/FMO5p gF+KzPrss/YhTTL5HKVYySFj8YPJhL6cFUi6b4THbl/yMxkv65huX8tECYZhCSjhF+ goajC3YT7jtxFUHBSCP6aah84FU+3YyPjUZTML2b78nRQzflVYWizxGsMknvzShzqg MneFhGCpytk5J6ZuxqhPUkr48k7WcouQINmkyQeXK0ZjQK60OsUcUBV16qGuCUIN81 8gaG3/wYXe1rg== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, dave@thedillows.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, Jakub Kicinski Subject: [PATCH net v2 3/6] ethernet: broadcom/sb1250-mac: don't write directly to netdev->dev_addr Date: Tue, 25 Jan 2022 16:37:58 -0800 Message-Id: <20220126003801.1736586-4-kuba@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220126003801.1736586-1-kuba@kernel.org> References: <20220126003801.1736586-1-kuba@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220125_163807_600912_7B4066C0 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org netdev->dev_addr is const now. Compile tested bigsur_defconfig and sb1250_swarm_defconfig. Fixes: adeef3e32146 ("net: constify netdev->dev_addr") Signed-off-by: Jakub Kicinski --- drivers/net/ethernet/broadcom/sb1250-mac.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c b/drivers/net/ethernet/broadcom/sb1250-mac.c index f38f40eb966e..a1a38456c9a3 100644 --- a/drivers/net/ethernet/broadcom/sb1250-mac.c +++ b/drivers/net/ethernet/broadcom/sb1250-mac.c @@ -2183,9 +2183,7 @@ static int sbmac_init(struct platform_device *pldev, long long base) ea_reg >>= 8; } - for (i = 0; i < 6; i++) { - dev->dev_addr[i] = eaddr[i]; - } + eth_hw_addr_set(dev, eaddr); /* * Initialize context (get pointers to registers and stuff), then