From patchwork Thu Jan 27 23:07:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 12727509 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C630C433EF for ; Thu, 27 Jan 2022 23:12:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HWvD7/9q8dpwdDl+DBtroWarjeIEBLqPPRebCPXLPmk=; b=WMSbVWOg+rmtQf bBSYiYcRkw9rx86VFl8UQL+cyUQSLUl3naMn4cJjmi5XI9YSfMsNh0JCYEhe+F05Gob/kbdMQeSqx t44wFU9h2X7VFZ7rnIMsEVM9+U4gLzUc9AIBllfQ6k5qoFnZcItba+Y2yOaXv0nCc1VWjL9aCJySh PbYnalVm3scf5jgEpcBylKSFii+m0MAw/YR356JI27sppfWQhRNV4tH7Mj5cOijmQopLS4tPQV0+u PpfeFUM1Av0p3SzkOvz08CDK8DpknrQnMINrN3C48KKMPwawXmcQAGXqb8h9DdkPhbKD6WOchYU+k fIHQTdsYTOU+zSMCSvYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDDv2-00HHay-8s; Thu, 27 Jan 2022 23:11:09 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDDsb-00HGNX-3v for linux-arm-kernel@lists.infradead.org; Thu, 27 Jan 2022 23:08:38 +0000 Received: by mail-pg1-x52f.google.com with SMTP id z131so3632465pgz.12 for ; Thu, 27 Jan 2022 15:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=S7JkzSF7lxJgCpd6ZXDkhdvjrfqNJJ5Wge2dT4ZFw7o=; b=QkHrDYVuucq5tGrwY+7ofVKvafE8N1vG6K7wssS8MFOLQ8A+qT44Pw8OkxznULsPLE fU0ppcxIbnnoe3DkKlONgnWitZdR6bHPjT1zDXJKdypl9iivtwyPlKX/9eCq/YqaK+Iu BWm6b0pbXYtrWPXRj7GPsRq0ghVWt5Gr/dEag= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=S7JkzSF7lxJgCpd6ZXDkhdvjrfqNJJ5Wge2dT4ZFw7o=; b=B6HFPSsQdC0psmpDPldeUyXZQa9GnzR02EERcP/gViSSyO/N6eig2JfT43Xp+ZXIsF V29G0Ej7mSy3AR1LwOb3cTI0H57nG+dWGXy+9unHcxUpj0rF6GnwCUu5OrP4/Vw4j5QN f1tNJrlrSlOhHWj55obmHkbMtuPUCLUnpfM/U96HdXP655F+z++zzUSnblFUXfu70tNE ViNedHg5Tnhu5eCZTL/zjy1uPojx8wdwiW6owIwZIxjXe7aC41kTzr5gdF077lE/QZPO UseCJG6Ohsi12V0EizcC6A4edHwZzwSCnpykArF9zoZWYp7WUQFuY2Vqpe8WpMXDiYQo RHtw== X-Gm-Message-State: AOAM532zaQKhlDgqrG2HHlE86uRnJ61cq0tuBeQmthB0mXgP3dwTl9qB zTIrV+TxvFwt7QUIIzmTuuA7nw== X-Google-Smtp-Source: ABdhPJxGSe8Or1J7VdvMjjKei+W+lXlkhGyA7m0Vzqh1YDxZLw6gaRpY1PqHnE/am+HMGfaQbFydiw== X-Received: by 2002:a63:6c44:: with SMTP id h65mr4438729pgc.100.1643324915912; Thu, 27 Jan 2022 15:08:35 -0800 (PST) Received: from localhost ([2620:15c:202:201:723d:38a9:9e7f:3435]) by smtp.gmail.com with UTF8SMTPSA id f8sm4740841pfe.204.2022.01.27.15.08.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jan 2022 15:08:35 -0800 (PST) From: Brian Norris To: MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Rob Herring Cc: linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Lin Huang , linux-arm-kernel@lists.infradead.org, Derek Basehore , devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Heiko Stuebner , Brian Norris Subject: [PATCH v2 06/15] PM / devfreq: rk3399_dmc: Drop undocumented ondemand DT props Date: Thu, 27 Jan 2022 15:07:17 -0800 Message-Id: <20220127150615.v2.6.I4bd77eb751d5bfce8346bfed576bcacb28e4550f@changeid> X-Mailer: git-send-email 2.35.0.rc0.227.g00780c9af4-goog In-Reply-To: <20220127230727.3369358-1-briannorris@chromium.org> References: <20220127230727.3369358-1-briannorris@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220127_150837_188616_AE751F7E X-CRM114-Status: GOOD ( 13.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org These properties are: * undocumented * directly representing software properties, not hardware properties * unused (no in-tree users, yet; this IP block has so far only been used in downstream kernels) Let's just stick the values that downstream users have been using directly in the driver and call it a day. Signed-off-by: Brian Norris --- (no changes since v1) drivers/devfreq/rk3399_dmc.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c index 293857ebfd75..e982862f6ac2 100644 --- a/drivers/devfreq/rk3399_dmc.c +++ b/drivers/devfreq/rk3399_dmc.c @@ -430,10 +430,8 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev) goto err_edev; } - of_property_read_u32(np, "upthreshold", - &data->ondemand_data.upthreshold); - of_property_read_u32(np, "downdifferential", - &data->ondemand_data.downdifferential); + data->ondemand_data.upthreshold = 25; + data->ondemand_data.downdifferential = 15; data->rate = clk_get_rate(data->dmc_clk);