| Message ID | 20220127172105.4085950-3-vladimir.oltean@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Use sl28cpld driver for the LS1028A-QDS QIXIS FPGA | expand |
On Thu, Jan 27, 2022 at 07:21:04PM +0200, Vladimir Oltean wrote: > The LS1028A-QDS QIXIS FPGA has no problem working with the > simple-mfd-i2c.c driver, so extend the list of compatible strings to > include that part. > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > --- > Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml > index eb3b43547cb6..8c1216eb36ee 100644 > --- a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml > +++ b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml > @@ -16,7 +16,9 @@ description: | > > properties: > compatible: > - const: kontron,sl28cpld > + enum: > + - fsl,ls1028a-qds-qixis-i2c > + - kontron,sl28cpld Is there some relationship between these besides happening to use the same driver? Sharing a generic driver is not a reason to have the same binding doc. Your DT has a mux-controller which is undocuemnted in this binding. Rob
On Fri, Feb 11, 2022 at 07:01:42AM -0600, Rob Herring wrote: > On Thu, Jan 27, 2022 at 07:21:04PM +0200, Vladimir Oltean wrote: > > The LS1028A-QDS QIXIS FPGA has no problem working with the > > simple-mfd-i2c.c driver, so extend the list of compatible strings to > > include that part. > > > > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > --- > > Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml > > index eb3b43547cb6..8c1216eb36ee 100644 > > --- a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml > > +++ b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml > > @@ -16,7 +16,9 @@ description: | > > > > properties: > > compatible: > > - const: kontron,sl28cpld > > + enum: > > + - fsl,ls1028a-qds-qixis-i2c > > + - kontron,sl28cpld > > Is there some relationship between these besides happening to use the > same driver? Sharing a generic driver is not a reason to have the same > binding doc. > > Your DT has a mux-controller which is undocuemnted in this binding. > > Rob I'd guess they are both programmable FPGA's/CPLD's that are used for board control. What I don't know is whether the sources for the Kontron bit stream are derived in any way from the QIXIS. I can look into adding a separate binding doc for the QIXIS anyway.
Am 2022-02-11 14:24, schrieb Vladimir Oltean: > On Fri, Feb 11, 2022 at 07:01:42AM -0600, Rob Herring wrote: >> On Thu, Jan 27, 2022 at 07:21:04PM +0200, Vladimir Oltean wrote: >> > The LS1028A-QDS QIXIS FPGA has no problem working with the >> > simple-mfd-i2c.c driver, so extend the list of compatible strings to >> > include that part. >> > >> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> >> > --- >> > Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml | 4 +++- >> > 1 file changed, 3 insertions(+), 1 deletion(-) >> > >> > diff --git a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml >> > index eb3b43547cb6..8c1216eb36ee 100644 >> > --- a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml >> > +++ b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml >> > @@ -16,7 +16,9 @@ description: | >> > >> > properties: >> > compatible: >> > - const: kontron,sl28cpld >> > + enum: >> > + - fsl,ls1028a-qds-qixis-i2c >> > + - kontron,sl28cpld >> >> Is there some relationship between these besides happening to use the >> same driver? Sharing a generic driver is not a reason to have the same >> binding doc. Ahh didn't notice this. Yes that should probably go into an own binding. >> Your DT has a mux-controller which is undocuemnted in this binding. >> >> Rob > > I'd guess they are both programmable FPGA's/CPLD's that are used for > board control. What I don't know is whether the sources for the Kontron > bit stream are derived in any way from the QIXIS. I can 100% guarantee that is not the case ;) > I can look into adding a separate binding doc for the QIXIS anyway. -michael
diff --git a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml index eb3b43547cb6..8c1216eb36ee 100644 --- a/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml +++ b/Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml @@ -16,7 +16,9 @@ description: | properties: compatible: - const: kontron,sl28cpld + enum: + - fsl,ls1028a-qds-qixis-i2c + - kontron,sl28cpld reg: description:
The LS1028A-QDS QIXIS FPGA has no problem working with the simple-mfd-i2c.c driver, so extend the list of compatible strings to include that part. Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> --- Documentation/devicetree/bindings/mfd/kontron,sl28cpld.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)