diff mbox series

ARM: dts: bcm2711: Fix comment

Message ID 20220205195802.52449-1-rs@noreya.tech (mailing list archive)
State New, archived
Headers show
Series ARM: dts: bcm2711: Fix comment | expand

Commit Message

Richard Schleich Feb. 5, 2022, 7:58 p.m. UTC
No functional change.

Signed-off-by: Richard Schleich <rs@noreya.tech>
---
 arch/arm/boot/dts/bcm2711.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Wahren Feb. 6, 2022, 12:55 p.m. UTC | #1
Hi Richard,

the subject of this patch is too general. Here is my suggestion:

ARM: dts: bcm2711: Fix comment about L2 cache set calculation

But maybe you have a better idea.

Am 05.02.22 um 20:58 schrieb Richard Schleich:
> No functional change.

Please write a simple sentence, explaining why this change is necessary.

Thanks

>
> Signed-off-by: Richard Schleich <rs@noreya.tech>
> ---
>  arch/arm/boot/dts/bcm2711.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index d9f31873e711..0f2f26dc5ec6 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -536,7 +536,7 @@ l2: l2-cache0 {
>  			compatible = "cache";
>  			cache-size = <0x100000>;
>  			cache-line-size = <64>;
> -			cache-sets = <1024>; // 1MiB(size)/64(line-size)=16000ways/16-way set
> +			cache-sets = <1024>; // 1MiB(size)/64(line-size)=16384ways/16-way set
>  			cache-level = <2>;
>  		};
>  	};
Florian Fainelli Feb. 11, 2022, 10:23 p.m. UTC | #2
On Sat,  5 Feb 2022 20:58:02 +0100, Richard Schleich <rs@noreya.tech> wrote:
> No functional change.
> 
> Signed-off-by: Richard Schleich <rs@noreya.tech>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
Florian Fainelli Feb. 11, 2022, 10:24 p.m. UTC | #3
On 2/11/22 2:23 PM, Florian Fainelli wrote:
> On Sat,  5 Feb 2022 20:58:02 +0100, Richard Schleich <rs@noreya.tech> wrote:
>> No functional change.
>>
>> Signed-off-by: Richard Schleich <rs@noreya.tech>
>> ---
> 
> Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!

Squashed into "ARM: dts: bcm2711: Add the missing L1/L2 cache
information", thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
index d9f31873e711..0f2f26dc5ec6 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -536,7 +536,7 @@  l2: l2-cache0 {
 			compatible = "cache";
 			cache-size = <0x100000>;
 			cache-line-size = <64>;
-			cache-sets = <1024>; // 1MiB(size)/64(line-size)=16000ways/16-way set
+			cache-sets = <1024>; // 1MiB(size)/64(line-size)=16384ways/16-way set
 			cache-level = <2>;
 		};
 	};