From patchwork Mon Feb 7 16:35:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12737665 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E5B4C433EF for ; Mon, 7 Feb 2022 16:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QFKCZOkEVXmOHr2pkVht8JZ8BgTu/zP2l67saSHwqSM=; b=MMyX1qLIw6JgRD o7SGj/RuIBNfxjVmjLbYjbJ4OrrO6L9I9Cjwbsa/V7b0kNE1wRUUbCCadqerGjMtvPMAKU8Q3nO1R IcV7Ic34nHzC7Nh1bZEHVlTJvTpmMlCoATJEDTmXAJXZ856sy8amZjSlDsstLRVVMEGVEwQYj6YJI 4IIBamLkEu1AtqGs1QOB72WxBWsQlWPUGocmMVcXnz07dCuxUsXu8hYTEfjbWpWlBO6BhpIuXGQ4o ei4NZHN0R8+4MyKPJap4t2OBVQ40Vwzl8taLNg2hC8nqdrJa4ICrrCjKAU1d47baTllgl8iH4kcpl B165ccTKupOd3tyxrNMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH75v-00BAWL-Oy; Mon, 07 Feb 2022 16:42:28 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH6zY-00B850-Bz for linux-arm-kernel@lists.infradead.org; Mon, 07 Feb 2022 16:35:53 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id DE89D5801E3; Mon, 7 Feb 2022 11:35:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 07 Feb 2022 11:35:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=xhKVkS6XIZgUH0LRLr+qOPiV5PE9/Z MNzxpdkFVUd1Q=; b=Xd3R5cOhPJN7Wz5H5LxykZUI5Aub4u9z3b0wuRF6LrcPP1 LZjDRV2v1hXEPqQyhaUrbtEqG66GM4UYSUvN1f3Ty5JTbJfYXe8EFbnBibGi0Gsp NELHLgbdDapZT1/k276lVwoHQq50lwj+WJt1FEJhq0MA4uaTYKcoNzrZ2UXlJqaW J7CYXL/s97dZQHw8aeV7SRaAQc3z+yzZzG8ii2RcIul9iMY+VT6longG6Jc8/Xvl Ji7uwjrEumP12kGY2BZwB9lThAzJ2K3KPfi4O+dpdvfubRuawoiln8Q/FmjvNzSf sha+o3B1pVjn0Y3Ku/LseXNy2NhdXRJB7e8baelA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=xhKVkS 6XIZgUH0LRLr+qOPiV5PE9/ZMNzxpdkFVUd1Q=; b=b4fk5q7Q4sPW8OhQDSgjfv PbRoOen5Z6TfAFGoVYXCLDySJfXXPj6R6M22QvNFHy6A81bT6jE2Ddpy2QIagfOi PBoPe/tbbBZI/TGKImwj9JaP7emep8HgyNHYwzMJQ6zKnofIVhi+iG3463kY9kcL /NzB5VgZviP/jj+FYmSYnpHrd5Vi46SFG6Ux0OA9WIEGzMm8+otQ2SwCnuxHIhrP qDZ/02mjghwhux9s1dXE3/RVxYSvzwPPjS2e4FkqXNMUWbnjK9M9uDDBOzU0Z5lh cq6gK0RmWUtP9TBbtTpbuuomtnXeKaJBgtBhC9stZNhLfjB0L/M/bDTyJARHg6fw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheehgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Feb 2022 11:35:49 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Fabio Estevam , Pengutronix Kernel Team , Philipp Zabel , Sascha Hauer , Shawn Guo Subject: [PATCH 11/23] drm/imx: ipuv3-plane: Remove redundant zpos initialisation Date: Mon, 7 Feb 2022 17:35:03 +0100 Message-Id: <20220207163515.1038648-12-maxime@cerno.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207163515.1038648-1-maxime@cerno.tech> References: <20220207163515.1038648-1-maxime@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220207_083552_533305_CB06EE2E X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The imx KMS driver will call drm_plane_create_zpos_property() with an init value depending on the plane purpose. Since the initial value wasn't carried over in the state, the driver had to set it again in ipu_plane_state_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: linux-arm-kernel@lists.infradead.org Cc: NXP Linux Team Cc: Fabio Estevam Cc: Pengutronix Kernel Team Cc: Philipp Zabel Cc: Sascha Hauer Cc: Shawn Guo Signed-off-by: Maxime Ripard --- drivers/gpu/drm/imx/ipuv3-plane.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 846c1aae69c8..414bdf08d0b0 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -297,7 +297,6 @@ void ipu_plane_disable_deferred(struct drm_plane *plane) static void ipu_plane_state_reset(struct drm_plane *plane) { - unsigned int zpos = (plane->type == DRM_PLANE_TYPE_PRIMARY) ? 0 : 1; struct ipu_plane_state *ipu_state; if (plane->state) { @@ -311,8 +310,6 @@ static void ipu_plane_state_reset(struct drm_plane *plane) if (ipu_state) { __drm_atomic_helper_plane_reset(plane, &ipu_state->base); - ipu_state->base.zpos = zpos; - ipu_state->base.normalized_zpos = zpos; ipu_state->base.color_encoding = DRM_COLOR_YCBCR_BT601; ipu_state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE; }