From patchwork Mon Feb 7 16:35:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12737667 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03AB0C433F5 for ; Mon, 7 Feb 2022 16:46:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MXO+ojQ06RaRoJIY5Cb+Hw8mLAe6uiY0j/ryWVCmYPc=; b=jl3RpgR4JAev0z 5ndvAW9IGcrVMHgQWCKlvf01ToMtu+Rrpi/2K3s7pBBeyMIRUJPgzyk4zI0OaAWyXMs4aJCErUAXm yukeYEiBd8mKVl9F9fo+qAD9rJMLN2nEivtbMPhDYun9yFLtxoLJWrgU/EOcFb3wq+rx2NTclnWHp HU1lhoQmtlPzhb1xlyJxuIZqB+N1EiExtXT0MjDFEYsRl4T5bjrt/rIDJGgsdCYYYtLJqQWrNdkHL JxlI9IhGbB8ZMAA/kydQ8XNwXsXlIzpkyCvFcA8kcrdyzbAAmsQGF8wpSOmeAql1jlOYqsfwJuMW4 U7N3IREHQbKXInPQ7WVg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH77r-00BBAY-9M; Mon, 07 Feb 2022 16:44:28 +0000 Received: from new4-smtp.messagingengine.com ([66.111.4.230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nH70A-00B8Ol-Cx for linux-arm-kernel@lists.infradead.org; Mon, 07 Feb 2022 16:36:31 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailnew.nyi.internal (Postfix) with ESMTP id 85FCC5801E3; Mon, 7 Feb 2022 11:36:29 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 07 Feb 2022 11:36:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=tUuaRCM/V57xS9/bxKdm9N2vJq5Tzx 2/8M4BwH//DCw=; b=EKLjIlwXiuwSfrh1YY+hlnIq0lkj48KvVHElSH8XMkQIjS /BCsrIgBFdePDReTCqNA1rrnyMUxoQGJlu4c5utKVaBDT3A9CjLINTUvRyOXCHue 1U/hxx+AhWB7QXPSAy0XJMYg/R7S/nTkpC1n9qLO/7TeDE210vbybntZDQOlBbjo QT8U75d7qt2TANGIRVF0go/+sAw4wHi0L6YFNsExQ2bachUtd+BEdIii5zF5AcWy 9uw5I6RXSjRzTGwhfXlIi52kr4hWmeRR+Q0TvBbrNDLUWZ6DQ66vtXI0dkPArj0F YCx5+M6BtJGbEKJkWgQKNZMzCvEt6zd8tDBqhdmQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=tUuaRC M/V57xS9/bxKdm9N2vJq5Tzx2/8M4BwH//DCw=; b=g7Y5TPiIhLDun0TfsIw3LW GTE+NmIy03RNei/nTYEgOWTLCI2AApJ+FX4ilEfPnwV+90RZvEtppO9uF0E4Dw8Z Px0jHbY9yfraODQDC6yi39sIAHE8XO8fBULEo7wDvFMeY12KrheaCURkVDSrvtgR oZcb7l6kp6b10gbXlRenGFOePsyU3ZALepHakhka+LhwpWpq/5vytKds0urjSQQS esh++tdgFxUa9Kzt2sJ3P78UN+goUa2CbSBecUCgmlrZ0XrlbL2h6QJO/6BCIrtP u9o+gl9bCtn3ugb4CxHu/i480KdXNa6i6ip13I02UWZ0/gxYa9PI/8iQwvXQc/tA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrheehgdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 7 Feb 2022 11:36:28 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Cc: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Fabio Estevam , Pengutronix Kernel Team , Philipp Zabel , Sascha Hauer , Shawn Guo Subject: [PATCH 22/23] drm/imx: ipuv3-plane: Remove redundant color encoding and range initialisation Date: Mon, 7 Feb 2022 17:35:14 +0100 Message-Id: <20220207163515.1038648-23-maxime@cerno.tech> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207163515.1038648-1-maxime@cerno.tech> References: <20220207163515.1038648-1-maxime@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220207_083630_561581_37E24DF6 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The imx KMS driver will call drm_plane_create_color_properties() with a default encoding and range values of BT601 and Limited Range, respectively. Since the initial value wasn't carried over in the state, the driver had to set it again in ipu_plane_state_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: linux-arm-kernel@lists.infradead.org Cc: NXP Linux Team Cc: Fabio Estevam Cc: Pengutronix Kernel Team Cc: Philipp Zabel Cc: Sascha Hauer Cc: Shawn Guo Signed-off-by: Maxime Ripard --- drivers/gpu/drm/imx/ipuv3-plane.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 414bdf08d0b0..36b32e8806e3 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -308,11 +308,8 @@ static void ipu_plane_state_reset(struct drm_plane *plane) ipu_state = kzalloc(sizeof(*ipu_state), GFP_KERNEL); - if (ipu_state) { + if (ipu_state) __drm_atomic_helper_plane_reset(plane, &ipu_state->base); - ipu_state->base.color_encoding = DRM_COLOR_YCBCR_BT601; - ipu_state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE; - } } static struct drm_plane_state *