diff mbox series

arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required

Message ID 20220211110204.162344-1-sudeep.holla@arm.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as required | expand

Commit Message

Sudeep Holla Feb. 11, 2022, 11:02 a.m. UTC
The SCMI binding clearly states the value of #thermal-sensor-cells must
be 1. However arch/arm64/boot/dts/freescale/imx8ulp.dtsi sets it 0 which
results in the following warning with dtbs_check:

  |  arch/arm64/boot/dts/freescale/imx8ulp-evk.dt.yaml: scmi:
  | 		protocol@15:#thermal-sensor-cells:0:0: 1 was expected
  |	From schema: Documentation/devicetree/bindings/firmware/arm,scmi.yaml

Fix it by setting it to 1 as required.

Cc:Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Fabio Estevam Feb. 11, 2022, 11:47 a.m. UTC | #1
Hi Sudeep,

On Fri, Feb 11, 2022 at 8:02 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> The SCMI binding clearly states the value of #thermal-sensor-cells must
> be 1. However arch/arm64/boot/dts/freescale/imx8ulp.dtsi sets it 0 which
> results in the following warning with dtbs_check:
>
>   |  arch/arm64/boot/dts/freescale/imx8ulp-evk.dt.yaml: scmi:
>   |             protocol@15:#thermal-sensor-cells:0:0: 1 was expected
>   |     From schema: Documentation/devicetree/bindings/firmware/arm,scmi.yaml
>
> Fix it by setting it to 1 as required.
>
> Cc:Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Peng Fan Feb. 13, 2022, 3:23 a.m. UTC | #2
> Subject: [PATCH] arm64: dts: imx8ulp: Set #thermal-sensor-cells to 1 as
> required
> 
> The SCMI binding clearly states the value of #thermal-sensor-cells must be 1.
> However arch/arm64/boot/dts/freescale/imx8ulp.dtsi sets it 0 which results
> in the following warning with dtbs_check:
> 
>   |  arch/arm64/boot/dts/freescale/imx8ulp-evk.dt.yaml: scmi:
>   | 		protocol@15:#thermal-sensor-cells:0:0: 1 was expected
>   |	From schema:
> Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> 
> Fix it by setting it to 1 as required.
> 
> Cc:Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Acked-by: Peng Fan <peng.fan@nxp.com>

> ---
>  arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> index a987ff7156bd..09f7364dd1d0 100644
> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
> @@ -132,7 +132,7 @@ scmi_devpd: protocol@11 {
> 
>  			scmi_sensor: protocol@15 {
>  				reg = <0x15>;
> -				#thermal-sensor-cells = <0>;
> +				#thermal-sensor-cells = <1>;
>  			};
>  		};
>  	};
> --
> 2.25.1
Shawn Guo Feb. 13, 2022, 4:58 a.m. UTC | #3
On Fri, Feb 11, 2022 at 11:02:04AM +0000, Sudeep Holla wrote:
> The SCMI binding clearly states the value of #thermal-sensor-cells must
> be 1. However arch/arm64/boot/dts/freescale/imx8ulp.dtsi sets it 0 which
> results in the following warning with dtbs_check:
> 
>   |  arch/arm64/boot/dts/freescale/imx8ulp-evk.dt.yaml: scmi:
>   | 		protocol@15:#thermal-sensor-cells:0:0: 1 was expected
>   |	From schema: Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> 
> Fix it by setting it to 1 as required.
> 
> Cc:Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
index a987ff7156bd..09f7364dd1d0 100644
--- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
@@ -132,7 +132,7 @@  scmi_devpd: protocol@11 {
 
 			scmi_sensor: protocol@15 {
 				reg = <0x15>;
-				#thermal-sensor-cells = <0>;
+				#thermal-sensor-cells = <1>;
 			};
 		};
 	};