| Message ID | 20220211180216.290133-4-jacopo@jmondi.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | media: De-stage imx7-mipi-csis.c | expand |
Hi Jacopo, Thank you for the patch. On Fri, Feb 11, 2022 at 07:02:16PM +0100, Jacopo Mondi wrote: > Remove the references to the i.MX7 in the driver description and expand > it with more information about the IP core the driver controls. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> > --- > drivers/media/platform/imx/imx-mipi-csis.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/platform/imx/imx-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c > index a22d0e6b3d44..59f4485bbe70 100644 > --- a/drivers/media/platform/imx/imx-mipi-csis.c > +++ b/drivers/media/platform/imx/imx-mipi-csis.c > @@ -1,6 +1,10 @@ > // SPDX-License-Identifier: GPL-2.0 > /* > - * Freescale i.MX7 SoC series MIPI-CSI V3.3 receiver driver > + * CSIS MIPI CSI-2 receiver driver. "CSIS" states for "CSI Slave", there's also a CSIM core available from Samsung. As you acknowledge the Samsung origin in the next paragraph, I'd write * Samsung CSIS CSI-2 receiver driver > + * > + * CSIS is an IP core originating from Samsung found in NXP i.MX7 and i.MX8 > + * SoC series. i.MX7 features version 3.3 of the IP, while i.MX8 features > + * version 3.6.3 And maybe this could then become * The Samsung CSIS IP is a MIPI CSI-2 receiver found in various NXP i.MX7 and * i.MX8 SoCs. The i.MX7 features version 3.3 of the IP, while i.MX8 features * version 3.6.3 Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > * > * Copyright (C) 2019 Linaro Ltd > * Copyright (C) 2015-2016 Freescale Semiconductor, Inc. All Rights Reserved. > @@ -31,7 +35,7 @@ > #include <media/v4l2-mc.h> > #include <media/v4l2-subdev.h> > > -#define CSIS_DRIVER_NAME "imx7-mipi-csis" > +#define CSIS_DRIVER_NAME "imx-mipi-csis" > > #define CSIS_PAD_SINK 0 > #define CSIS_PAD_SOURCE 1 > @@ -1515,4 +1519,4 @@ module_platform_driver(mipi_csis_driver); > > MODULE_DESCRIPTION("i.MX7 & i.MX8 MIPI CSI-2 receiver driver"); > MODULE_LICENSE("GPL v2"); > -MODULE_ALIAS("platform:imx7-mipi-csi2"); > +MODULE_ALIAS("platform:imx-mipi-csi2");
diff --git a/drivers/media/platform/imx/imx-mipi-csis.c b/drivers/media/platform/imx/imx-mipi-csis.c index a22d0e6b3d44..59f4485bbe70 100644 --- a/drivers/media/platform/imx/imx-mipi-csis.c +++ b/drivers/media/platform/imx/imx-mipi-csis.c @@ -1,6 +1,10 @@ // SPDX-License-Identifier: GPL-2.0 /* - * Freescale i.MX7 SoC series MIPI-CSI V3.3 receiver driver + * CSIS MIPI CSI-2 receiver driver. + * + * CSIS is an IP core originating from Samsung found in NXP i.MX7 and i.MX8 + * SoC series. i.MX7 features version 3.3 of the IP, while i.MX8 features + * version 3.6.3 * * Copyright (C) 2019 Linaro Ltd * Copyright (C) 2015-2016 Freescale Semiconductor, Inc. All Rights Reserved. @@ -31,7 +35,7 @@ #include <media/v4l2-mc.h> #include <media/v4l2-subdev.h> -#define CSIS_DRIVER_NAME "imx7-mipi-csis" +#define CSIS_DRIVER_NAME "imx-mipi-csis" #define CSIS_PAD_SINK 0 #define CSIS_PAD_SOURCE 1 @@ -1515,4 +1519,4 @@ module_platform_driver(mipi_csis_driver); MODULE_DESCRIPTION("i.MX7 & i.MX8 MIPI CSI-2 receiver driver"); MODULE_LICENSE("GPL v2"); -MODULE_ALIAS("platform:imx7-mipi-csi2"); +MODULE_ALIAS("platform:imx-mipi-csi2");
Remove the references to the i.MX7 in the driver description and expand it with more information about the IP core the driver controls. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- drivers/media/platform/imx/imx-mipi-csis.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)