From patchwork Thu Feb 17 13:56:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eugen Hristev X-Patchwork-Id: 12750235 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD381C433EF for ; Thu, 17 Feb 2022 14:11:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=r+kfZyMlFI6PSKAstZRnNyEba9mbRwlCQsrZDJpKVxg=; b=Xw1eRIzQmJ2Qt0 nics+2hBYFYmKB4KFcD192ceFUJj3vQ8MemkJCLT6mRH+6P4nOIU+LV3k8bg8CAks9BkzgrKunF1W xXhfTJ8YeNyYvpC5qi+hzPAiVkED7f7WQZuVUIpiq3lh/jr+xFEa/qj691/RV/C62ATxxxV31rZks CvgnIBIz5oCIOzfHSwfRtaXESLDzENQ3TBh+WIClfbZ/n7ayw6lgnnK8uaE1hvcMIxwIFNY0QLZ/q y4wsyB/gVibdcJ0jpQIZjYHKSSdMcyr/WtiysVlfEQvLdZDqwc8Oth9ftSi4c1SXnddEn7XrbcOPm 8/Dzhn1SFBE7j4WRFHNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKhTi-00AtgD-P1; Thu, 17 Feb 2022 14:09:52 +0000 Received: from esa.microchip.iphmx.com ([68.232.153.233]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nKhIF-00Anyb-QY for linux-arm-kernel@lists.infradead.org; Thu, 17 Feb 2022 13:58:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1645106279; x=1676642279; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=krqpNlGU1PyCsmPAJWzacDtV9sBcV2Yf9rfYsyaElPs=; b=1h6dzferH76P6mJ9L+R5ec+93u8ZAiI5TK2uIQSZ3vMX/DAUS4evYdBZ AVJaNjmgnN0MaeSxVn4x21HvoHTH0f34W8WeLsus7atv8hDeuGzt7wM6c jIHCG6iNFnWhaGUC7ht9IyPejKZczRXXIH561RtpNKwOrwaIXKHe/Ztw/ VpX5j6mgWJihYIjhDGaLIIkke/1haZ1Ol2lc/JzrFalk4GFaU5i1aEweG ekQORWsNwtMsWm7ycrMcwsNUY04YK7t/HzjZTNhS69Xv8h6D70HrmItfz 5RpIq/rM4z9DwIqp0SjW6JZvBXHzDsvfnQcSUJVXoQmcESSCn7uAJq90K w==; IronPort-SDR: gYTH9kugQOH1rISpRLFhtViMg24Ex7QEFg6i2IzA9ybnDdBsvduPkQZ9HpdcrKEH9yeVO61Dpj cL6mbLD4TBnk2A/pmN//O4gZZjn2xaxLMluuboa24zHPRY4lMxFWGgX8n7YXslpcBRj8ARDL4B z0C8sG+JQef47SDXPjqmypSUzs5Ghhip8P8AvybdED+XZvbFdOMkiIoEFDA18w2NMJsSEvC9ST ouFp/n+/TI9QHkqfWnY7SP/IZ6mFG5HEkC4y/nOMnBJ+37h/iev0oFmiB7qmAM1Isn7K3HxnOl Kx+mYLgMJOoiOYlY9kkrRGvE X-IronPort-AV: E=Sophos;i="5.88,376,1635231600"; d="scan'208";a="162631981" Received: from smtpout.microchip.com (HELO email.microchip.com) ([198.175.253.82]) by esa1.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 17 Feb 2022 06:57:58 -0700 Received: from chn-vm-ex04.mchp-main.com (10.10.85.152) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.17; Thu, 17 Feb 2022 06:57:58 -0700 Received: from ROB-ULT-M18282.microchip.com (10.10.115.15) by chn-vm-ex04.mchp-main.com (10.10.85.152) with Microsoft SMTP Server id 15.1.2375.17 via Frontend Transport; Thu, 17 Feb 2022 06:57:37 -0700 From: Eugen Hristev To: , , , CC: , , , , "Eugen Hristev" , Hans Verkuil Subject: [PATCH v5 02/13] media: atmel: atmel-isc-base: replace is_streaming call in s_fmt_vid_cap Date: Thu, 17 Feb 2022 15:56:34 +0200 Message-ID: <20220217135645.1427466-3-eugen.hristev@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220217135645.1427466-1-eugen.hristev@microchip.com> References: <20220217135645.1427466-1-eugen.hristev@microchip.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220217_055759_905759_5F4C9268 X-CRM114-Status: GOOD ( 10.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org In s_fmt_vid_cap, we should check if vb2_is_busy and return EBUSY, not check if it's streaming to return the busy state. Suggested-by: Hans Verkuil Signed-off-by: Eugen Hristev Reviewed-by: Jacopo Mondi --- drivers/media/platform/atmel/atmel-isc-base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/atmel/atmel-isc-base.c b/drivers/media/platform/atmel/atmel-isc-base.c index d2cc6c99984f..67b4a2323fed 100644 --- a/drivers/media/platform/atmel/atmel-isc-base.c +++ b/drivers/media/platform/atmel/atmel-isc-base.c @@ -1029,7 +1029,7 @@ static int isc_s_fmt_vid_cap(struct file *file, void *priv, { struct isc_device *isc = video_drvdata(file); - if (vb2_is_streaming(&isc->vb2_vidq)) + if (vb2_is_busy(&isc->vb2_vidq)) return -EBUSY; return isc_set_fmt(isc, f);