From patchwork Mon Feb 21 09:59:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12753403 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73A7EC433F5 for ; Mon, 21 Feb 2022 10:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PVWZQXsF1DOOD5WLTGO5pVBNVFGVK8tpSs/ljv/mihg=; b=xpIixkruoOgA7+ U1P6e9+IPAi6tLZerU6bXUytx35DLuMd4aqSCvuWj/S9RPO6nPOtl8ufLTYOK33yC/Ur+uAcNiro4 u8TQUg+h3KZvYftoTE7p3WK3BVWDQDd+x3G/4uESMDb5PzKMxwspPYH/5OmTRqy5hy4uRMkw5MklK ViwMer4m0QITHjHBwWVLy2BmfWUP7+sxr3X8vJfqCejgpvNNdNKoHS7G7rdjDpLDRLZfHxkuATJAC oxVh0T74RX0rC9p275KS+oVc2IVTOL5PRgWAM9O1blwx7hPKXbDQKn1NzXXhNZIHfQGyTuANCfUcW XFDO5JcR3cnF9b7n4MBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM63e-0050JJ-Ub; Mon, 21 Feb 2022 10:36:44 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM5Tu-004jIc-E0 for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 09:59:48 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 8F94658025F; Mon, 21 Feb 2022 04:59:45 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Mon, 21 Feb 2022 04:59:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=SBKxndqRJqKTGvR4OSR8aSqZ+CMFFL Md5Wo8SczSeY0=; b=U8DTRtD3oTrkbtNcH2d7Uus7uiq3VRFP+rZ1I/Cjo9/xDW NNVc0iT5az6Us1qjD9S4tQLzz5248KEyehA70OwSTXyennyBjXwK0bn1AQHQ1U0w m31a3Ii0iwAyuKgoQX6d2/WHsdLfj2OI5KsilA1abC8SUdjCJxu89Wu38o9H9YWV FmWvg75598w09E5n9kSZkwzX/jqbA4gCuTB+TGBLv5FPt6JCF+3pYFC1YjWtqRfz OMGLuzKRH+iFDK+xYS2cjAcDI2EBaA6yUMs1h0PwyPzDcVNDt2asJcf5qITG8SRe 5+RL1EU1Uhlymo/S+iVRwDiNkwKVhL+rA0l1+FNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=SBKxnd qRJqKTGvR4OSR8aSqZ+CMFFLMd5Wo8SczSeY0=; b=BjitJw1W4NWeRT6fQXc3aj /YILW97eHipeUKO2Qz5qbxwI+ekmL69kv8AugrLf7BB8TM1fzNyqLU0iuxfW4bTx 0c3SuUXTnypNcYY3Pn4CjmjAqztO3xIhKXeLJfom8sYtQXCBVsbcyO1HQJrBwBCK PgrmFE790755IAR7ummwU9Paqf4GNQuAlHE3fG6qJ9yAkSb98u7peF1JUeb1K0Hg qB/1e4x2n0Hk7ik/KkW8jEAUIukeDKSbImMl1gwmrV7kPndBtpyN4yxU9pDhj0G3 eheVhZa/tLQyicAodHR4/A/jcZfL7XKywW0gryd6Obd4mQnG30h6YPA+QwHGm3pQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeeigddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Feb 2022 04:59:43 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Cc: Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Alim Akhtar , Inki Dae , Joonyoung Shim , Krzysztof Kozlowski , Kyungmin Park , Seung-Woo Kim Subject: [PATCH v2 10/22] drm/exynos: plane: Remove redundant zpos initialisation Date: Mon, 21 Feb 2022 10:59:06 +0100 Message-Id: <20220221095918.18763-11-maxime@cerno.tech> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221095918.18763-1-maxime@cerno.tech> References: <20220221095918.18763-1-maxime@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_015946_592653_B4FBA448 X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The exynos KMS driver will call drm_plane_create_zpos_property() with an init value depending on the plane purpose. Since the initial value wasn't carried over in the state, the driver had to set it again in exynos_drm_plane_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: Alim Akhtar Cc: Inki Dae Cc: Joonyoung Shim Cc: Krzysztof Kozlowski Cc: Kyungmin Park Cc: Seung-Woo Kim Signed-off-by: Maxime Ripard --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c index df76bdee7dca..3615cf329e32 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c @@ -122,7 +122,6 @@ static void exynos_plane_mode_set(struct exynos_drm_plane_state *exynos_state) static void exynos_drm_plane_reset(struct drm_plane *plane) { - struct exynos_drm_plane *exynos_plane = to_exynos_plane(plane); struct exynos_drm_plane_state *exynos_state; if (plane->state) { @@ -133,10 +132,8 @@ static void exynos_drm_plane_reset(struct drm_plane *plane) } exynos_state = kzalloc(sizeof(*exynos_state), GFP_KERNEL); - if (exynos_state) { + if (exynos_state) __drm_atomic_helper_plane_reset(plane, &exynos_state->base); - plane->state->zpos = exynos_plane->config->zpos; - } } static struct drm_plane_state *