From patchwork Mon Feb 21 09:59:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maxime Ripard X-Patchwork-Id: 12753409 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93097C433F5 for ; Mon, 21 Feb 2022 10:43:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7P2cZ9QUT4+LlVmcUMRkwVjaTb8wHFN0ZrqRCKIN/nk=; b=zfljnP55dBY1PT DEeJZARVR6kUoLgumqsC/39Ws9vZ3TEQhqKGh9ILgdZA7XDrOBV9M9HAvyVBuw5qIkhF0SSCt6RqY T+O2J582RJpAduHDTbmFP7XIIFiV+ji2UWyehwPw/yJy2VdluYfYErkJwqOj/vUOT5a/FJC5t6afi LlISXUvazsAJW++c50uVJgaizvyCoZTzggPm19mJnU3PkAC7WTRYruWoH3l3wWyYJ2pm1cbKVxRLh UlHaQMTdxim6BVfoKwyYF/B3tU/mnyyQOcpJX97gu24jBI93e/ZsA71Qm71EF/Pij5HB9ZJcIxS4r srlqMtCYEQFxcRNkuDHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM68Z-0052gb-3Z; Mon, 21 Feb 2022 10:41:49 +0000 Received: from new2-smtp.messagingengine.com ([66.111.4.224]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nM5UK-004jXW-O0 for linux-arm-kernel@lists.infradead.org; Mon, 21 Feb 2022 10:00:14 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailnew.nyi.internal (Postfix) with ESMTP id F1B26580263; Mon, 21 Feb 2022 05:00:11 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 21 Feb 2022 05:00:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h=cc :cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; bh=wo7FPeVWcNwQpaAIKec1keSAY7TMIw rBbsYQO8S+w+A=; b=B8FgR3sCJLWpKMtN0zAS+wpJW16KR5RFXlIZF13uiyprbG gktvFBUgER6uhSV32IFptkArPlQQGCeZroHs7DWpZQwFp9b61ekxXY3AzvtXA/Vt S3qh50NfX0SagN+EoSrAnN8YLbphrkPalYQco8MTtojaUf8WAFLVLMBLTIvRnCQJ rZq6Evn3U1wj6oalunOXcnTFX2EeMVxNSdRDy2hkQxY9HW9zs/f4QwmEsV8BeEPZ uLEOoyaPuq06XQAEzISMNLlTbejilOFPc/i6faWnF5Vcu+jrd0Vz4y/O2SmZezH6 6/ww7ra47rlQJRewPuh2yEpljX813gIgTC/tEB9w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=wo7FPe VWcNwQpaAIKec1keSAY7TMIwrBbsYQO8S+w+A=; b=CsnfciTxo0Le1GCB7XPs9d yX2Fs0vYWJc0yDjpcF4w76mbNUUydjqWmOgLRlqDTxBWNFOUaqPsbWPsWRQtZTGv 5Utm6Bs/mdtC+3rQMkfxGJnMrXlARNUSoIMJCbI8IRM16FaZ2v248/ZXwkTnXzJi gU+8on1nCMEtR82FLrBjooHLE1KJI3psrQQ2owIyFtIF5y+cbuFcf5RbNiD9AFNQ vLRQ8wriKgELvaxpQrDnoTMJAXYG43WkkH4JMdexkusgQS93b8VRZ1sHSoJmhxqh 2K+56acy5rfomJE8c2n5Sfx0hERsMaInI/sCvDpTZnzWFwAnd2zeyLNxV9P3YEaQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrkeeigddtlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpedvkeelveefffekjefhffeuleetleefudeifeehuddugffghffhffehveevheeh vdenucevlhhushhtvghrufhiiigvpeefnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 21 Feb 2022 05:00:10 -0500 (EST) From: Maxime Ripard To: Daniel Vetter , David Airlie Cc: Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , dri-devel@lists.freedesktop.org, Maarten Lankhorst , Thomas Zimmermann , Maxime Ripard , linux-arm-kernel@lists.infradead.org, NXP Linux Team , Fabio Estevam , Pengutronix Kernel Team , Philipp Zabel , Sascha Hauer , Shawn Guo Subject: [PATCH v2 21/22] drm/imx: ipuv3-plane: Remove redundant color encoding and range initialisation Date: Mon, 21 Feb 2022 10:59:17 +0100 Message-Id: <20220221095918.18763-22-maxime@cerno.tech> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220221095918.18763-1-maxime@cerno.tech> References: <20220221095918.18763-1-maxime@cerno.tech> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220221_020012_928565_E92571FE X-CRM114-Status: GOOD ( 11.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The imx KMS driver will call drm_plane_create_color_properties() with a default encoding and range values of BT601 and Limited Range, respectively. Since the initial value wasn't carried over in the state, the driver had to set it again in ipu_plane_state_reset(). However, the helpers have been adjusted to set it properly at reset, so this is not needed anymore. Cc: linux-arm-kernel@lists.infradead.org Cc: NXP Linux Team Cc: Fabio Estevam Cc: Pengutronix Kernel Team Cc: Philipp Zabel Cc: Sascha Hauer Cc: Shawn Guo Signed-off-by: Maxime Ripard --- drivers/gpu/drm/imx/ipuv3-plane.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c index 414bdf08d0b0..36b32e8806e3 100644 --- a/drivers/gpu/drm/imx/ipuv3-plane.c +++ b/drivers/gpu/drm/imx/ipuv3-plane.c @@ -308,11 +308,8 @@ static void ipu_plane_state_reset(struct drm_plane *plane) ipu_state = kzalloc(sizeof(*ipu_state), GFP_KERNEL); - if (ipu_state) { + if (ipu_state) __drm_atomic_helper_plane_reset(plane, &ipu_state->base); - ipu_state->base.color_encoding = DRM_COLOR_YCBCR_BT601; - ipu_state->base.color_range = DRM_COLOR_YCBCR_LIMITED_RANGE; - } } static struct drm_plane_state *