Message ID | 20220225172350.69797-3-andriy.shevchenko@linux.intel.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 18CD1C433F5 for <linux-arm-kernel@archiver.kernel.org>; Fri, 25 Feb 2022 17:25:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i2B/EceG8Xfnt9GrSVThOTTLqqQRGWi1fy8NL0gulHw=; b=C5oPETjYOM1bdI LyU3a55X9n2Udpb9xV5FC7vS+UFAHaVbrJN3xMqYLyXY0xMHTsaBj4zo+xVX59/+4nJTt4DOChKRX 2J7I5etxJNPbW3YkHxtb3zmc82GBOizVenlrliBKW+IQBDllzGgNGs3W23zn+n1V6PRLS30aw/nZi X0EtOQKyMETBIVpWIi2jUNtqnBTjItGN1SeBXrFzxKAHCW4dLKMhj/eaFRgrEGG+YQLIbUWOrtG6f /C/B8apumERdHl3qER2G7kf/Hf2DUnxfsPOfQtvMzuZPYzRuAbMYk1yL7rFVfz3Wh7czs9M7nO3+g tmAfQsX6BOaEaibC1m/A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNeKN-006CU4-Qr; Fri, 25 Feb 2022 17:24:24 +0000 Received: from mga02.intel.com ([134.134.136.20]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nNeK7-006CNY-Fi for linux-arm-kernel@lists.infradead.org; Fri, 25 Feb 2022 17:24:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645809847; x=1677345847; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9LLMwd1jVSyGmHE1y7UKIpXT8gXtNszNsq3PrfwGTQs=; b=ct4GtdqtlkpGmdU7HsYjP8u8t7e2nyLp4hp7eu6rRMHBywbUa4TlY4Dc k7aQ/Ogxb/P/FMey0cBBJNf4YUs7tHKt3NzdeVTJh8RfXTp8lMFCOUnwU IoZF0GHhtcanXwHzvRNV9qDPs26zkSw2cvF0SRo89Kl2nkaS7gnQzLnhk Wu/qFFWEEOew/Axcdb8SDOwx88+aLKvX37FkkEgbmHJVFenNKUKkiGKm4 giLjHR0suZzfVy0BTFEVyituazH9RyQRRQOfAPBn80CkaewvRdy95vU2Z kWm9sNpqWpIS/jj39+MXcTNJyjtR0xG4eXDNynwVV7qG3N6dUdcq5c30T g==; X-IronPort-AV: E=McAfee;i="6200,9189,10268"; a="239944344" X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="239944344" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Feb 2022 09:24:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,136,1643702400"; d="scan'208";a="574661102" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 25 Feb 2022 09:24:04 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4D0CD12C; Fri, 25 Feb 2022 19:24:21 +0200 (EET) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Mark Brown <broonie@kernel.org> Subject: [PATCH v1 03/11] spi: pxa2xx-pci: Drop redundant NULL check in ->probe() Date: Fri, 25 Feb 2022 19:23:42 +0200 Message-Id: <20220225172350.69797-3-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220225172350.69797-1-andriy.shevchenko@linux.intel.com> References: <20220225172350.69797-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220225_092407_604200_2E2CB0B0 X-CRM114-Status: GOOD ( 14.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org |
Series |
[v1,01/11] spi: pxa2xx-pci: Refactor CE4100 to use ->setup()
|
expand
|
diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c index 4d617ad72bca..90b95e49a164 100644 --- a/drivers/spi/spi-pxa2xx-pci.c +++ b/drivers/spi/spi-pxa2xx-pci.c @@ -255,11 +255,9 @@ static int pxa2xx_spi_pci_probe(struct pci_dev *dev, return ret; c = &spi_info_configs[ent->driver_data]; - if (c->setup) { - ret = c->setup(dev, c); - if (ret) - return ret; - } + ret = c->setup(dev, c); + if (ret) + return ret; memset(&spi_pdata, 0, sizeof(spi_pdata)); spi_pdata.num_chipselect = c->num_chipselect;
Since all platforms are using ->setup() function, drop unneeded check. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/spi/spi-pxa2xx-pci.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)