From patchwork Mon Feb 28 18:14:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Jernej_=C5=A0krabec?= X-Patchwork-Id: 12763621 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8781C433FE for ; Mon, 28 Feb 2022 18:16:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=0VcEEUrWh0uoOouwtd1QCuxXdFo6ZGO1tRMdWg7BHuo=; b=Stg7UqR1y0Dj1Q V48psNsjuccVbiSQXfs/QPUvTfXynsG+ZecOQCht6wL8dPA/CkFZWkoCMUIdd5UbnmUlEDpP6MIYS l8IqkJnEr0q25rR0DMKw+Eqm/vOF20MqVIBvsk9alDS0OSNHLwht+3uzeKioyCok95Zjz+RCA9h4N JoIyM+RLlksgtZjH7qtZZNMqzVhn/nzD29Ano1EoRCC4APvnmJKYhtf6CBxbGVHVQNb1ZLE8x9TGJ QeDqE8hyS6oflNiNBGMOdmbEFYTFY5yAH6kAF9Ohztu29PjqDHOLTuY4K/9X6MPyEc5y2Aj5TbOpx npoAy//clRG7PGxgaCAg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOkXm-00DgRE-RD; Mon, 28 Feb 2022 18:14:47 +0000 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOkXj-00DgPz-RV for linux-arm-kernel@lists.infradead.org; Mon, 28 Feb 2022 18:14:45 +0000 Received: by mail-wr1-x436.google.com with SMTP id s1so16760931wrg.10 for ; Mon, 28 Feb 2022 10:14:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=laSnQJpbry/7HDfeFASKUPW4HYc9KBwUxVn9S4td0qc=; b=c0WRI4mazSMxTdg2exnk+Q3pEXI74oiHYivOcAxyKozC7Y4/wrofRWWnCvtaPZhGxR IhujeWQfFo00DEXYokFGtCEV1Nn/dkAzptGSD5IEwXwkYfvy1qfoB3e94L+04fLU12+3 pcpQ7uF/jzshj84kJryjM8O1p3msTMRKDo8oU509HnrI67clNXOfUUBLIc4+upY8iJaR lijHIn+cImvx6w0OH/8X7tgsuHtgADaACEwj7KzCQe1+ShF5wzUkQf1V0VpMSUNCbwen iJRaVoijltE0Hg7tQ28uZOYG9wwLUfhgUw87xdeEs/IH4v0p+SOczJhRr0p1Uu2joV3V 27AQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=laSnQJpbry/7HDfeFASKUPW4HYc9KBwUxVn9S4td0qc=; b=rKTVS8x+IStyFLwabeKbhUm+FJdkf5qDA/uLuBhmfP0YtpwzRa6Gr2PtF7dhLAtTwy N4JXaHIshnIInlEHEHvQ7/y7meOKCcOWKEbaiw9ZiyWkDmuhpZBncAtpUWj14A+IU6Ha x9yu7NbgSRCEcokTDN30DXl0zYQbGXAU/MFtB5eXkRt3eMMNCf3Vup6sznS5AwwpcOhZ wFqXqGMpehQ4Cr61OT4C7Vtwlz6x4MdTANf9wjLOYyLnvS6AVgwnJ42SFnuoaRzata08 T8QpBWhrZh4cgjwmRkjHPEug64/ZOTHV5FgIDwxHc109U+cfGPftmmTz+tBvRy9BmdVh zihA== X-Gm-Message-State: AOAM532DNYNtPchgN6rMFcIrSB3UAqGenJ0No5No5M08bePBxt8dHmHM Q+sqhJsQLB66mah5dHf4+HA= X-Google-Smtp-Source: ABdhPJyhltbPdhysi/wISTmoSAx5kNxmU7sMGyLPJmQFUN5FgbPAW2+eU+jUkbBOfunmlYPPW6hcbw== X-Received: by 2002:a5d:648f:0:b0:1e9:5445:4b13 with SMTP id o15-20020a5d648f000000b001e954454b13mr16540343wri.127.1646072082307; Mon, 28 Feb 2022 10:14:42 -0800 (PST) Received: from kista.localdomain (cpe-86-58-32-107.static.triera.net. [86.58.32.107]) by smtp.gmail.com with ESMTPSA id z2-20020a056000110200b001e7140ddb44sm10780677wrw.49.2022.02.28.10.14.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 10:14:41 -0800 (PST) From: Jernej Skrabec To: mripard@kernel.org, wens@csie.org Cc: samuel@sholland.org, airlied@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec Subject: [PATCH] drm/sun4i: mixer: Fix P010 and P210 format numbers Date: Mon, 28 Feb 2022 19:14:36 +0100 Message-Id: <20220228181436.1424550-1-jernej.skrabec@gmail.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220228_101443_907999_177A7E14 X-CRM114-Status: GOOD ( 10.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org It turns out that DE3 manual has inverted YUV and YVU format numbers for P010 and P210. Invert them. This was tested by playing video decoded to P010 and additionally confirmed by looking at BSP driver source. Fixes: 169ca4b38932 ("drm/sun4i: Add separate DE3 VI layer formats") Signed-off-by: Jernej Skrabec --- drivers/gpu/drm/sun4i/sun8i_mixer.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun8i_mixer.h b/drivers/gpu/drm/sun4i/sun8i_mixer.h index 145833a9d82d..5b3fbee18671 100644 --- a/drivers/gpu/drm/sun4i/sun8i_mixer.h +++ b/drivers/gpu/drm/sun4i/sun8i_mixer.h @@ -111,10 +111,10 @@ /* format 13 is semi-planar YUV411 VUVU */ #define SUN8I_MIXER_FBFMT_YUV411 14 /* format 15 doesn't exist */ -/* format 16 is P010 YVU */ -#define SUN8I_MIXER_FBFMT_P010_YUV 17 -/* format 18 is P210 YVU */ -#define SUN8I_MIXER_FBFMT_P210_YUV 19 +#define SUN8I_MIXER_FBFMT_P010_YUV 16 +/* format 17 is P010 YVU */ +#define SUN8I_MIXER_FBFMT_P210_YUV 18 +/* format 19 is P210 YVU */ /* format 20 is packed YVU444 10-bit */ /* format 21 is packed YUV444 10-bit */